| 1 |
# Copyright (C) Viktor Szakats |
| 2 |
# SPDX-License-Identifier: BSD-3-Clause |
| 3 |
|
| 4 |
include(CheckCCompilerFlag) |
| 5 |
|
| 6 |
option(ENABLE_WERROR "Turn compiler warnings into errors" OFF) |
| 7 |
option(PICKY_COMPILER "Enable picky compiler options" ON) |
| 8 |
|
| 9 |
if(ENABLE_WERROR) |
| 10 |
if(MSVC) |
| 11 |
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /WX") |
| 12 |
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX") |
| 13 |
else() # llvm/clang and gcc style options |
| 14 |
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Werror") |
| 15 |
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror") |
| 16 |
endif() |
| 17 |
endif() |
| 18 |
|
| 19 |
if(MSVC) |
| 20 |
# Use the highest warning level for Visual Studio. |
| 21 |
if(PICKY_COMPILER) |
| 22 |
if(CMAKE_CXX_FLAGS MATCHES "[/-]W[0-4]") |
| 23 |
string(REGEX REPLACE "[/-]W[0-4]" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") |
| 24 |
else() |
| 25 |
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W4") |
| 26 |
endif() |
| 27 |
if(CMAKE_C_FLAGS MATCHES "[/-]W[0-4]") |
| 28 |
string(REGEX REPLACE "[/-]W[0-4]" "/W4" CMAKE_C_FLAGS "${CMAKE_C_FLAGS}") |
| 29 |
else() |
| 30 |
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /W4") |
| 31 |
endif() |
| 32 |
endif() |
| 33 |
elseif(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX OR CMAKE_C_COMPILER_ID MATCHES "Clang") |
| 34 |
|
| 35 |
# https://clang.llvm.org/docs/DiagnosticsReference.html |
| 36 |
# https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html |
| 37 |
|
| 38 |
if(NOT CMAKE_CXX_FLAGS MATCHES "-Wall") |
| 39 |
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall") |
| 40 |
endif() |
| 41 |
if(NOT CMAKE_C_FLAGS MATCHES "-Wall") |
| 42 |
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall") |
| 43 |
endif() |
| 44 |
|
| 45 |
if(PICKY_COMPILER) |
| 46 |
|
| 47 |
# WPICKY_ENABLE = Options we want to enable as-is. |
| 48 |
# WPICKY_DETECT = Options we want to test first and enable if available. |
| 49 |
|
| 50 |
# Prefer the -Wextra alias with clang. |
| 51 |
if(CMAKE_C_COMPILER_ID MATCHES "Clang") |
| 52 |
set(WPICKY_ENABLE "-Wextra") |
| 53 |
else() |
| 54 |
set(WPICKY_ENABLE "-W") |
| 55 |
endif() |
| 56 |
|
| 57 |
list(APPEND WPICKY_ENABLE |
| 58 |
-pedantic |
| 59 |
) |
| 60 |
|
| 61 |
if(ENABLE_WERROR) |
| 62 |
list(APPEND WPICKY_ENABLE |
| 63 |
-pedantic-errors |
| 64 |
) |
| 65 |
endif() |
| 66 |
|
| 67 |
# ---------------------------------- |
| 68 |
# Add new options here, if in doubt: |
| 69 |
# ---------------------------------- |
| 70 |
set(WPICKY_DETECT |
| 71 |
) |
| 72 |
|
| 73 |
# Assume these options always exist with both clang and gcc. |
| 74 |
# Require clang 3.0 / gcc 2.95 or later. |
| 75 |
list(APPEND WPICKY_ENABLE |
| 76 |
-Wbad-function-cast # clang 2.7 gcc 2.95 |
| 77 |
-Wconversion # clang 2.7 gcc 2.95 |
| 78 |
-Winline # clang 1.0 gcc 1.0 |
| 79 |
-Wmissing-declarations # clang 1.0 gcc 2.7 |
| 80 |
-Wmissing-prototypes # clang 1.0 gcc 1.0 |
| 81 |
-Wnested-externs # clang 1.0 gcc 2.7 |
| 82 |
-Wno-long-long # clang 1.0 gcc 2.95 |
| 83 |
-Wno-multichar # clang 1.0 gcc 2.95 |
| 84 |
-Wpointer-arith # clang 1.0 gcc 1.4 |
| 85 |
-Wshadow # clang 1.0 gcc 2.95 |
| 86 |
-Wsign-compare # clang 1.0 gcc 2.95 |
| 87 |
-Wundef # clang 1.0 gcc 2.95 |
| 88 |
-Wunused # clang 1.1 gcc 2.95 |
| 89 |
-Wwrite-strings # clang 1.0 gcc 1.4 |
| 90 |
) |
| 91 |
|
| 92 |
# Always enable with clang, version dependent with gcc |
| 93 |
set(WPICKY_COMMON_OLD |
| 94 |
-Waddress # clang 2.7 gcc 4.3 |
| 95 |
-Wattributes # clang 2.7 gcc 4.1 |
| 96 |
-Wcast-align # clang 1.0 gcc 4.2 |
| 97 |
-Wdeclaration-after-statement # clang 1.0 gcc 3.4 |
| 98 |
-Wdiv-by-zero # clang 2.7 gcc 4.1 |
| 99 |
-Wempty-body # clang 2.7 gcc 4.3 |
| 100 |
-Wendif-labels # clang 1.0 gcc 3.3 |
| 101 |
-Wfloat-equal # clang 1.0 gcc 2.96 (3.0) |
| 102 |
-Wformat-security # clang 2.7 gcc 4.1 |
| 103 |
-Wignored-qualifiers # clang 2.8 gcc 4.3 |
| 104 |
-Wmissing-field-initializers # clang 2.7 gcc 4.1 |
| 105 |
-Wmissing-noreturn # clang 2.7 gcc 4.1 |
| 106 |
-Wno-format-nonliteral # clang 1.0 gcc 2.96 (3.0) |
| 107 |
-Wno-system-headers # clang 1.0 gcc 3.0 |
| 108 |
# -Wpadded # clang 2.9 gcc 4.1 # Not used because we cannot change public structs |
| 109 |
-Wold-style-definition # clang 2.7 gcc 3.4 |
| 110 |
-Wredundant-decls # clang 2.7 gcc 4.1 |
| 111 |
-Wsign-conversion # clang 2.9 gcc 4.3 |
| 112 |
-Wno-error=sign-conversion # FIXME |
| 113 |
-Wstrict-prototypes # clang 1.0 gcc 3.3 |
| 114 |
# -Wswitch-enum # clang 2.7 gcc 4.1 # Not used because this basically disallows default case |
| 115 |
-Wtype-limits # clang 2.7 gcc 4.3 |
| 116 |
-Wunreachable-code # clang 2.7 gcc 4.1 |
| 117 |
-Wunused-macros # clang 2.7 gcc 4.1 |
| 118 |
-Wunused-parameter # clang 2.7 gcc 4.1 |
| 119 |
-Wvla # clang 2.8 gcc 4.3 |
| 120 |
) |
| 121 |
|
| 122 |
set(WPICKY_COMMON |
| 123 |
-Wdouble-promotion # clang 3.6 gcc 4.6 appleclang 6.3 |
| 124 |
-Wenum-conversion # clang 3.2 gcc 10.0 appleclang 4.6 g++ 11.0 |
| 125 |
-Wpragmas # clang 3.5 gcc 4.1 appleclang 6.0 |
| 126 |
-Wunused-const-variable # clang 3.4 gcc 6.0 appleclang 5.1 |
| 127 |
) |
| 128 |
|
| 129 |
if(CMAKE_C_COMPILER_ID MATCHES "Clang") |
| 130 |
list(APPEND WPICKY_ENABLE |
| 131 |
${WPICKY_COMMON_OLD} |
| 132 |
-Wshift-sign-overflow # clang 2.9 |
| 133 |
-Wshorten-64-to-32 # clang 1.0 |
| 134 |
-Wlanguage-extension-token # clang 3.0 |
| 135 |
-Wformat=2 # clang 3.0 gcc 4.8 |
| 136 |
) |
| 137 |
# Enable based on compiler version |
| 138 |
if((CMAKE_C_COMPILER_ID STREQUAL "Clang" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 3.6) OR |
| 139 |
(CMAKE_C_COMPILER_ID STREQUAL "AppleClang" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 6.3)) |
| 140 |
list(APPEND WPICKY_ENABLE |
| 141 |
${WPICKY_COMMON} |
| 142 |
-Wunreachable-code-break # clang 3.5 appleclang 6.0 |
| 143 |
-Wheader-guard # clang 3.4 appleclang 5.1 |
| 144 |
-Wsometimes-uninitialized # clang 3.2 appleclang 4.6 |
| 145 |
) |
| 146 |
endif() |
| 147 |
if((CMAKE_C_COMPILER_ID STREQUAL "Clang" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 3.9) OR |
| 148 |
(CMAKE_C_COMPILER_ID STREQUAL "AppleClang" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 8.3)) |
| 149 |
list(APPEND WPICKY_ENABLE |
| 150 |
-Wcomma # clang 3.9 appleclang 8.3 |
| 151 |
-Wmissing-variable-declarations # clang 3.2 appleclang 4.6 |
| 152 |
) |
| 153 |
endif() |
| 154 |
if((CMAKE_C_COMPILER_ID STREQUAL "Clang" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 7.0) OR |
| 155 |
(CMAKE_C_COMPILER_ID STREQUAL "AppleClang" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 10.3)) |
| 156 |
list(APPEND WPICKY_ENABLE |
| 157 |
-Wassign-enum # clang 7.0 appleclang 10.3 |
| 158 |
-Wextra-semi-stmt # clang 7.0 appleclang 10.3 |
| 159 |
) |
| 160 |
endif() |
| 161 |
if((CMAKE_C_COMPILER_ID STREQUAL "Clang" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 10.0) OR |
| 162 |
(CMAKE_C_COMPILER_ID STREQUAL "AppleClang" AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 12.4)) |
| 163 |
list(APPEND WPICKY_ENABLE |
| 164 |
-Wimplicit-fallthrough # clang 4.0 gcc 7.0 appleclang 12.4 # we have silencing markup for clang 10.0 and above only |
| 165 |
) |
| 166 |
endif() |
| 167 |
else() # gcc |
| 168 |
list(APPEND WPICKY_DETECT |
| 169 |
${WPICKY_COMMON} |
| 170 |
) |
| 171 |
# Enable based on compiler version |
| 172 |
if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 4.3) |
| 173 |
list(APPEND WPICKY_ENABLE |
| 174 |
${WPICKY_COMMON_OLD} |
| 175 |
-Wclobbered # gcc 4.3 |
| 176 |
-Wmissing-parameter-type # gcc 4.3 |
| 177 |
-Wold-style-declaration # gcc 4.3 |
| 178 |
-Wstrict-aliasing=3 # gcc 4.0 |
| 179 |
-Wtrampolines # gcc 4.3 |
| 180 |
) |
| 181 |
endif() |
| 182 |
if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 4.5 AND MINGW) |
| 183 |
list(APPEND WPICKY_ENABLE |
| 184 |
-Wno-pedantic-ms-format # gcc 4.5 (mingw-only) |
| 185 |
) |
| 186 |
endif() |
| 187 |
if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 4.8) |
| 188 |
list(APPEND WPICKY_ENABLE |
| 189 |
-Wformat=2 # clang 3.0 gcc 4.8 |
| 190 |
) |
| 191 |
endif() |
| 192 |
if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 5.0) |
| 193 |
list(APPEND WPICKY_ENABLE |
| 194 |
-Warray-bounds=2 -ftree-vrp # clang 3.0 gcc 5.0 (clang default: -Warray-bounds) |
| 195 |
) |
| 196 |
endif() |
| 197 |
if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 6.0) |
| 198 |
list(APPEND WPICKY_ENABLE |
| 199 |
-Wduplicated-cond # gcc 6.0 |
| 200 |
-Wnull-dereference # clang 3.0 gcc 6.0 (clang default) |
| 201 |
-fdelete-null-pointer-checks |
| 202 |
-Wshift-negative-value # clang 3.7 gcc 6.0 (clang default) |
| 203 |
-Wshift-overflow=2 # clang 3.0 gcc 6.0 (clang default: -Wshift-overflow) |
| 204 |
) |
| 205 |
endif() |
| 206 |
if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 7.0) |
| 207 |
list(APPEND WPICKY_ENABLE |
| 208 |
-Walloc-zero # gcc 7.0 |
| 209 |
-Wduplicated-branches # gcc 7.0 |
| 210 |
-Wformat-overflow=2 # gcc 7.0 |
| 211 |
-Wformat-truncation=2 # gcc 7.0 |
| 212 |
-Wimplicit-fallthrough # clang 4.0 gcc 7.0 |
| 213 |
-Wrestrict # gcc 7.0 |
| 214 |
) |
| 215 |
endif() |
| 216 |
if(NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 10.0) |
| 217 |
list(APPEND WPICKY_ENABLE |
| 218 |
-Warith-conversion # gcc 10.0 |
| 219 |
) |
| 220 |
endif() |
| 221 |
endif() |
| 222 |
|
| 223 |
# |
| 224 |
|
| 225 |
unset(WPICKY) |
| 226 |
|
| 227 |
foreach(_CCOPT IN LISTS WPICKY_ENABLE) |
| 228 |
set(WPICKY "${WPICKY} ${_CCOPT}") |
| 229 |
endforeach() |
| 230 |
|
| 231 |
foreach(_CCOPT IN LISTS WPICKY_DETECT) |
| 232 |
# surprisingly, CHECK_C_COMPILER_FLAG needs a new variable to store each new |
| 233 |
# test result in. |
| 234 |
string(MAKE_C_IDENTIFIER "OPT${_CCOPT}" _optvarname) |
| 235 |
# GCC only warns about unknown -Wno- options if there are also other diagnostic messages, |
| 236 |
# so test for the positive form instead |
| 237 |
string(REPLACE "-Wno-" "-W" _CCOPT_ON "${_CCOPT}") |
| 238 |
check_c_compiler_flag(${_CCOPT_ON} ${_optvarname}) |
| 239 |
if(${_optvarname}) |
| 240 |
set(WPICKY "${WPICKY} ${_CCOPT}") |
| 241 |
endif() |
| 242 |
endforeach() |
| 243 |
|
| 244 |
message(STATUS "Picky compiler options:${WPICKY}") |
| 245 |
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${WPICKY}") |
| 246 |
endif() |
| 247 |
endif() |