| 1 |
/* |
| 2 |
SPDX-FileCopyrightText: 2016-2017 Sergio Martins <[email protected]> |
| 3 |
|
| 4 |
SPDX-License-Identifier: LGPL-2.0-or-later |
| 5 |
*/ |
| 6 |
|
| 7 |
#include "returning-data-from-temporary.h" |
| 8 |
#include "HierarchyUtils.h" |
| 9 |
#include "TypeUtils.h" |
| 10 |
|
| 11 |
#include <clang/AST/Decl.h> |
| 12 |
#include <clang/AST/DeclCXX.h> |
| 13 |
#include <clang/AST/Expr.h> |
| 14 |
#include <clang/AST/ExprCXX.h> |
| 15 |
#include <clang/AST/Stmt.h> |
| 16 |
#include <clang/AST/Type.h> |
| 17 |
#include <clang/Basic/LLVM.h> |
| 18 |
#include <llvm/Support/Casting.h> |
| 19 |
|
| 20 |
using namespace clang; |
| 21 |
|
| 22 |
void ReturningDataFromTemporary::VisitStmt(clang::Stmt *stmt) |
| 23 |
{ |
| 24 |
if (handleReturn(dyn_cast<ReturnStmt>(stmt))) { |
| 25 |
return; |
| 26 |
} |
| 27 |
|
| 28 |
handleDeclStmt(dyn_cast<DeclStmt>(stmt)); |
| 29 |
} |
| 30 |
|
| 31 |
bool ReturningDataFromTemporary::handleReturn(ReturnStmt *ret) |
| 32 |
{ |
| 33 |
if (!ret) { |
| 34 |
return false; |
| 35 |
} |
| 36 |
|
| 37 |
auto *memberCall = clazy::unpeal<CXXMemberCallExpr>(clazy::getFirstChild(ret), clazy::IgnoreExprWithCleanups | clazy::IgnoreImplicitCasts); |
| 38 |
handleMemberCall(memberCall, false); |
| 39 |
return true; |
| 40 |
} |
| 41 |
|
| 42 |
void ReturningDataFromTemporary::handleDeclStmt(DeclStmt *declStmt) |
| 43 |
{ |
| 44 |
if (!declStmt) { |
| 45 |
return; |
| 46 |
} |
| 47 |
|
| 48 |
for (auto *decl : declStmt->decls()) { |
| 49 |
auto *varDecl = dyn_cast<VarDecl>(decl); |
| 50 |
if (!varDecl) { |
| 51 |
continue; |
| 52 |
} |
| 53 |
|
| 54 |
if (varDecl->getType().getAsString() != "const char *") { |
| 55 |
continue; |
| 56 |
} |
| 57 |
|
| 58 |
Expr *init = varDecl->getInit(); |
| 59 |
if (!init) { |
| 60 |
continue; |
| 61 |
} |
| 62 |
|
| 63 |
auto *memberCall = clazy::unpeal<CXXMemberCallExpr>(clazy::getFirstChild(init), clazy::IgnoreExprWithCleanups | clazy::IgnoreImplicitCasts); |
| 64 |
|
| 65 |
handleMemberCall(memberCall, true); |
| 66 |
} |
| 67 |
} |
| 68 |
|
| 69 |
void ReturningDataFromTemporary::handleMemberCall(CXXMemberCallExpr *memberCall, bool onlyTemporaries) |
| 70 |
{ |
| 71 |
if (!memberCall) { |
| 72 |
return; |
| 73 |
} |
| 74 |
|
| 75 |
CXXMethodDecl *method = memberCall->getMethodDecl(); |
| 76 |
if (!method) { |
| 77 |
return; |
| 78 |
} |
| 79 |
const std::string methodName = trimQtNamespace(method->getQualifiedNameAsString()); |
| 80 |
|
| 81 |
if (methodName != "QByteArray::data" && methodName != "QByteArray::operator const char *" && methodName != "QByteArray::constData") { |
| 82 |
return; |
| 83 |
} |
| 84 |
|
| 85 |
Expr *obj = memberCall->getImplicitObjectArgument(); |
| 86 |
Stmt *t = obj; |
| 87 |
DeclRefExpr *declRef = nullptr; |
| 88 |
CXXBindTemporaryExpr *temporaryExpr = nullptr; |
| 89 |
|
| 90 |
while (t) { |
| 91 |
if (dyn_cast<ImplicitCastExpr>(t) || dyn_cast<MaterializeTemporaryExpr>(t) || dyn_cast<CXXFunctionalCastExpr>(t)) { |
| 92 |
t = clazy::getFirstChild(t); |
| 93 |
continue; |
| 94 |
} |
| 95 |
|
| 96 |
if (!onlyTemporaries) { |
| 97 |
declRef = dyn_cast<DeclRefExpr>(t); |
| 98 |
if (declRef) { |
| 99 |
break; |
| 100 |
} |
| 101 |
} |
| 102 |
|
| 103 |
temporaryExpr = dyn_cast<CXXBindTemporaryExpr>(t); |
| 104 |
if (temporaryExpr) { |
| 105 |
break; |
| 106 |
} |
| 107 |
|
| 108 |
break; |
| 109 |
} |
| 110 |
|
| 111 |
if (!temporaryExpr && !declRef) { |
| 112 |
return; |
| 113 |
} |
| 114 |
|
| 115 |
if (declRef) { |
| 116 |
auto *varDecl = dyn_cast<VarDecl>(declRef->getDecl()); |
| 117 |
if (!varDecl || varDecl->isStaticLocal() || clazy::valueIsConst(varDecl->getType())) { |
| 118 |
return; |
| 119 |
} |
| 120 |
|
| 121 |
QualType qt = varDecl->getType(); |
| 122 |
if (qt.isNull() || qt->isReferenceType()) { |
| 123 |
return; |
| 124 |
} |
| 125 |
} else if (temporaryExpr) { |
| 126 |
if (clazy::valueIsConst(temporaryExpr->getType())) { |
| 127 |
return; |
| 128 |
} |
| 129 |
} |
| 130 |
|
| 131 |
emitWarning(memberCall, "Returning data of temporary QByteArray"); |
| 132 |
} |