/* SPDX-FileCopyrightText: 2016-2017 Sergio Martins SPDX-License-Identifier: LGPL-2.0-or-later */ #include "returning-data-from-temporary.h" #include "HierarchyUtils.h" #include "TypeUtils.h" #include #include #include #include #include #include #include #include using namespace clang; void ReturningDataFromTemporary::VisitStmt(clang::Stmt *stmt) { if (handleReturn(dyn_cast(stmt))) { return; } handleDeclStmt(dyn_cast(stmt)); } bool ReturningDataFromTemporary::handleReturn(ReturnStmt *ret) { if (!ret) { return false; } auto *memberCall = clazy::unpeal(clazy::getFirstChild(ret), clazy::IgnoreExprWithCleanups | clazy::IgnoreImplicitCasts); handleMemberCall(memberCall, false); return true; } void ReturningDataFromTemporary::handleDeclStmt(DeclStmt *declStmt) { if (!declStmt) { return; } for (auto *decl : declStmt->decls()) { auto *varDecl = dyn_cast(decl); if (!varDecl) { continue; } if (varDecl->getType().getAsString() != "const char *") { continue; } Expr *init = varDecl->getInit(); if (!init) { continue; } auto *memberCall = clazy::unpeal(clazy::getFirstChild(init), clazy::IgnoreExprWithCleanups | clazy::IgnoreImplicitCasts); handleMemberCall(memberCall, true); } } void ReturningDataFromTemporary::handleMemberCall(CXXMemberCallExpr *memberCall, bool onlyTemporaries) { if (!memberCall) { return; } CXXMethodDecl *method = memberCall->getMethodDecl(); if (!method) { return; } const std::string methodName = trimQtNamespace(method->getQualifiedNameAsString()); if (methodName != "QByteArray::data" && methodName != "QByteArray::operator const char *" && methodName != "QByteArray::constData") { return; } Expr *obj = memberCall->getImplicitObjectArgument(); Stmt *t = obj; DeclRefExpr *declRef = nullptr; CXXBindTemporaryExpr *temporaryExpr = nullptr; while (t) { if (dyn_cast(t) || dyn_cast(t) || dyn_cast(t)) { t = clazy::getFirstChild(t); continue; } if (!onlyTemporaries) { declRef = dyn_cast(t); if (declRef) { break; } } temporaryExpr = dyn_cast(t); if (temporaryExpr) { break; } break; } if (!temporaryExpr && !declRef) { return; } if (declRef) { auto *varDecl = dyn_cast(declRef->getDecl()); if (!varDecl || varDecl->isStaticLocal() || clazy::valueIsConst(varDecl->getType())) { return; } QualType qt = varDecl->getType(); if (qt.isNull() || qt->isReferenceType()) { return; } } else if (temporaryExpr) { if (clazy::valueIsConst(temporaryExpr->getType())) { return; } } emitWarning(memberCall, "Returning data of temporary QByteArray"); }