Debian Codegraph @

source4/torture/smb2/acls.c

raw
1 /*
2 Unix SMB/CIFS implementation.
3
4 test security descriptor operations for SMB2
5
6 Copyright (C) Zack Kirsch 2009
7
8 This program is free software; you can redistribute it and/or modify
9 it under the terms of the GNU General Public License as published by
10 the Free Software Foundation; either version 3 of the License, or
11 (at your option) any later version.
12
13 This program is distributed in the hope that it will be useful,
14 but WITHOUT ANY WARRANTY; without even the implied warranty of
15 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 GNU General Public License for more details.
17
18 You should have received a copy of the GNU General Public License
19 along with this program. If not, see <http://www.gnu.org/licenses/>.
20 */
21
22 #include "includes.h"
23 #include "lib/cmdline/cmdline.h"
24 #include "libcli/smb2/smb2.h"
25 #include "libcli/smb2/smb2_calls.h"
26 #include "libcli/smb/smbXcli_base.h"
27 #include "torture/torture.h"
28 #include "libcli/resolve/resolve.h"
29 #include "torture/util.h"
30 #include "torture/smb2/proto.h"
31 #include "libcli/security/security.h"
32 #include "librpc/gen_ndr/ndr_security.h"
33 #include "lib/param/param.h"
34
35 #define CHECK_STATUS(status, correct) do { \
36 if (!NT_STATUS_EQUAL(status, correct)) { \
37 torture_result(tctx, TORTURE_FAIL, "(%s) Incorrect status %s - should be %s\n", \
38 __location__, nt_errstr(status), nt_errstr(correct)); \
39 ret = false; \
40 goto done; \
41 }} while (0)
42
43 #define BASEDIR "smb2-testsd"
44
45 #define CHECK_ACCESS_IGNORE SEC_STD_SYNCHRONIZE
46
47 #define CHECK_ACCESS_FLAGS(_fh, flags) do { \
48 union smb_fileinfo _q; \
49 _q.access_information.level = RAW_FILEINFO_ACCESS_INFORMATION; \
50 _q.access_information.in.file.handle = (_fh); \
51 status = smb2_getinfo_file(tree, tctx, &_q); \
52 CHECK_STATUS(status, NT_STATUS_OK); \
53 /* Handle a Vista bug where SEC_STD_SYNCHRONIZE doesn't come back. */ \
54 if ((((flags) & CHECK_ACCESS_IGNORE) == CHECK_ACCESS_IGNORE) && \
55 ((_q.access_information.out.access_flags & CHECK_ACCESS_IGNORE) != CHECK_ACCESS_IGNORE)) { \
56 torture_comment(tctx, "SKIPPING (Vista bug): (%s) Incorrect access_flags 0x%08x - should be 0x%08x\n", \
57 __location__, _q.access_information.out.access_flags, (flags)); \
58 } \
59 if ((_q.access_information.out.access_flags & ~CHECK_ACCESS_IGNORE) != \
60 (((flags) & ~CHECK_ACCESS_IGNORE))) { \
61 torture_result(tctx, TORTURE_FAIL, "(%s) Incorrect access_flags 0x%08x - should be 0x%08x\n", \
62 __location__, _q.access_information.out.access_flags, (flags)); \
63 ret = false; \
64 goto done; \
65 } \
66 } while (0)
67
68 #define FAIL_UNLESS(__cond) \
69 do { \
70 if (__cond) {} else { \
71 torture_result(tctx, TORTURE_FAIL, "%s) condition violated: %s\n", \
72 __location__, #__cond); \
73 ret = false; goto done; \
74 } \
75 } while(0)
76
77 #define CHECK_SECURITY_DESCRIPTOR(_sd1, _sd2) do { \
78 if (!security_descriptor_equal(_sd1, _sd2)) { \
79 torture_warning(tctx, "security descriptors don't match!\n"); \
80 torture_warning(tctx, "got:\n"); \
81 NDR_PRINT_DEBUG(security_descriptor, _sd1); \
82 torture_warning(tctx, "expected:\n"); \
83 NDR_PRINT_DEBUG(security_descriptor, _sd2); \
84 torture_result(tctx, TORTURE_FAIL, \
85 "%s: security descriptors don't match!\n", \
86 __location__); \
87 ret = false; \
88 } \
89 } while (0)
90
91 /*
92 * Helper function to restore original sd.
93 */
94 static NTSTATUS restore_sd_orig(struct smb2_tree *tree,
95 union smb_setfileinfo *si,
96 struct smb2_handle handle,
97 struct security_descriptor *sd)
98 {
99 if (tree == NULL || smb2_util_handle_empty(handle) || sd == NULL) {
100 return NT_STATUS_OK;
101 }
102
103 si->set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
104 si->set_secdesc.in.file.handle = handle;
105 si->set_secdesc.in.secinfo_flags = SECINFO_DACL;
106 si->set_secdesc.in.sd = sd;
107
108 return smb2_setinfo_file(tree, si);
109 }
110
111 /*
112 test the behaviour of the well known SID_CREATOR_OWNER sid, and some generic
113 mapping bits
114 Note: This test was copied from raw/acls.c.
115 */
116 static bool test_creator_sid(struct torture_context *tctx, struct smb2_tree *tree)
117 {
118 NTSTATUS status;
119 struct smb2_create io;
120 const char *fname = BASEDIR "\\creator.txt";
121 bool ret = true;
122 struct smb2_handle handle = {{0}};
123 union smb_fileinfo q;
124 union smb_setfileinfo set;
125 struct security_descriptor *sd, *sd_orig = NULL, *sd2;
126 const char *owner_sid;
127
128 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
129 return false;
130
131 torture_comment(tctx, "TESTING SID_CREATOR_OWNER\n");
132
133 ZERO_STRUCT(io);
134 io.level = RAW_OPEN_SMB2;
135 io.in.create_flags = 0;
136 io.in.desired_access = SEC_STD_READ_CONTROL | SEC_STD_WRITE_DAC | SEC_STD_WRITE_OWNER;
137 io.in.create_options = 0;
138 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
139 io.in.share_access = NTCREATEX_SHARE_ACCESS_DELETE |
140 NTCREATEX_SHARE_ACCESS_READ |
141 NTCREATEX_SHARE_ACCESS_WRITE;
142 io.in.alloc_size = 0;
143 io.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
144 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
145 io.in.security_flags = 0;
146 io.in.fname = fname;
147
148 status = smb2_create(tree, tctx, &io);
149 CHECK_STATUS(status, NT_STATUS_OK);
150 handle = io.out.file.handle;
151
152 torture_comment(tctx, "get the original sd\n");
153 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
154 q.query_secdesc.in.file.handle = handle;
155 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
156 status = smb2_getinfo_file(tree, tctx, &q);
157 CHECK_STATUS(status, NT_STATUS_OK);
158 sd_orig = q.query_secdesc.out.sd;
159
160 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
161
162 torture_comment(tctx, "set a sec desc allowing no write by CREATOR_OWNER\n");
163 sd = security_descriptor_dacl_create(tctx,
164 0, NULL, NULL,
165 SID_CREATOR_OWNER,
166 SEC_ACE_TYPE_ACCESS_ALLOWED,
167 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
168 0,
169 NULL);
170
171 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
172 set.set_secdesc.in.file.handle = handle;
173 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
174 set.set_secdesc.in.sd = sd;
175
176 status = smb2_setinfo_file(tree, &set);
177 CHECK_STATUS(status, NT_STATUS_OK);
178
179 torture_comment(tctx, "try open for write\n");
180 io.in.desired_access = SEC_FILE_WRITE_DATA;
181 status = smb2_create(tree, tctx, &io);
182 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
183
184 torture_comment(tctx, "try open for read\n");
185 io.in.desired_access = SEC_FILE_READ_DATA;
186 status = smb2_create(tree, tctx, &io);
187 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
188
189 torture_comment(tctx, "try open for generic write\n");
190 io.in.desired_access = SEC_GENERIC_WRITE;
191 status = smb2_create(tree, tctx, &io);
192 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
193
194 torture_comment(tctx, "try open for generic read\n");
195 io.in.desired_access = SEC_GENERIC_READ;
196 status = smb2_create(tree, tctx, &io);
197 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
198
199 torture_comment(tctx, "set a sec desc allowing no write by owner\n");
200 sd = security_descriptor_dacl_create(tctx,
201 0, owner_sid, NULL,
202 owner_sid,
203 SEC_ACE_TYPE_ACCESS_ALLOWED,
204 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
205 0,
206 NULL);
207
208 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
209 set.set_secdesc.in.file.handle = handle;
210 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
211 set.set_secdesc.in.sd = sd;
212 status = smb2_setinfo_file(tree, &set);
213 CHECK_STATUS(status, NT_STATUS_OK);
214
215 torture_comment(tctx, "check that sd has been mapped correctly\n");
216 status = smb2_getinfo_file(tree, tctx, &q);
217 CHECK_STATUS(status, NT_STATUS_OK);
218 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
219
220 torture_comment(tctx, "try open for write\n");
221 io.in.desired_access = SEC_FILE_WRITE_DATA;
222 status = smb2_create(tree, tctx, &io);
223 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
224
225 torture_comment(tctx, "try open for read\n");
226 io.in.desired_access = SEC_FILE_READ_DATA;
227 status = smb2_create(tree, tctx, &io);
228 CHECK_STATUS(status, NT_STATUS_OK);
229 CHECK_ACCESS_FLAGS(io.out.file.handle,
230 SEC_FILE_READ_DATA);
231 smb2_util_close(tree, io.out.file.handle);
232
233 torture_comment(tctx, "try open for generic write\n");
234 io.in.desired_access = SEC_GENERIC_WRITE;
235 status = smb2_create(tree, tctx, &io);
236 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
237
238 torture_comment(tctx, "try open for generic read\n");
239 io.in.desired_access = SEC_GENERIC_READ;
240 status = smb2_create(tree, tctx, &io);
241 CHECK_STATUS(status, NT_STATUS_OK);
242 CHECK_ACCESS_FLAGS(io.out.file.handle,
243 SEC_RIGHTS_FILE_READ);
244 smb2_util_close(tree, io.out.file.handle);
245
246 torture_comment(tctx, "set a sec desc allowing generic read by owner\n");
247 sd = security_descriptor_dacl_create(tctx,
248 0, NULL, NULL,
249 owner_sid,
250 SEC_ACE_TYPE_ACCESS_ALLOWED,
251 SEC_GENERIC_READ | SEC_STD_ALL,
252 0,
253 NULL);
254
255 set.set_secdesc.in.sd = sd;
256 status = smb2_setinfo_file(tree, &set);
257 CHECK_STATUS(status, NT_STATUS_OK);
258
259 torture_comment(tctx, "check that generic read has been mapped correctly\n");
260 sd2 = security_descriptor_dacl_create(tctx,
261 0, owner_sid, NULL,
262 owner_sid,
263 SEC_ACE_TYPE_ACCESS_ALLOWED,
264 SEC_RIGHTS_FILE_READ | SEC_STD_ALL,
265 0,
266 NULL);
267
268 status = smb2_getinfo_file(tree, tctx, &q);
269 CHECK_STATUS(status, NT_STATUS_OK);
270 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
271
272 torture_comment(tctx, "try open for write\n");
273 io.in.desired_access = SEC_FILE_WRITE_DATA;
274 status = smb2_create(tree, tctx, &io);
275 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
276
277 torture_comment(tctx, "try open for read\n");
278 io.in.desired_access = SEC_FILE_READ_DATA;
279 status = smb2_create(tree, tctx, &io);
280 CHECK_STATUS(status, NT_STATUS_OK);
281 CHECK_ACCESS_FLAGS(io.out.file.handle,
282 SEC_FILE_READ_DATA);
283 smb2_util_close(tree, io.out.file.handle);
284
285 torture_comment(tctx, "try open for generic write\n");
286 io.in.desired_access = SEC_GENERIC_WRITE;
287 status = smb2_create(tree, tctx, &io);
288 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
289
290 torture_comment(tctx, "try open for generic read\n");
291 io.in.desired_access = SEC_GENERIC_READ;
292 status = smb2_create(tree, tctx, &io);
293 CHECK_STATUS(status, NT_STATUS_OK);
294 CHECK_ACCESS_FLAGS(io.out.file.handle, SEC_RIGHTS_FILE_READ);
295 smb2_util_close(tree, io.out.file.handle);
296
297 done:
298 torture_comment(tctx, "put back original sd\n");
299 restore_sd_orig(tree, &set, handle, sd_orig);
300 if (!smb2_util_handle_empty(handle)) {
301 smb2_util_close(tree, handle);
302 }
303 smb2_deltree(tree, BASEDIR);
304 smb2_tdis(tree);
305 smb2_logoff(tree->session);
306 return ret;
307 }
308
309
310 /*
311 test the mapping of the SEC_GENERIC_xx bits to SEC_STD_xx and
312 SEC_FILE_xx bits
313 Note: This test was copied from raw/acls.c.
314 */
315 static bool test_generic_bits(struct torture_context *tctx, struct smb2_tree *tree)
316 {
317 NTSTATUS status;
318 struct smb2_create io;
319 const char *fname = BASEDIR "\\generic.txt";
320 bool ret = true;
321 struct smb2_handle handle = {{0}};
322 int i;
323 union smb_fileinfo q;
324 union smb_setfileinfo set;
325 struct security_descriptor *sd, *sd_orig = NULL, *sd2;
326 const char *owner_sid;
327 const struct {
328 uint32_t gen_bits;
329 uint32_t specific_bits;
330 } file_mappings[] = {
331 { 0, 0 },
332 { SEC_GENERIC_READ, SEC_RIGHTS_FILE_READ },
333 { SEC_GENERIC_WRITE, SEC_RIGHTS_FILE_WRITE },
334 { SEC_GENERIC_EXECUTE, SEC_RIGHTS_FILE_EXECUTE },
335 { SEC_GENERIC_ALL, SEC_RIGHTS_FILE_ALL },
336 { SEC_FILE_READ_DATA, SEC_FILE_READ_DATA },
337 { SEC_FILE_READ_ATTRIBUTE, SEC_FILE_READ_ATTRIBUTE }
338 };
339 const struct {
340 uint32_t gen_bits;
341 uint32_t specific_bits;
342 } dir_mappings[] = {
343 { 0, 0 },
344 { SEC_GENERIC_READ, SEC_RIGHTS_DIR_READ },
345 { SEC_GENERIC_WRITE, SEC_RIGHTS_DIR_WRITE },
346 { SEC_GENERIC_EXECUTE, SEC_RIGHTS_DIR_EXECUTE },
347 { SEC_GENERIC_ALL, SEC_RIGHTS_DIR_ALL }
348 };
349 bool has_restore_privilege = false;
350 bool has_take_ownership_privilege = false;
351
352 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
353 return false;
354
355 torture_comment(tctx, "TESTING FILE GENERIC BITS\n");
356
357 ZERO_STRUCT(io);
358 io.level = RAW_OPEN_SMB2;
359 io.in.create_flags = 0;
360 io.in.desired_access =
361 SEC_STD_READ_CONTROL |
362 SEC_STD_WRITE_DAC |
363 SEC_STD_WRITE_OWNER;
364 io.in.create_options = 0;
365 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
366 io.in.share_access =
367 NTCREATEX_SHARE_ACCESS_READ |
368 NTCREATEX_SHARE_ACCESS_WRITE;
369 io.in.alloc_size = 0;
370 io.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
371 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
372 io.in.security_flags = 0;
373 io.in.fname = fname;
374 status = smb2_create(tree, tctx, &io);
375 CHECK_STATUS(status, NT_STATUS_OK);
376 handle = io.out.file.handle;
377
378 torture_comment(tctx, "get the original sd\n");
379 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
380 q.query_secdesc.in.file.handle = handle;
381 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
382 status = smb2_getinfo_file(tree, tctx, &q);
383 CHECK_STATUS(status, NT_STATUS_OK);
384 sd_orig = q.query_secdesc.out.sd;
385
386 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
387
388 /*
389 * XXX: The smblsa calls use SMB as their transport - need to get rid of
390 * dependency.
391 */
392 /*
393 status = smblsa_sid_check_privilege(cli,
394 owner_sid,
395 sec_privilege_name(SEC_PRIV_RESTORE));
396 has_restore_privilege = NT_STATUS_IS_OK(status);
397 if (!NT_STATUS_IS_OK(status)) {
398 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
399 }
400 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
401
402 status = smblsa_sid_check_privilege(cli,
403 owner_sid,
404 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
405 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
406 if (!NT_STATUS_IS_OK(status)) {
407 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
408 }
409 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
410 */
411
412 for (i=0;i<ARRAY_SIZE(file_mappings);i++) {
413 uint32_t expected_mask =
414 SEC_STD_WRITE_DAC |
415 SEC_STD_READ_CONTROL |
416 SEC_FILE_READ_ATTRIBUTE |
417 SEC_STD_DELETE;
418 uint32_t expected_mask_anon = SEC_FILE_READ_ATTRIBUTE;
419
420 if (has_restore_privilege) {
421 expected_mask_anon |= SEC_STD_DELETE;
422 }
423
424 torture_comment(tctx, "Testing generic bits 0x%08x\n",
425 file_mappings[i].gen_bits);
426 sd = security_descriptor_dacl_create(tctx,
427 0, owner_sid, NULL,
428 owner_sid,
429 SEC_ACE_TYPE_ACCESS_ALLOWED,
430 file_mappings[i].gen_bits,
431 0,
432 NULL);
433
434 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
435 set.set_secdesc.in.file.handle = handle;
436 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
437 set.set_secdesc.in.sd = sd;
438
439 status = smb2_setinfo_file(tree, &set);
440 CHECK_STATUS(status, NT_STATUS_OK);
441
442 sd2 = security_descriptor_dacl_create(tctx,
443 0, owner_sid, NULL,
444 owner_sid,
445 SEC_ACE_TYPE_ACCESS_ALLOWED,
446 file_mappings[i].specific_bits,
447 0,
448 NULL);
449
450 status = smb2_getinfo_file(tree, tctx, &q);
451 CHECK_STATUS(status, NT_STATUS_OK);
452 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
453
454 io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
455 status = smb2_create(tree, tctx, &io);
456 CHECK_STATUS(status, NT_STATUS_OK);
457 CHECK_ACCESS_FLAGS(io.out.file.handle,
458 expected_mask | file_mappings[i].specific_bits);
459 smb2_util_close(tree, io.out.file.handle);
460
461 if (!has_take_ownership_privilege) {
462 continue;
463 }
464
465 torture_comment(tctx, "Testing generic bits 0x%08x (anonymous)\n",
466 file_mappings[i].gen_bits);
467 sd = security_descriptor_dacl_create(tctx,
468 0, SID_NT_ANONYMOUS, NULL,
469 owner_sid,
470 SEC_ACE_TYPE_ACCESS_ALLOWED,
471 file_mappings[i].gen_bits,
472 0,
473 NULL);
474
475 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
476 set.set_secdesc.in.file.handle = handle;
477 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
478 set.set_secdesc.in.sd = sd;
479
480 status = smb2_setinfo_file(tree, &set);
481 CHECK_STATUS(status, NT_STATUS_OK);
482
483 sd2 = security_descriptor_dacl_create(tctx,
484 0, SID_NT_ANONYMOUS, NULL,
485 owner_sid,
486 SEC_ACE_TYPE_ACCESS_ALLOWED,
487 file_mappings[i].specific_bits,
488 0,
489 NULL);
490
491 status = smb2_getinfo_file(tree, tctx, &q);
492 CHECK_STATUS(status, NT_STATUS_OK);
493 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
494
495 io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
496 status = smb2_create(tree, tctx, &io);
497 CHECK_STATUS(status, NT_STATUS_OK);
498 CHECK_ACCESS_FLAGS(io.out.file.handle,
499 expected_mask_anon | file_mappings[i].specific_bits);
500 smb2_util_close(tree, io.out.file.handle);
501 }
502
503 torture_comment(tctx, "put back original sd\n");
504 set.set_secdesc.in.sd = sd_orig;
505 status = smb2_setinfo_file(tree, &set);
506 CHECK_STATUS(status, NT_STATUS_OK);
507
508 smb2_util_close(tree, handle);
509 smb2_util_unlink(tree, fname);
510
511
512 torture_comment(tctx, "TESTING DIR GENERIC BITS\n");
513
514 ZERO_STRUCT(io);
515 io.level = RAW_OPEN_SMB2;
516 io.in.create_flags = 0;
517 io.in.desired_access =
518 SEC_STD_READ_CONTROL |
519 SEC_STD_WRITE_DAC |
520 SEC_STD_WRITE_OWNER;
521 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
522 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
523 io.in.share_access =
524 NTCREATEX_SHARE_ACCESS_READ |
525 NTCREATEX_SHARE_ACCESS_WRITE;
526 io.in.alloc_size = 0;
527 io.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
528 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
529 io.in.security_flags = 0;
530 io.in.fname = fname;
531 status = smb2_create(tree, tctx, &io);
532 CHECK_STATUS(status, NT_STATUS_OK);
533 handle = io.out.file.handle;
534
535 torture_comment(tctx, "get the original sd\n");
536 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
537 q.query_secdesc.in.file.handle = handle;
538 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
539 status = smb2_getinfo_file(tree, tctx, &q);
540 CHECK_STATUS(status, NT_STATUS_OK);
541 sd_orig = q.query_secdesc.out.sd;
542
543 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
544
545 /*
546 * XXX: The smblsa calls use SMB as their transport - need to get rid of
547 * dependency.
548 */
549 /*
550 status = smblsa_sid_check_privilege(cli,
551 owner_sid,
552 sec_privilege_name(SEC_PRIV_RESTORE));
553 has_restore_privilege = NT_STATUS_IS_OK(status);
554 if (!NT_STATUS_IS_OK(status)) {
555 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
556 }
557 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
558
559 status = smblsa_sid_check_privilege(cli,
560 owner_sid,
561 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
562 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
563 if (!NT_STATUS_IS_OK(status)) {
564 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
565 }
566 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
567
568 */
569 for (i=0;i<ARRAY_SIZE(dir_mappings);i++) {
570 uint32_t expected_mask =
571 SEC_STD_WRITE_DAC |
572 SEC_STD_READ_CONTROL |
573 SEC_FILE_READ_ATTRIBUTE |
574 SEC_STD_DELETE;
575 uint32_t expected_mask_anon = SEC_FILE_READ_ATTRIBUTE;
576
577 if (has_restore_privilege) {
578 expected_mask_anon |= SEC_STD_DELETE;
579 }
580
581 torture_comment(tctx, "Testing generic bits 0x%08x\n",
582 file_mappings[i].gen_bits);
583 sd = security_descriptor_dacl_create(tctx,
584 0, owner_sid, NULL,
585 owner_sid,
586 SEC_ACE_TYPE_ACCESS_ALLOWED,
587 dir_mappings[i].gen_bits,
588 0,
589 NULL);
590
591 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
592 set.set_secdesc.in.file.handle = handle;
593 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
594 set.set_secdesc.in.sd = sd;
595
596 status = smb2_setinfo_file(tree, &set);
597 CHECK_STATUS(status, NT_STATUS_OK);
598
599 sd2 = security_descriptor_dacl_create(tctx,
600 0, owner_sid, NULL,
601 owner_sid,
602 SEC_ACE_TYPE_ACCESS_ALLOWED,
603 dir_mappings[i].specific_bits,
604 0,
605 NULL);
606
607 status = smb2_getinfo_file(tree, tctx, &q);
608 CHECK_STATUS(status, NT_STATUS_OK);
609 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
610
611 io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
612 status = smb2_create(tree, tctx, &io);
613 CHECK_STATUS(status, NT_STATUS_OK);
614 CHECK_ACCESS_FLAGS(io.out.file.handle,
615 expected_mask | dir_mappings[i].specific_bits);
616 smb2_util_close(tree, io.out.file.handle);
617
618 if (!has_take_ownership_privilege) {
619 continue;
620 }
621
622 torture_comment(tctx, "Testing generic bits 0x%08x (anonymous)\n",
623 file_mappings[i].gen_bits);
624 sd = security_descriptor_dacl_create(tctx,
625 0, SID_NT_ANONYMOUS, NULL,
626 owner_sid,
627 SEC_ACE_TYPE_ACCESS_ALLOWED,
628 file_mappings[i].gen_bits,
629 0,
630 NULL);
631
632 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
633 set.set_secdesc.in.file.handle = handle;
634 set.set_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
635 set.set_secdesc.in.sd = sd;
636
637 status = smb2_setinfo_file(tree, &set);
638 CHECK_STATUS(status, NT_STATUS_OK);
639
640 sd2 = security_descriptor_dacl_create(tctx,
641 0, SID_NT_ANONYMOUS, NULL,
642 owner_sid,
643 SEC_ACE_TYPE_ACCESS_ALLOWED,
644 file_mappings[i].specific_bits,
645 0,
646 NULL);
647
648 status = smb2_getinfo_file(tree, tctx, &q);
649 CHECK_STATUS(status, NT_STATUS_OK);
650 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
651
652 io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
653 status = smb2_create(tree, tctx, &io);
654 CHECK_STATUS(status, NT_STATUS_OK);
655 CHECK_ACCESS_FLAGS(io.out.file.handle,
656 expected_mask_anon | dir_mappings[i].specific_bits);
657 smb2_util_close(tree, io.out.file.handle);
658 }
659
660 done:
661 torture_comment(tctx, "put back original sd\n");
662 restore_sd_orig(tree, &set, handle, sd_orig);
663 if (!smb2_util_handle_empty(handle)) {
664 smb2_util_close(tree, handle);
665 }
666 smb2_util_unlink(tree, fname);
667 smb2_deltree(tree, BASEDIR);
668 smb2_tdis(tree);
669 smb2_logoff(tree->session);
670 return ret;
671 }
672
673
674 /*
675 see what access bits the owner of a file always gets
676 Note: This test was copied from raw/acls.c.
677 */
678 static bool test_owner_bits(struct torture_context *tctx, struct smb2_tree *tree)
679 {
680 NTSTATUS status;
681 struct smb2_create io;
682 const char *fname = BASEDIR "\\test_owner_bits.txt";
683 bool ret = true;
684 struct smb2_handle handle = {{0}};
685 int i;
686 union smb_fileinfo q;
687 union smb_setfileinfo set;
688 struct security_descriptor *sd, *sd_orig = NULL;
689 const char *owner_sid;
690 uint32_t expected_bits;
691
692 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
693 return false;
694
695 torture_comment(tctx, "TESTING FILE OWNER BITS\n");
696
697 ZERO_STRUCT(io);
698 io.level = RAW_OPEN_SMB2;
699 io.in.create_flags = 0;
700 io.in.desired_access =
701 SEC_STD_READ_CONTROL |
702 SEC_STD_WRITE_DAC |
703 SEC_STD_WRITE_OWNER;
704 io.in.create_options = 0;
705 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
706 io.in.share_access =
707 NTCREATEX_SHARE_ACCESS_READ |
708 NTCREATEX_SHARE_ACCESS_WRITE;
709 io.in.alloc_size = 0;
710 io.in.create_disposition = NTCREATEX_DISP_OPEN_IF;
711 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
712 io.in.security_flags = 0;
713 io.in.fname = fname;
714 status = smb2_create(tree, tctx, &io);
715 CHECK_STATUS(status, NT_STATUS_OK);
716 handle = io.out.file.handle;
717
718 torture_comment(tctx, "get the original sd\n");
719 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
720 q.query_secdesc.in.file.handle = handle;
721 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
722 status = smb2_getinfo_file(tree, tctx, &q);
723 CHECK_STATUS(status, NT_STATUS_OK);
724 sd_orig = q.query_secdesc.out.sd;
725
726 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
727
728 /*
729 * XXX: The smblsa calls use SMB as their transport - need to get rid of
730 * dependency.
731 */
732 /*
733 status = smblsa_sid_check_privilege(cli,
734 owner_sid,
735 sec_privilege_name(SEC_PRIV_RESTORE));
736 has_restore_privilege = NT_STATUS_IS_OK(status);
737 if (!NT_STATUS_IS_OK(status)) {
738 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
739 }
740 torture_comment(tctx, "SEC_PRIV_RESTORE - %s\n", has_restore_privilege?"Yes":"No");
741
742 status = smblsa_sid_check_privilege(cli,
743 owner_sid,
744 sec_privilege_name(SEC_PRIV_TAKE_OWNERSHIP));
745 has_take_ownership_privilege = NT_STATUS_IS_OK(status);
746 if (!NT_STATUS_IS_OK(status)) {
747 torture_warning(tctx, "smblsa_sid_check_privilege - %s\n", nt_errstr(status));
748 }
749 torture_comment(tctx, "SEC_PRIV_TAKE_OWNERSHIP - %s\n", has_take_ownership_privilege?"Yes":"No");
750 */
751
752 sd = security_descriptor_dacl_create(tctx,
753 0, NULL, NULL,
754 owner_sid,
755 SEC_ACE_TYPE_ACCESS_ALLOWED,
756 SEC_FILE_WRITE_DATA,
757 0,
758 NULL);
759
760 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
761 set.set_secdesc.in.file.handle = handle;
762 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
763 set.set_secdesc.in.sd = sd;
764
765 status = smb2_setinfo_file(tree, &set);
766 CHECK_STATUS(status, NT_STATUS_OK);
767
768 expected_bits = SEC_FILE_WRITE_DATA | SEC_FILE_READ_ATTRIBUTE;
769
770 for (i=0;i<16;i++) {
771 uint32_t bit = (1<<i);
772 io.in.desired_access = bit;
773 status = smb2_create(tree, tctx, &io);
774 if (expected_bits & bit) {
775 if (!NT_STATUS_IS_OK(status)) {
776 torture_warning(tctx, "failed with access mask 0x%08x of expected 0x%08x\n",
777 bit, expected_bits);
778 }
779 CHECK_STATUS(status, NT_STATUS_OK);
780 CHECK_ACCESS_FLAGS(io.out.file.handle, bit);
781 smb2_util_close(tree, io.out.file.handle);
782 } else {
783 if (NT_STATUS_IS_OK(status)) {
784 torture_warning(tctx, "open succeeded with access mask 0x%08x of "
785 "expected 0x%08x - should fail\n",
786 bit, expected_bits);
787 }
788 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
789 }
790 }
791
792 done:
793 torture_comment(tctx, "put back original sd\n");
794 restore_sd_orig(tree, &set, handle, sd_orig);
795 if (!smb2_util_handle_empty(handle)) {
796 smb2_util_close(tree, handle);
797 }
798 smb2_util_unlink(tree, fname);
799 smb2_deltree(tree, BASEDIR);
800 smb2_tdis(tree);
801 smb2_logoff(tree->session);
802 return ret;
803 }
804
805
806
807 /*
808 test the inheritance of ACL flags onto new files and directories
809 Note: This test was copied from raw/acls.c.
810 */
811 static bool test_inheritance(struct torture_context *tctx, struct smb2_tree *tree)
812 {
813 NTSTATUS status;
814 struct smb2_create io;
815 const char *dname = BASEDIR "\\inheritance";
816 const char *fname1 = BASEDIR "\\inheritance\\testfile";
817 const char *fname2 = BASEDIR "\\inheritance\\testdir";
818 bool ret = true;
819 struct smb2_handle handle = {{0}};
820 struct smb2_handle handle2 = {{0}};
821 int i;
822 union smb_fileinfo q;
823 union smb_setfileinfo set;
824 struct security_descriptor *sd, *sd2, *sd_orig=NULL, *sd_def1, *sd_def2;
825 const char *owner_sid;
826 const struct dom_sid *creator_owner;
827 const struct {
828 uint32_t parent_flags;
829 uint32_t file_flags;
830 uint32_t dir_flags;
831 } test_flags[] = {
832 {
833 0,
834 0,
835 0
836 },
837 {
838 SEC_ACE_FLAG_OBJECT_INHERIT,
839 0,
840 SEC_ACE_FLAG_OBJECT_INHERIT |
841 SEC_ACE_FLAG_INHERIT_ONLY,
842 },
843 {
844 SEC_ACE_FLAG_CONTAINER_INHERIT,
845 0,
846 SEC_ACE_FLAG_CONTAINER_INHERIT,
847 },
848 {
849 SEC_ACE_FLAG_OBJECT_INHERIT |
850 SEC_ACE_FLAG_CONTAINER_INHERIT,
851 0,
852 SEC_ACE_FLAG_OBJECT_INHERIT |
853 SEC_ACE_FLAG_CONTAINER_INHERIT,
854 },
855 {
856 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT,
857 0,
858 0,
859 },
860 {
861 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
862 SEC_ACE_FLAG_OBJECT_INHERIT,
863 0,
864 0,
865 },
866 {
867 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
868 SEC_ACE_FLAG_CONTAINER_INHERIT,
869 0,
870 0,
871 },
872 {
873 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
874 SEC_ACE_FLAG_CONTAINER_INHERIT |
875 SEC_ACE_FLAG_OBJECT_INHERIT,
876 0,
877 0,
878 },
879 {
880 SEC_ACE_FLAG_INHERIT_ONLY,
881 0,
882 0,
883 },
884 {
885 SEC_ACE_FLAG_INHERIT_ONLY |
886 SEC_ACE_FLAG_OBJECT_INHERIT,
887 0,
888 SEC_ACE_FLAG_OBJECT_INHERIT |
889 SEC_ACE_FLAG_INHERIT_ONLY,
890 },
891 {
892 SEC_ACE_FLAG_INHERIT_ONLY |
893 SEC_ACE_FLAG_CONTAINER_INHERIT,
894 0,
895 SEC_ACE_FLAG_CONTAINER_INHERIT,
896 },
897 {
898 SEC_ACE_FLAG_INHERIT_ONLY |
899 SEC_ACE_FLAG_CONTAINER_INHERIT |
900 SEC_ACE_FLAG_OBJECT_INHERIT,
901 0,
902 SEC_ACE_FLAG_CONTAINER_INHERIT |
903 SEC_ACE_FLAG_OBJECT_INHERIT,
904 },
905 {
906 SEC_ACE_FLAG_INHERIT_ONLY |
907 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT,
908 0,
909 0,
910 },
911 {
912 SEC_ACE_FLAG_INHERIT_ONLY |
913 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
914 SEC_ACE_FLAG_OBJECT_INHERIT,
915 0,
916 0,
917 },
918 {
919 SEC_ACE_FLAG_INHERIT_ONLY |
920 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
921 SEC_ACE_FLAG_CONTAINER_INHERIT,
922 0,
923 0,
924 },
925 {
926 SEC_ACE_FLAG_INHERIT_ONLY |
927 SEC_ACE_FLAG_NO_PROPAGATE_INHERIT |
928 SEC_ACE_FLAG_CONTAINER_INHERIT |
929 SEC_ACE_FLAG_OBJECT_INHERIT,
930 0,
931 0,
932 }
933 };
934
935 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
936 return false;
937
938 torture_comment(tctx, "TESTING ACL INHERITANCE\n");
939
940 ZERO_STRUCT(io);
941 io.level = RAW_OPEN_SMB2;
942 io.in.create_flags = 0;
943 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
944 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
945 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
946 io.in.share_access = 0;
947 io.in.alloc_size = 0;
948 io.in.create_disposition = NTCREATEX_DISP_CREATE;
949 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
950 io.in.security_flags = 0;
951 io.in.fname = dname;
952
953 status = smb2_create(tree, tctx, &io);
954 CHECK_STATUS(status, NT_STATUS_OK);
955 handle = io.out.file.handle;
956
957 torture_comment(tctx, "get the original sd\n");
958 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
959 q.query_secdesc.in.file.handle = handle;
960 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
961 status = smb2_getinfo_file(tree, tctx, &q);
962 CHECK_STATUS(status, NT_STATUS_OK);
963 sd_orig = q.query_secdesc.out.sd;
964
965 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
966
967 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
968
969 /*
970 * The Windows Default ACL for a new file, when there is no ACL to be
971 * inherited: FullControl for the owner and SYSTEM.
972 */
973 sd_def1 = security_descriptor_dacl_create(tctx,
974 0, owner_sid, NULL,
975 owner_sid,
976 SEC_ACE_TYPE_ACCESS_ALLOWED,
977 SEC_RIGHTS_FILE_ALL,
978 0,
979 SID_NT_SYSTEM,
980 SEC_ACE_TYPE_ACCESS_ALLOWED,
981 SEC_RIGHTS_FILE_ALL,
982 0,
983 NULL);
984
985 /*
986 * Use this in the case the system being tested does not add an ACE for
987 * the SYSTEM SID.
988 */
989 sd_def2 = security_descriptor_dacl_create(tctx,
990 0, owner_sid, NULL,
991 owner_sid,
992 SEC_ACE_TYPE_ACCESS_ALLOWED,
993 SEC_RIGHTS_FILE_ALL,
994 0,
995 NULL);
996
997 creator_owner = dom_sid_parse_talloc(tctx, SID_CREATOR_OWNER);
998
999 for (i=0;i<ARRAY_SIZE(test_flags);i++) {
1000 sd = security_descriptor_dacl_create(tctx,
1001 0, NULL, NULL,
1002 SID_CREATOR_OWNER,
1003 SEC_ACE_TYPE_ACCESS_ALLOWED,
1004 SEC_FILE_WRITE_DATA,
1005 test_flags[i].parent_flags,
1006 SID_WORLD,
1007 SEC_ACE_TYPE_ACCESS_ALLOWED,
1008 SEC_FILE_ALL | SEC_STD_ALL,
1009 0,
1010 NULL);
1011 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1012 set.set_secdesc.in.file.handle = handle;
1013 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1014 set.set_secdesc.in.sd = sd;
1015 status = smb2_setinfo_file(tree, &set);
1016 CHECK_STATUS(status, NT_STATUS_OK);
1017
1018 io.in.fname = fname1;
1019 io.in.create_options = 0;
1020 status = smb2_create(tree, tctx, &io);
1021 CHECK_STATUS(status, NT_STATUS_OK);
1022 handle2 = io.out.file.handle;
1023
1024 q.query_secdesc.in.file.handle = handle2;
1025 status = smb2_getinfo_file(tree, tctx, &q);
1026 CHECK_STATUS(status, NT_STATUS_OK);
1027
1028 smb2_util_close(tree, handle2);
1029 smb2_util_unlink(tree, fname1);
1030
1031 if (!(test_flags[i].parent_flags & SEC_ACE_FLAG_OBJECT_INHERIT)) {
1032 if (!security_descriptor_equal(q.query_secdesc.out.sd, sd_def1) &&
1033 !security_descriptor_equal(q.query_secdesc.out.sd, sd_def2)) {
1034 torture_warning(tctx, "Expected default sd:\n");
1035 NDR_PRINT_DEBUG(security_descriptor, sd_def1);
1036 torture_warning(tctx, "at %d - got:\n", i);
1037 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1038 }
1039 goto check_dir;
1040 }
1041
1042 if (q.query_secdesc.out.sd->dacl == NULL ||
1043 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1044 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1045 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1046 sd_orig->owner_sid)) {
1047 torture_warning(tctx, "Bad sd in child file at %d\n", i);
1048 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1049 ret = false;
1050 goto check_dir;
1051 }
1052
1053 if (q.query_secdesc.out.sd->dacl->aces[0].flags !=
1054 test_flags[i].file_flags) {
1055 torture_warning(tctx, "incorrect file_flags 0x%x - expected 0x%x for parent 0x%x with (i=%d)\n",
1056 q.query_secdesc.out.sd->dacl->aces[0].flags,
1057 test_flags[i].file_flags,
1058 test_flags[i].parent_flags,
1059 i);
1060 ret = false;
1061 }
1062
1063 check_dir:
1064 io.in.fname = fname2;
1065 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1066 status = smb2_create(tree, tctx, &io);
1067 CHECK_STATUS(status, NT_STATUS_OK);
1068 handle2 = io.out.file.handle;
1069
1070 q.query_secdesc.in.file.handle = handle2;
1071 status = smb2_getinfo_file(tree, tctx, &q);
1072 CHECK_STATUS(status, NT_STATUS_OK);
1073
1074 smb2_util_close(tree, handle2);
1075 smb2_util_rmdir(tree, fname2);
1076
1077 if (!(test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) &&
1078 (!(test_flags[i].parent_flags & SEC_ACE_FLAG_OBJECT_INHERIT) ||
1079 (test_flags[i].parent_flags & SEC_ACE_FLAG_NO_PROPAGATE_INHERIT))) {
1080 if (!security_descriptor_equal(q.query_secdesc.out.sd, sd_def1) &&
1081 !security_descriptor_equal(q.query_secdesc.out.sd, sd_def2)) {
1082 torture_warning(tctx, "Expected default sd for dir at %d:\n", i);
1083 NDR_PRINT_DEBUG(security_descriptor, sd_def1);
1084 torture_warning(tctx, "got:\n");
1085 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1086 }
1087 continue;
1088 }
1089
1090 if ((test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) &&
1091 (test_flags[i].parent_flags & SEC_ACE_FLAG_NO_PROPAGATE_INHERIT)) {
1092 if (q.query_secdesc.out.sd->dacl == NULL ||
1093 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1094 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1095 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1096 sd_orig->owner_sid) ||
1097 q.query_secdesc.out.sd->dacl->aces[0].flags != test_flags[i].dir_flags) {
1098 torture_warning(tctx, "(CI & NP) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1099 test_flags[i].dir_flags,
1100 test_flags[i].parent_flags, i);
1101 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1102 torture_warning(tctx, "FYI, here is the parent sd:\n");
1103 NDR_PRINT_DEBUG(security_descriptor, sd);
1104 ret = false;
1105 continue;
1106 }
1107 } else if (test_flags[i].parent_flags & SEC_ACE_FLAG_CONTAINER_INHERIT) {
1108 if (q.query_secdesc.out.sd->dacl == NULL ||
1109 q.query_secdesc.out.sd->dacl->num_aces != 2 ||
1110 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1111 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1112 sd_orig->owner_sid) ||
1113 q.query_secdesc.out.sd->dacl->aces[1].access_mask != SEC_FILE_WRITE_DATA ||
1114 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[1].trustee,
1115 creator_owner) ||
1116 q.query_secdesc.out.sd->dacl->aces[0].flags != 0 ||
1117 q.query_secdesc.out.sd->dacl->aces[1].flags !=
1118 (test_flags[i].dir_flags | SEC_ACE_FLAG_INHERIT_ONLY)) {
1119 torture_warning(tctx, "(CI) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1120 test_flags[i].dir_flags,
1121 test_flags[i].parent_flags, i);
1122 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1123 torture_warning(tctx, "FYI, here is the parent sd:\n");
1124 NDR_PRINT_DEBUG(security_descriptor, sd);
1125 ret = false;
1126 continue;
1127 }
1128 } else {
1129 if (q.query_secdesc.out.sd->dacl == NULL ||
1130 q.query_secdesc.out.sd->dacl->num_aces != 1 ||
1131 q.query_secdesc.out.sd->dacl->aces[0].access_mask != SEC_FILE_WRITE_DATA ||
1132 !dom_sid_equal(&q.query_secdesc.out.sd->dacl->aces[0].trustee,
1133 creator_owner) ||
1134 q.query_secdesc.out.sd->dacl->aces[0].flags != test_flags[i].dir_flags) {
1135 torture_warning(tctx, "(0) Bad sd in child dir - expected 0x%x for parent 0x%x (i=%d)\n",
1136 test_flags[i].dir_flags,
1137 test_flags[i].parent_flags, i);
1138 NDR_PRINT_DEBUG(security_descriptor, q.query_secdesc.out.sd);
1139 torture_warning(tctx, "FYI, here is the parent sd:\n");
1140 NDR_PRINT_DEBUG(security_descriptor, sd);
1141 ret = false;
1142 continue;
1143 }
1144 }
1145 }
1146
1147 torture_comment(tctx, "Testing access checks on inherited create with %s\n", fname1);
1148 sd = security_descriptor_dacl_create(tctx,
1149 0, NULL, NULL,
1150 owner_sid,
1151 SEC_ACE_TYPE_ACCESS_ALLOWED,
1152 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1153 SEC_ACE_FLAG_OBJECT_INHERIT,
1154 SID_WORLD,
1155 SEC_ACE_TYPE_ACCESS_ALLOWED,
1156 SEC_FILE_ALL | SEC_STD_ALL,
1157 0,
1158 NULL);
1159 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1160 set.set_secdesc.in.file.handle = handle;
1161 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1162 set.set_secdesc.in.sd = sd;
1163 status = smb2_setinfo_file(tree, &set);
1164 CHECK_STATUS(status, NT_STATUS_OK);
1165
1166 /* Check DACL we just set. */
1167 torture_comment(tctx, "checking new sd\n");
1168 q.query_secdesc.in.file.handle = handle;
1169 q.query_secdesc.in.secinfo_flags = SECINFO_DACL;
1170 status = smb2_getinfo_file(tree, tctx, &q);
1171 CHECK_STATUS(status, NT_STATUS_OK);
1172 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
1173
1174 io.in.fname = fname1;
1175 io.in.create_options = 0;
1176 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1177 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1178 status = smb2_create(tree, tctx, &io);
1179 CHECK_STATUS(status, NT_STATUS_OK);
1180 handle2 = io.out.file.handle;
1181 CHECK_ACCESS_FLAGS(handle2, SEC_RIGHTS_FILE_ALL);
1182
1183 q.query_secdesc.in.file.handle = handle2;
1184 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1185 status = smb2_getinfo_file(tree, tctx, &q);
1186 CHECK_STATUS(status, NT_STATUS_OK);
1187 smb2_util_close(tree, handle2);
1188
1189 sd2 = security_descriptor_dacl_create(tctx,
1190 0, owner_sid, NULL,
1191 owner_sid,
1192 SEC_ACE_TYPE_ACCESS_ALLOWED,
1193 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1194 0,
1195 NULL);
1196 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1197
1198 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1199 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1200 status = smb2_create(tree, tctx, &io);
1201 if (NT_STATUS_IS_OK(status)) {
1202 torture_warning(tctx, "failed: w2k3 ACL bug (allowed open when ACL should deny)\n");
1203 ret = false;
1204 handle2 = io.out.file.handle;
1205 CHECK_ACCESS_FLAGS(handle2, SEC_RIGHTS_FILE_ALL);
1206 smb2_util_close(tree, handle2);
1207 } else {
1208 if (torture_setting_bool(tctx, "hide_on_access_denied",
1209 false)) {
1210 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1211 } else {
1212 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1213 }
1214 }
1215
1216 torture_comment(tctx, "trying without execute\n");
1217 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1218 io.in.desired_access = SEC_RIGHTS_FILE_ALL & ~SEC_FILE_EXECUTE;
1219 status = smb2_create(tree, tctx, &io);
1220 if (torture_setting_bool(tctx, "hide_on_access_denied", false)) {
1221 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1222 } else {
1223 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1224 }
1225
1226 torture_comment(tctx, "and with full permissions again\n");
1227 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1228 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1229 status = smb2_create(tree, tctx, &io);
1230 if (torture_setting_bool(tctx, "hide_on_access_denied", false)) {
1231 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1232 } else {
1233 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1234 }
1235
1236 io.in.desired_access = SEC_FILE_WRITE_DATA;
1237 status = smb2_create(tree, tctx, &io);
1238 CHECK_STATUS(status, NT_STATUS_OK);
1239 handle2 = io.out.file.handle;
1240 CHECK_ACCESS_FLAGS(handle2, SEC_FILE_WRITE_DATA);
1241 smb2_util_close(tree, handle2);
1242
1243 torture_comment(tctx, "put back original sd\n");
1244 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1245 set.set_secdesc.in.file.handle = handle;
1246 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1247 set.set_secdesc.in.sd = sd_orig;
1248 status = smb2_setinfo_file(tree, &set);
1249 CHECK_STATUS(status, NT_STATUS_OK);
1250
1251 smb2_util_close(tree, handle);
1252
1253 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1254 status = smb2_create(tree, tctx, &io);
1255 if (torture_setting_bool(tctx, "hide_on_access_denied", false)) {
1256 CHECK_STATUS(status, NT_STATUS_OBJECT_NAME_NOT_FOUND);
1257 } else {
1258 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1259 }
1260
1261 io.in.desired_access = SEC_FILE_WRITE_DATA;
1262 status = smb2_create(tree, tctx, &io);
1263 CHECK_STATUS(status, NT_STATUS_OK);
1264 handle2 = io.out.file.handle;
1265 CHECK_ACCESS_FLAGS(handle2, SEC_FILE_WRITE_DATA);
1266 smb2_util_close(tree, handle2);
1267
1268 done:
1269 torture_comment(tctx, "put back original sd\n");
1270 restore_sd_orig(tree, &set, handle, sd_orig);
1271 if (!smb2_util_handle_empty(handle)) {
1272 smb2_util_close(tree, handle);
1273 }
1274 smb2_util_unlink(tree, fname1);
1275 smb2_util_rmdir(tree, dname);
1276 smb2_deltree(tree, BASEDIR);
1277 smb2_tdis(tree);
1278 smb2_logoff(tree->session);
1279 return ret;
1280 }
1281
1282 static bool test_inheritance_flags(struct torture_context *tctx,
1283 struct smb2_tree *tree)
1284 {
1285 NTSTATUS status;
1286 struct smb2_create io;
1287 const char *dname = BASEDIR "\\inheritance";
1288 const char *fname1 = BASEDIR "\\inheritance\\testfile";
1289 bool ret = true;
1290 struct smb2_handle handle = {{0}};
1291 struct smb2_handle handle2 = {{0}};
1292 int i, j;
1293 union smb_fileinfo q;
1294 union smb_setfileinfo set;
1295 struct security_descriptor *sd, *sd2, *sd_orig=NULL;
1296 const char *owner_sid;
1297 struct {
1298 uint32_t parent_set_sd_type; /* 3 options */
1299 uint32_t parent_set_ace_inherit; /* 1 option */
1300 uint32_t parent_get_sd_type;
1301 uint32_t parent_get_ace_inherit;
1302 uint32_t child_get_sd_type;
1303 uint32_t child_get_ace_inherit;
1304 } tflags[16] = {{0}}; /* 2^4 */
1305
1306 for (i = 0; i < 15; i++) {
1307 torture_comment(tctx, "i=%d:", i);
1308
1309 if (i & 1) {
1310 tflags[i].parent_set_sd_type |=
1311 SEC_DESC_DACL_AUTO_INHERITED;
1312 torture_comment(tctx, "AUTO_INHERITED, ");
1313 }
1314 if (i & 2) {
1315 tflags[i].parent_set_sd_type |=
1316 SEC_DESC_DACL_AUTO_INHERIT_REQ;
1317 torture_comment(tctx, "AUTO_INHERIT_REQ, ");
1318 }
1319 if (i & 4) {
1320 tflags[i].parent_set_sd_type |=
1321 SEC_DESC_DACL_PROTECTED;
1322 torture_comment(tctx, "PROTECTED, ");
1323 tflags[i].parent_get_sd_type |=
1324 SEC_DESC_DACL_PROTECTED;
1325 }
1326 if (i & 8) {
1327 tflags[i].parent_set_ace_inherit |=
1328 SEC_ACE_FLAG_INHERITED_ACE;
1329 torture_comment(tctx, "INHERITED, ");
1330 tflags[i].parent_get_ace_inherit |=
1331 SEC_ACE_FLAG_INHERITED_ACE;
1332 }
1333
1334 if ((tflags[i].parent_set_sd_type &
1335 (SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ)) ==
1336 (SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ)) {
1337 tflags[i].parent_get_sd_type |=
1338 SEC_DESC_DACL_AUTO_INHERITED;
1339 tflags[i].child_get_sd_type |=
1340 SEC_DESC_DACL_AUTO_INHERITED;
1341 tflags[i].child_get_ace_inherit |=
1342 SEC_ACE_FLAG_INHERITED_ACE;
1343 torture_comment(tctx, " ... parent is AUTO INHERITED");
1344 }
1345
1346 if (tflags[i].parent_set_ace_inherit &
1347 SEC_ACE_FLAG_INHERITED_ACE) {
1348 tflags[i].parent_get_ace_inherit =
1349 SEC_ACE_FLAG_INHERITED_ACE;
1350 torture_comment(tctx, " ... parent ACE is INHERITED");
1351 }
1352
1353 torture_comment(tctx, "\n");
1354 }
1355
1356 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
1357 return false;
1358
1359 torture_comment(tctx, "TESTING ACL INHERITANCE FLAGS\n");
1360
1361 ZERO_STRUCT(io);
1362 io.level = RAW_OPEN_SMB2;
1363 io.in.create_flags = 0;
1364 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1365 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1366 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
1367 io.in.share_access = NTCREATEX_SHARE_ACCESS_MASK;
1368 io.in.alloc_size = 0;
1369 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1370 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
1371 io.in.security_flags = 0;
1372 io.in.fname = dname;
1373
1374 torture_comment(tctx, "creating initial directory %s\n", dname);
1375 status = smb2_create(tree, tctx, &io);
1376 CHECK_STATUS(status, NT_STATUS_OK);
1377 handle = io.out.file.handle;
1378
1379 torture_comment(tctx, "getting original sd\n");
1380 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1381 q.query_secdesc.in.file.handle = handle;
1382 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1383 status = smb2_getinfo_file(tree, tctx, &q);
1384 CHECK_STATUS(status, NT_STATUS_OK);
1385 sd_orig = q.query_secdesc.out.sd;
1386
1387 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
1388 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
1389
1390 for (i=0; i < ARRAY_SIZE(tflags); i++) {
1391 torture_comment(tctx, "setting a new sd on directory, pass #%d\n", i);
1392
1393 sd = security_descriptor_dacl_create(tctx,
1394 tflags[i].parent_set_sd_type,
1395 NULL, NULL,
1396 owner_sid,
1397 SEC_ACE_TYPE_ACCESS_ALLOWED,
1398 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1399 SEC_ACE_FLAG_OBJECT_INHERIT |
1400 SEC_ACE_FLAG_CONTAINER_INHERIT |
1401 tflags[i].parent_set_ace_inherit,
1402 SID_WORLD,
1403 SEC_ACE_TYPE_ACCESS_ALLOWED,
1404 SEC_FILE_ALL | SEC_STD_ALL,
1405 0,
1406 NULL);
1407 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1408 set.set_secdesc.in.file.handle = handle;
1409 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1410 set.set_secdesc.in.sd = sd;
1411 status = smb2_setinfo_file(tree, &set);
1412 CHECK_STATUS(status, NT_STATUS_OK);
1413
1414 /*
1415 * Check DACL we just set, except change the bits to what they
1416 * should be.
1417 */
1418 torture_comment(tctx, " checking new sd\n");
1419
1420 /* REQ bit should always be false. */
1421 sd->type &= ~SEC_DESC_DACL_AUTO_INHERIT_REQ;
1422
1423 if ((tflags[i].parent_get_sd_type & SEC_DESC_DACL_AUTO_INHERITED) == 0)
1424 sd->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
1425
1426 q.query_secdesc.in.file.handle = handle;
1427 q.query_secdesc.in.secinfo_flags = SECINFO_DACL;
1428 status = smb2_getinfo_file(tree, tctx, &q);
1429 CHECK_STATUS(status, NT_STATUS_OK);
1430 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
1431
1432 /* Create file. */
1433 torture_comment(tctx, " creating file %s\n", fname1);
1434 io.in.fname = fname1;
1435 io.in.create_options = 0;
1436 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
1437 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1438 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1439 status = smb2_create(tree, tctx, &io);
1440 CHECK_STATUS(status, NT_STATUS_OK);
1441 handle2 = io.out.file.handle;
1442 CHECK_ACCESS_FLAGS(handle2, SEC_RIGHTS_FILE_ALL);
1443
1444 q.query_secdesc.in.file.handle = handle2;
1445 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1446 status = smb2_getinfo_file(tree, tctx, &q);
1447 CHECK_STATUS(status, NT_STATUS_OK);
1448
1449 torture_comment(tctx, " checking sd on file %s\n", fname1);
1450 sd2 = security_descriptor_dacl_create(tctx,
1451 tflags[i].child_get_sd_type,
1452 owner_sid, NULL,
1453 owner_sid,
1454 SEC_ACE_TYPE_ACCESS_ALLOWED,
1455 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1456 tflags[i].child_get_ace_inherit,
1457 NULL);
1458 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1459
1460 /*
1461 * Set new sd on file ... prove that the bits have nothing to
1462 * do with the parents bits when manually setting an ACL. The
1463 * _AUTO_INHERITED bit comes directly from the ACL set.
1464 */
1465 for (j = 0; j < ARRAY_SIZE(tflags); j++) {
1466 torture_comment(tctx, " setting new file sd, pass #%d\n", j);
1467
1468 /* Change sd type. */
1469 sd2->type &= ~(SEC_DESC_DACL_AUTO_INHERITED |
1470 SEC_DESC_DACL_AUTO_INHERIT_REQ |
1471 SEC_DESC_DACL_PROTECTED);
1472 sd2->type |= tflags[j].parent_set_sd_type;
1473
1474 sd2->dacl->aces[0].flags &=
1475 ~SEC_ACE_FLAG_INHERITED_ACE;
1476 sd2->dacl->aces[0].flags |=
1477 tflags[j].parent_set_ace_inherit;
1478
1479 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1480 set.set_secdesc.in.file.handle = handle2;
1481 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1482 set.set_secdesc.in.sd = sd2;
1483 status = smb2_setinfo_file(tree, &set);
1484 CHECK_STATUS(status, NT_STATUS_OK);
1485
1486 /* Check DACL we just set. */
1487 sd2->type &= ~SEC_DESC_DACL_AUTO_INHERIT_REQ;
1488 if ((tflags[j].parent_get_sd_type & SEC_DESC_DACL_AUTO_INHERITED) == 0)
1489 sd2->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
1490
1491 q.query_secdesc.in.file.handle = handle2;
1492 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1493 status = smb2_getinfo_file(tree, tctx, &q);
1494 CHECK_STATUS(status, NT_STATUS_OK);
1495
1496 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1497 }
1498
1499 smb2_util_close(tree, handle2);
1500 smb2_util_unlink(tree, fname1);
1501 }
1502
1503 done:
1504 torture_comment(tctx, "put back original sd\n");
1505 restore_sd_orig(tree, &set, handle, sd_orig);
1506 if (!smb2_util_handle_empty(handle)) {
1507 smb2_util_close(tree, handle);
1508 }
1509 smb2_util_unlink(tree, fname1);
1510 smb2_deltree(tree, BASEDIR);
1511 smb2_tdis(tree);
1512 smb2_logoff(tree->session);
1513 return ret;
1514 }
1515
1516 /*
1517 * This is basically a copy of test_inheritance_flags() with an additional twist
1518 * to change the owner of the testfile, verifying that the security descriptor
1519 * flags are not altered.
1520 */
1521 static bool test_sd_flags_vs_chown(struct torture_context *tctx,
1522 struct smb2_tree *tree)
1523 {
1524 NTSTATUS status;
1525 struct smb2_create io;
1526 const char *dname = BASEDIR "\\inheritance";
1527 const char *fname1 = BASEDIR "\\inheritance\\testfile";
1528 bool ret = true;
1529 struct smb2_handle handle = {{0}};
1530 struct smb2_handle handle2 = {{0}};
1531 int i, j;
1532 union smb_fileinfo q;
1533 union smb_setfileinfo set;
1534 struct security_descriptor *sd, *sd2, *sd_orig=NULL;
1535 struct security_descriptor *owner_sd = NULL;
1536 const char *owner_sid_string = NULL;
1537 struct dom_sid *owner_sid = NULL;
1538 struct dom_sid world_sid = global_sid_World;
1539 struct {
1540 uint32_t parent_set_sd_type; /* 3 options */
1541 uint32_t parent_set_ace_inherit; /* 1 option */
1542 uint32_t parent_get_sd_type;
1543 uint32_t parent_get_ace_inherit;
1544 uint32_t child_get_sd_type;
1545 uint32_t child_get_ace_inherit;
1546 } tflags[16] = {{0}}; /* 2^4 */
1547
1548 if (TARGET_IS_WINDOWS(tctx)) {
1549 torture_skip(tctx, "Not supported by windows backend\n");
1550 }
1551
1552 owner_sd = security_descriptor_dacl_create(tctx,
1553 0,
1554 SID_WORLD,
1555 NULL,
1556 NULL);
1557 torture_assert_not_null_goto(tctx, owner_sd, ret, done,
1558 "security_descriptor_dacl_create failed\n");
1559
1560 for (i = 0; i < 15; i++) {
1561 torture_comment(tctx, "i=%d:", i);
1562
1563 if (i & 1) {
1564 tflags[i].parent_set_sd_type |=
1565 SEC_DESC_DACL_AUTO_INHERITED;
1566 torture_comment(tctx, "AUTO_INHERITED, ");
1567 }
1568 if (i & 2) {
1569 tflags[i].parent_set_sd_type |=
1570 SEC_DESC_DACL_AUTO_INHERIT_REQ;
1571 torture_comment(tctx, "AUTO_INHERIT_REQ, ");
1572 }
1573 if (i & 4) {
1574 tflags[i].parent_set_sd_type |=
1575 SEC_DESC_DACL_PROTECTED;
1576 torture_comment(tctx, "PROTECTED, ");
1577 tflags[i].parent_get_sd_type |=
1578 SEC_DESC_DACL_PROTECTED;
1579 }
1580 if (i & 8) {
1581 tflags[i].parent_set_ace_inherit |=
1582 SEC_ACE_FLAG_INHERITED_ACE;
1583 torture_comment(tctx, "INHERITED, ");
1584 tflags[i].parent_get_ace_inherit |=
1585 SEC_ACE_FLAG_INHERITED_ACE;
1586 }
1587
1588 if ((tflags[i].parent_set_sd_type &
1589 (SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ)) ==
1590 (SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ)) {
1591 tflags[i].parent_get_sd_type |=
1592 SEC_DESC_DACL_AUTO_INHERITED;
1593 tflags[i].child_get_sd_type |=
1594 SEC_DESC_DACL_AUTO_INHERITED;
1595 tflags[i].child_get_ace_inherit |=
1596 SEC_ACE_FLAG_INHERITED_ACE;
1597 torture_comment(tctx, " ... parent is AUTO INHERITED");
1598 }
1599
1600 if (tflags[i].parent_set_ace_inherit &
1601 SEC_ACE_FLAG_INHERITED_ACE) {
1602 tflags[i].parent_get_ace_inherit =
1603 SEC_ACE_FLAG_INHERITED_ACE;
1604 torture_comment(tctx, " ... parent ACE is INHERITED");
1605 }
1606
1607 torture_comment(tctx, "\n");
1608 }
1609
1610 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
1611 return false;
1612
1613 torture_comment(tctx, "TESTING ACL INHERITANCE FLAGS\n");
1614
1615 ZERO_STRUCT(io);
1616 io.level = RAW_OPEN_SMB2;
1617 io.in.create_flags = 0;
1618 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1619 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1620 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
1621 io.in.share_access = NTCREATEX_SHARE_ACCESS_MASK;
1622 io.in.alloc_size = 0;
1623 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1624 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
1625 io.in.security_flags = 0;
1626 io.in.fname = dname;
1627
1628 torture_comment(tctx, "creating initial directory %s\n", dname);
1629 status = smb2_create(tree, tctx, &io);
1630 CHECK_STATUS(status, NT_STATUS_OK);
1631 handle = io.out.file.handle;
1632
1633 torture_comment(tctx, "getting original sd\n");
1634 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1635 q.query_secdesc.in.file.handle = handle;
1636 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1637 status = smb2_getinfo_file(tree, tctx, &q);
1638 CHECK_STATUS(status, NT_STATUS_OK);
1639 sd_orig = q.query_secdesc.out.sd;
1640
1641 owner_sid = sd_orig->owner_sid;
1642 owner_sid_string = dom_sid_string(tctx, sd_orig->owner_sid);
1643 torture_comment(tctx, "owner_sid is %s\n", owner_sid_string);
1644
1645 for (i=0; i < ARRAY_SIZE(tflags); i++) {
1646 torture_comment(tctx, "setting a new sd on directory, pass #%d\n", i);
1647
1648 sd = security_descriptor_dacl_create(tctx,
1649 tflags[i].parent_set_sd_type,
1650 NULL, NULL,
1651 owner_sid_string,
1652 SEC_ACE_TYPE_ACCESS_ALLOWED,
1653 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1654 SEC_ACE_FLAG_OBJECT_INHERIT |
1655 SEC_ACE_FLAG_CONTAINER_INHERIT |
1656 tflags[i].parent_set_ace_inherit,
1657 SID_WORLD,
1658 SEC_ACE_TYPE_ACCESS_ALLOWED,
1659 SEC_FILE_ALL | SEC_STD_ALL,
1660 0,
1661 NULL);
1662 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1663 set.set_secdesc.in.file.handle = handle;
1664 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1665 set.set_secdesc.in.sd = sd;
1666 status = smb2_setinfo_file(tree, &set);
1667 CHECK_STATUS(status, NT_STATUS_OK);
1668
1669 /*
1670 * Check DACL we just set, except change the bits to what they
1671 * should be.
1672 */
1673 torture_comment(tctx, " checking new sd\n");
1674
1675 /* REQ bit should always be false. */
1676 sd->type &= ~SEC_DESC_DACL_AUTO_INHERIT_REQ;
1677
1678 if ((tflags[i].parent_get_sd_type & SEC_DESC_DACL_AUTO_INHERITED) == 0)
1679 sd->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
1680
1681 q.query_secdesc.in.file.handle = handle;
1682 q.query_secdesc.in.secinfo_flags = SECINFO_DACL;
1683 status = smb2_getinfo_file(tree, tctx, &q);
1684 CHECK_STATUS(status, NT_STATUS_OK);
1685 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd);
1686
1687 /* Create file. */
1688 torture_comment(tctx, " creating file %s\n", fname1);
1689 io.in.fname = fname1;
1690 io.in.create_options = 0;
1691 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
1692 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1693 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1694 status = smb2_create(tree, tctx, &io);
1695 CHECK_STATUS(status, NT_STATUS_OK);
1696 handle2 = io.out.file.handle;
1697 CHECK_ACCESS_FLAGS(handle2, SEC_RIGHTS_FILE_ALL);
1698
1699 q.query_secdesc.in.file.handle = handle2;
1700 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1701 status = smb2_getinfo_file(tree, tctx, &q);
1702 CHECK_STATUS(status, NT_STATUS_OK);
1703
1704 torture_comment(tctx, " checking sd on file %s\n", fname1);
1705 sd2 = security_descriptor_dacl_create(tctx,
1706 tflags[i].child_get_sd_type,
1707 owner_sid_string, NULL,
1708 owner_sid_string,
1709 SEC_ACE_TYPE_ACCESS_ALLOWED,
1710 SEC_FILE_WRITE_DATA | SEC_STD_WRITE_DAC,
1711 tflags[i].child_get_ace_inherit,
1712 NULL);
1713 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1714
1715 /*
1716 * Set new sd on file ... prove that the bits have nothing to
1717 * do with the parents bits when manually setting an ACL. The
1718 * _AUTO_INHERITED bit comes directly from the ACL set.
1719 */
1720 for (j = 0; j < ARRAY_SIZE(tflags); j++) {
1721 torture_comment(tctx, " setting new file sd, pass #%d\n", j);
1722
1723 /* Change sd type. */
1724 sd2->type &= ~(SEC_DESC_DACL_AUTO_INHERITED |
1725 SEC_DESC_DACL_AUTO_INHERIT_REQ |
1726 SEC_DESC_DACL_PROTECTED);
1727 sd2->type |= tflags[j].parent_set_sd_type;
1728
1729 sd2->dacl->aces[0].flags &=
1730 ~SEC_ACE_FLAG_INHERITED_ACE;
1731 sd2->dacl->aces[0].flags |=
1732 tflags[j].parent_set_ace_inherit;
1733
1734 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1735 set.set_secdesc.in.file.handle = handle2;
1736 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1737 set.set_secdesc.in.sd = sd2;
1738 status = smb2_setinfo_file(tree, &set);
1739 CHECK_STATUS(status, NT_STATUS_OK);
1740
1741 /* Check DACL we just set. */
1742 sd2->type &= ~SEC_DESC_DACL_AUTO_INHERIT_REQ;
1743 if ((tflags[j].parent_get_sd_type & SEC_DESC_DACL_AUTO_INHERITED) == 0)
1744 sd2->type &= ~SEC_DESC_DACL_AUTO_INHERITED;
1745
1746 q.query_secdesc.in.file.handle = handle2;
1747 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1748 status = smb2_getinfo_file(tree, tctx, &q);
1749 CHECK_STATUS(status, NT_STATUS_OK);
1750
1751 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1752
1753 /*
1754 * Check that changing owner doesn't affect SD flags.
1755 *
1756 * Do this by first changing owner to world and then
1757 * back to the original owner. Afterwards compare SD,
1758 * should be the same.
1759 */
1760 owner_sd->owner_sid = &world_sid;
1761 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1762 set.set_secdesc.in.file.handle = handle2;
1763 set.set_secdesc.in.secinfo_flags = SECINFO_OWNER;
1764 set.set_secdesc.in.sd = owner_sd;
1765 status = smb2_setinfo_file(tree, &set);
1766 CHECK_STATUS(status, NT_STATUS_OK);
1767
1768 owner_sd->owner_sid = owner_sid;
1769 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1770 set.set_secdesc.in.file.handle = handle2;
1771 set.set_secdesc.in.secinfo_flags = SECINFO_OWNER;
1772 set.set_secdesc.in.sd = owner_sd;
1773 status = smb2_setinfo_file(tree, &set);
1774 CHECK_STATUS(status, NT_STATUS_OK);
1775
1776 q.query_secdesc.in.file.handle = handle2;
1777 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1778 status = smb2_getinfo_file(tree, tctx, &q);
1779 CHECK_STATUS(status, NT_STATUS_OK);
1780
1781 CHECK_SECURITY_DESCRIPTOR(q.query_secdesc.out.sd, sd2);
1782 torture_assert_goto(tctx, ret, ret, done, "CHECK_SECURITY_DESCRIPTOR failed\n");
1783 }
1784
1785 smb2_util_close(tree, handle2);
1786 smb2_util_unlink(tree, fname1);
1787 }
1788
1789 done:
1790 torture_comment(tctx, "put back original sd\n");
1791 restore_sd_orig(tree, &set, handle, sd_orig);
1792 if (!smb2_util_handle_empty(handle)) {
1793 smb2_util_close(tree, handle);
1794 }
1795 smb2_util_unlink(tree, fname1);
1796 smb2_deltree(tree, BASEDIR);
1797 smb2_tdis(tree);
1798 smb2_logoff(tree->session);
1799 return ret;
1800 }
1801
1802 /*
1803 test dynamic acl inheritance
1804 Note: This test was copied from raw/acls.c.
1805 */
1806 static bool test_inheritance_dynamic(struct torture_context *tctx,
1807 struct smb2_tree *tree)
1808 {
1809 NTSTATUS status;
1810 struct smb2_create io;
1811 const char *dname = BASEDIR "\\inheritance";
1812 const char *fname1 = BASEDIR "\\inheritance\\testfile";
1813 bool ret = true;
1814 struct smb2_handle handle = {{0}};
1815 struct smb2_handle handle2 = {{0}};
1816 union smb_fileinfo q;
1817 union smb_setfileinfo set;
1818 struct security_descriptor *sd, *sd_orig=NULL;
1819 const char *owner_sid;
1820
1821 torture_comment(tctx, "TESTING DYNAMIC ACL INHERITANCE\n");
1822
1823 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
1824 return false;
1825
1826 ZERO_STRUCT(io);
1827 io.level = RAW_OPEN_SMB2;
1828 io.in.create_flags = 0;
1829 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
1830 io.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
1831 io.in.file_attributes = FILE_ATTRIBUTE_DIRECTORY;
1832 io.in.share_access = 0;
1833 io.in.alloc_size = 0;
1834 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1835 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
1836 io.in.security_flags = 0;
1837 io.in.fname = dname;
1838
1839 status = smb2_create(tree, tctx, &io);
1840 CHECK_STATUS(status, NT_STATUS_OK);
1841 handle = io.out.file.handle;
1842
1843 torture_comment(tctx, "get the original sd\n");
1844 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
1845 q.query_secdesc.in.file.handle = handle;
1846 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
1847 status = smb2_getinfo_file(tree, tctx, &q);
1848 CHECK_STATUS(status, NT_STATUS_OK);
1849 sd_orig = q.query_secdesc.out.sd;
1850
1851 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
1852
1853 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
1854
1855 sd = security_descriptor_dacl_create(tctx,
1856 0, NULL, NULL,
1857 owner_sid,
1858 SEC_ACE_TYPE_ACCESS_ALLOWED,
1859 SEC_FILE_WRITE_DATA | SEC_STD_DELETE | SEC_FILE_READ_ATTRIBUTE,
1860 SEC_ACE_FLAG_OBJECT_INHERIT,
1861 NULL);
1862 sd->type |= SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ;
1863
1864 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
1865 set.set_secdesc.in.file.handle = handle;
1866 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
1867 set.set_secdesc.in.sd = sd;
1868 status = smb2_setinfo_file(tree, &set);
1869 CHECK_STATUS(status, NT_STATUS_OK);
1870
1871 torture_comment(tctx, "create a file with an inherited acl\n");
1872 io.in.fname = fname1;
1873 io.in.create_options = 0;
1874 io.in.desired_access = SEC_FILE_READ_ATTRIBUTE;
1875 io.in.create_disposition = NTCREATEX_DISP_CREATE;
1876 status = smb2_create(tree, tctx, &io);
1877 CHECK_STATUS(status, NT_STATUS_OK);
1878 handle2 = io.out.file.handle;
1879 smb2_util_close(tree, handle2);
1880
1881 torture_comment(tctx, "try and access file with base rights - should be OK\n");
1882 io.in.desired_access = SEC_FILE_WRITE_DATA;
1883 io.in.create_disposition = NTCREATEX_DISP_OPEN;
1884 status = smb2_create(tree, tctx, &io);
1885 CHECK_STATUS(status, NT_STATUS_OK);
1886 handle2 = io.out.file.handle;
1887 smb2_util_close(tree, handle2);
1888
1889 torture_comment(tctx, "try and access file with extra rights - should be denied\n");
1890 io.in.desired_access = SEC_FILE_WRITE_DATA | SEC_FILE_EXECUTE;
1891 status = smb2_create(tree, tctx, &io);
1892 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1893
1894 torture_comment(tctx, "update parent sd\n");
1895 sd = security_descriptor_dacl_create(tctx,
1896 0, NULL, NULL,
1897 owner_sid,
1898 SEC_ACE_TYPE_ACCESS_ALLOWED,
1899 SEC_FILE_WRITE_DATA | SEC_STD_DELETE | SEC_FILE_READ_ATTRIBUTE | SEC_FILE_EXECUTE,
1900 SEC_ACE_FLAG_OBJECT_INHERIT,
1901 NULL);
1902 sd->type |= SEC_DESC_DACL_AUTO_INHERITED | SEC_DESC_DACL_AUTO_INHERIT_REQ;
1903
1904 set.set_secdesc.in.sd = sd;
1905 status = smb2_setinfo_file(tree, &set);
1906 CHECK_STATUS(status, NT_STATUS_OK);
1907
1908 torture_comment(tctx, "try and access file with base rights - should be OK\n");
1909 io.in.desired_access = SEC_FILE_WRITE_DATA;
1910 status = smb2_create(tree, tctx, &io);
1911 CHECK_STATUS(status, NT_STATUS_OK);
1912 handle2 = io.out.file.handle;
1913 smb2_util_close(tree, handle2);
1914
1915
1916 torture_comment(tctx, "try and access now - should be OK if dynamic inheritance works\n");
1917 io.in.desired_access = SEC_FILE_WRITE_DATA | SEC_FILE_EXECUTE;
1918 status = smb2_create(tree, tctx, &io);
1919 if (NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED)) {
1920 torture_comment(tctx, "Server does not have dynamic inheritance\n");
1921 }
1922 if (NT_STATUS_EQUAL(status, NT_STATUS_OK)) {
1923 torture_comment(tctx, "Server does have dynamic inheritance\n");
1924 }
1925 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED);
1926
1927 done:
1928 torture_comment(tctx, "put back original sd\n");
1929 restore_sd_orig(tree, &set, handle, sd_orig);
1930 if (!smb2_util_handle_empty(handle)) {
1931 smb2_util_close(tree, handle);
1932 }
1933 smb2_util_unlink(tree, fname1);
1934 smb2_util_rmdir(tree, dname);
1935 smb2_deltree(tree, BASEDIR);
1936 smb2_tdis(tree);
1937 smb2_logoff(tree->session);
1938
1939 return ret;
1940 }
1941
1942 #define CHECK_STATUS_FOR_BIT_ACTION(status, bits, action) do { \
1943 if (!(bits & desired_64)) {\
1944 CHECK_STATUS(status, NT_STATUS_ACCESS_DENIED); \
1945 action; \
1946 } else { \
1947 CHECK_STATUS(status, NT_STATUS_OK); \
1948 } \
1949 } while (0)
1950
1951 #define CHECK_STATUS_FOR_BIT(status, bits, access) do { \
1952 if (NT_STATUS_IS_OK(status)) { \
1953 if (!(granted & access)) {\
1954 ret = false; \
1955 torture_result(tctx, TORTURE_FAIL, "(%s) %s but flags 0x%08X are not granted! granted[0x%08X] desired[0x%08X]\n", \
1956 __location__, nt_errstr(status), access, granted, desired); \
1957 goto done; \
1958 } \
1959 } else { \
1960 if (granted & access) {\
1961 ret = false; \
1962 torture_result(tctx, TORTURE_FAIL, "(%s) %s but flags 0x%08X are granted! granted[0x%08X] desired[0x%08X]\n", \
1963 __location__, nt_errstr(status), access, granted, desired); \
1964 goto done; \
1965 } \
1966 } \
1967 CHECK_STATUS_FOR_BIT_ACTION(status, bits, do {} while (0)); \
1968 } while (0)
1969
1970 #if 0
1971 /* test what access mask is needed for getting and setting security_descriptors */
1972 /* Note: This test was copied from raw/acls.c. */
1973 static bool test_sd_get_set(struct torture_context *tctx, struct smb2_tree *tree)
1974 {
1975 NTSTATUS status;
1976 bool ret = true;
1977 struct smb2_create io;
1978 union smb_fileinfo fi;
1979 union smb_setfileinfo si;
1980 struct security_descriptor *sd;
1981 struct security_descriptor *sd_owner = NULL;
1982 struct security_descriptor *sd_group = NULL;
1983 struct security_descriptor *sd_dacl = NULL;
1984 struct security_descriptor *sd_sacl = NULL;
1985 struct smb2_handle handle;
1986 const char *fname = BASEDIR "\\sd_get_set.txt";
1987 uint64_t desired_64;
1988 uint32_t desired = 0, granted;
1989 int i = 0;
1990 #define NO_BITS_HACK (((uint64_t)1)<<32)
1991 uint64_t open_bits =
1992 SEC_MASK_GENERIC |
1993 SEC_FLAG_SYSTEM_SECURITY |
1994 SEC_FLAG_MAXIMUM_ALLOWED |
1995 SEC_STD_ALL |
1996 SEC_FILE_ALL |
1997 NO_BITS_HACK;
1998 uint64_t get_owner_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
1999 uint64_t set_owner_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_OWNER;
2000 uint64_t get_group_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
2001 uint64_t set_group_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_OWNER;
2002 uint64_t get_dacl_bits = SEC_MASK_GENERIC | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_READ_CONTROL;
2003 uint64_t set_dacl_bits = SEC_GENERIC_ALL | SEC_FLAG_MAXIMUM_ALLOWED | SEC_STD_WRITE_DAC;
2004 uint64_t get_sacl_bits = SEC_FLAG_SYSTEM_SECURITY;
2005 uint64_t set_sacl_bits = SEC_FLAG_SYSTEM_SECURITY;
2006
2007 if (!smb2_util_setup_dir(tctx, tree, BASEDIR))
2008 return false;
2009
2010 torture_comment(tctx, "TESTING ACCESS MASKS FOR SD GET/SET\n");
2011
2012 /* first create a file with full access for everyone */
2013 sd = security_descriptor_dacl_create(tctx,
2014 0, SID_NT_ANONYMOUS, SID_BUILTIN_USERS,
2015 SID_WORLD,
2016 SEC_ACE_TYPE_ACCESS_ALLOWED,
2017 SEC_GENERIC_ALL,
2018 0,
2019 NULL);
2020 sd->type |= SEC_DESC_SACL_PRESENT;
2021 sd->sacl = NULL;
2022 ZERO_STRUCT(io);
2023 io.level = RAW_OPEN_SMB2;
2024 io.in.create_flags = 0;
2025 io.in.desired_access = SEC_GENERIC_ALL;
2026 io.in.create_options = 0;
2027 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
2028 io.in.share_access = NTCREATEX_SHARE_ACCESS_READ | NTCREATEX_SHARE_ACCESS_WRITE;
2029 io.in.alloc_size = 0;
2030 io.in.create_disposition = NTCREATEX_DISP_OVERWRITE_IF;
2031 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
2032 io.in.security_flags = 0;
2033 io.in.fname = fname;
2034 io.in.sec_desc = sd;
2035 status = smb2_create(tree, tctx, &io);
2036 CHECK_STATUS(status, NT_STATUS_OK);
2037 handle = io.out.file.handle;
2038
2039 status = smb2_util_close(tree, handle);
2040 CHECK_STATUS(status, NT_STATUS_OK);
2041
2042 /*
2043 * now try each access_mask bit and no bit at all in a loop
2044 * and see what's allowed
2045 * NOTE: if i == 32 it means access_mask = 0 (see NO_BITS_HACK above)
2046 */
2047 for (i=0; i <= 32; i++) {
2048 desired_64 = ((uint64_t)1) << i;
2049 desired = (uint32_t)desired_64;
2050
2051 /* first open the file with the desired access */
2052 io.level = RAW_OPEN_SMB2;
2053 io.in.desired_access = desired;
2054 io.in.create_disposition = NTCREATEX_DISP_OPEN;
2055 status = smb2_create(tree, tctx, &io);
2056 CHECK_STATUS_FOR_BIT_ACTION(status, open_bits, goto next);
2057 handle = io.out.file.handle;
2058
2059 /* then check what access was granted */
2060 fi.access_information.level = RAW_FILEINFO_ACCESS_INFORMATION;
2061 fi.access_information.in.file.handle = handle;
2062 status = smb2_getinfo_file(tree, tctx, &fi);
2063 CHECK_STATUS(status, NT_STATUS_OK);
2064 granted = fi.access_information.out.access_flags;
2065
2066 /* test the owner */
2067 ZERO_STRUCT(fi);
2068 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2069 fi.query_secdesc.in.file.handle = handle;
2070 fi.query_secdesc.in.secinfo_flags = SECINFO_OWNER;
2071 status = smb2_getinfo_file(tree, tctx, &fi);
2072 CHECK_STATUS_FOR_BIT(status, get_owner_bits, SEC_STD_READ_CONTROL);
2073 if (fi.query_secdesc.out.sd) {
2074 sd_owner = fi.query_secdesc.out.sd;
2075 } else if (!sd_owner) {
2076 sd_owner = sd;
2077 }
2078 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2079 si.set_secdesc.in.file.handle = handle;
2080 si.set_secdesc.in.secinfo_flags = SECINFO_OWNER;
2081 si.set_secdesc.in.sd = sd_owner;
2082 status = smb2_setinfo_file(tree, &si);
2083 CHECK_STATUS_FOR_BIT(status, set_owner_bits, SEC_STD_WRITE_OWNER);
2084
2085 /* test the group */
2086 ZERO_STRUCT(fi);
2087 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2088 fi.query_secdesc.in.file.handle = handle;
2089 fi.query_secdesc.in.secinfo_flags = SECINFO_GROUP;
2090 status = smb2_getinfo_file(tree, tctx, &fi);
2091 CHECK_STATUS_FOR_BIT(status, get_group_bits, SEC_STD_READ_CONTROL);
2092 if (fi.query_secdesc.out.sd) {
2093 sd_group = fi.query_secdesc.out.sd;
2094 } else if (!sd_group) {
2095 sd_group = sd;
2096 }
2097 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2098 si.set_secdesc.in.file.handle = handle;
2099 si.set_secdesc.in.secinfo_flags = SECINFO_GROUP;
2100 si.set_secdesc.in.sd = sd_group;
2101 status = smb2_setinfo_file(tree, &si);
2102 CHECK_STATUS_FOR_BIT(status, set_group_bits, SEC_STD_WRITE_OWNER);
2103
2104 /* test the DACL */
2105 ZERO_STRUCT(fi);
2106 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2107 fi.query_secdesc.in.file.handle = handle;
2108 fi.query_secdesc.in.secinfo_flags = SECINFO_DACL;
2109 status = smb2_getinfo_file(tree, tctx, &fi);
2110 CHECK_STATUS_FOR_BIT(status, get_dacl_bits, SEC_STD_READ_CONTROL);
2111 if (fi.query_secdesc.out.sd) {
2112 sd_dacl = fi.query_secdesc.out.sd;
2113 } else if (!sd_dacl) {
2114 sd_dacl = sd;
2115 }
2116 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2117 si.set_secdesc.in.file.handle = handle;
2118 si.set_secdesc.in.secinfo_flags = SECINFO_DACL;
2119 si.set_secdesc.in.sd = sd_dacl;
2120 status = smb2_setinfo_file(tree, &si);
2121 CHECK_STATUS_FOR_BIT(status, set_dacl_bits, SEC_STD_WRITE_DAC);
2122
2123 /* test the SACL */
2124 ZERO_STRUCT(fi);
2125 fi.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2126 fi.query_secdesc.in.file.handle = handle;
2127 fi.query_secdesc.in.secinfo_flags = SECINFO_SACL;
2128 status = smb2_getinfo_file(tree, tctx, &fi);
2129 CHECK_STATUS_FOR_BIT(status, get_sacl_bits, SEC_FLAG_SYSTEM_SECURITY);
2130 if (fi.query_secdesc.out.sd) {
2131 sd_sacl = fi.query_secdesc.out.sd;
2132 } else if (!sd_sacl) {
2133 sd_sacl = sd;
2134 }
2135 si.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2136 si.set_secdesc.in.file.handle = handle;
2137 si.set_secdesc.in.secinfo_flags = SECINFO_SACL;
2138 si.set_secdesc.in.sd = sd_sacl;
2139 status = smb2_setinfo_file(tree, &si);
2140 CHECK_STATUS_FOR_BIT(status, set_sacl_bits, SEC_FLAG_SYSTEM_SECURITY);
2141
2142 /* close the handle */
2143 status = smb2_util_close(tree, handle);
2144 CHECK_STATUS(status, NT_STATUS_OK);
2145 next:
2146 continue;
2147 }
2148
2149 done:
2150 smb2_util_close(tree, handle);
2151 smb2_util_unlink(tree, fname);
2152 smb2_deltree(tree, BASEDIR);
2153 smb2_tdis(tree);
2154 smb2_logoff(tree->session);
2155
2156 return ret;
2157 }
2158 #endif
2159
2160 static bool test_access_based(struct torture_context *tctx,
2161 struct smb2_tree *tree)
2162 {
2163 struct smb2_tree *tree1 = NULL;
2164 NTSTATUS status;
2165 struct smb2_create io;
2166 const char *fname = BASEDIR "\\testfile";
2167 bool ret = true;
2168 struct smb2_handle fhandle = {{0}};
2169 struct smb2_handle dhandle = {{0}};
2170 union smb_fileinfo q;
2171 union smb_setfileinfo set;
2172 struct security_descriptor *sd, *sd_orig=NULL;
2173 const char *owner_sid;
2174 uint32_t flags = 0;
2175 /*
2176 * Can't test without SEC_STD_READ_CONTROL as we
2177 * own the file and implicitly have SEC_STD_READ_CONTROL.
2178 */
2179 uint32_t access_masks[] = {
2180 /* Full READ access. */
2181 SEC_STD_READ_CONTROL|FILE_READ_DATA|
2182 FILE_READ_ATTRIBUTES|FILE_READ_EA,
2183
2184 /* Missing FILE_READ_EA. */
2185 SEC_STD_READ_CONTROL|FILE_READ_DATA|
2186 FILE_READ_ATTRIBUTES,
2187
2188 /* Missing FILE_READ_ATTRIBUTES. */
2189 SEC_STD_READ_CONTROL|FILE_READ_DATA|
2190 FILE_READ_EA,
2191
2192 /* Missing FILE_READ_DATA. */
2193 SEC_STD_READ_CONTROL|
2194 FILE_READ_ATTRIBUTES|FILE_READ_EA,
2195 };
2196 unsigned int i;
2197 unsigned int count;
2198 struct smb2_find f;
2199 union smb_search_data *d;
2200
2201 ZERO_STRUCT(fhandle);
2202 ZERO_STRUCT(dhandle);
2203
2204 if (TARGET_IS_WINDOWS(tctx)) {
2205 tree1 = tree;
2206 } else {
2207 if (!torture_smb2_con_share(tctx, "hideunread", &tree1)) {
2208 torture_result(tctx, TORTURE_FAIL, "(%s) Unable to connect "
2209 "to share 'hideunread'\n",
2210 __location__);
2211 ret = false;
2212 goto done;
2213 }
2214 }
2215
2216 flags = smb2cli_tcon_flags(tree1->smbXcli);
2217
2218 smb2_util_unlink(tree1, fname);
2219 smb2_deltree(tree1, BASEDIR);
2220
2221 torture_comment(tctx, "TESTING ACCESS BASED ENUMERATION\n");
2222
2223 if (((flags & SMB2_SHAREFLAG_ACCESS_BASED_DIRECTORY_ENUM)==0) &&
2224 (!TARGET_IS_WINDOWS(tctx))) {
2225 torture_result(tctx, TORTURE_FAIL, "(%s) No access enumeration "
2226 "on share 'hideunread'\n",
2227 __location__);
2228 ret = false;
2229 goto done;
2230 }
2231
2232 if (!smb2_util_setup_dir(tctx, tree1, BASEDIR)) {
2233 torture_result(tctx, TORTURE_FAIL, "(%s) Unable to setup %s\n",
2234 __location__, BASEDIR);
2235 ret = false;
2236 goto done;
2237 }
2238
2239 /* Get a handle to the BASEDIR directory. */
2240 status = torture_smb2_testdir(tree1, BASEDIR, &dhandle);
2241 CHECK_STATUS(status, NT_STATUS_OK);
2242 smb2_util_close(tree1, dhandle);
2243 ZERO_STRUCT(dhandle);
2244
2245 ZERO_STRUCT(io);
2246 io.level = RAW_OPEN_SMB2;
2247 io.in.create_flags = 0;
2248 io.in.desired_access = SEC_RIGHTS_FILE_ALL;
2249 io.in.create_options = 0;
2250 io.in.file_attributes = FILE_ATTRIBUTE_NORMAL;
2251 io.in.share_access = 0;
2252 io.in.alloc_size = 0;
2253 io.in.create_disposition = NTCREATEX_DISP_CREATE;
2254 io.in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS;
2255 io.in.security_flags = 0;
2256 io.in.fname = fname;
2257
2258 status = smb2_create(tree1, tctx, &io);
2259 CHECK_STATUS(status, NT_STATUS_OK);
2260 fhandle = io.out.file.handle;
2261
2262 torture_comment(tctx, "get the original sd\n");
2263 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
2264 q.query_secdesc.in.file.handle = fhandle;
2265 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
2266 status = smb2_getinfo_file(tree1, tctx, &q);
2267 CHECK_STATUS(status, NT_STATUS_OK);
2268 sd_orig = q.query_secdesc.out.sd;
2269
2270 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
2271
2272 torture_comment(tctx, "owner_sid is %s\n", owner_sid);
2273
2274 /* Setup for the search. */
2275 ZERO_STRUCT(f);
2276 f.in.pattern = "*";
2277 f.in.continue_flags = SMB2_CONTINUE_FLAG_REOPEN;
2278 f.in.max_response_size = 0x1000;
2279 f.in.level = SMB2_FIND_DIRECTORY_INFO;
2280
2281 for (i = 0; i < ARRAY_SIZE(access_masks); i++) {
2282
2283 sd = security_descriptor_dacl_create(tctx,
2284 0, NULL, NULL,
2285 owner_sid,
2286 SEC_ACE_TYPE_ACCESS_ALLOWED,
2287 access_masks[i]|SEC_STD_SYNCHRONIZE,
2288 0,
2289 NULL);
2290
2291 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
2292 set.set_secdesc.in.file.handle = fhandle;
2293 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
2294 set.set_secdesc.in.sd = sd;
2295 status = smb2_setinfo_file(tree1, &set);
2296 CHECK_STATUS(status, NT_STATUS_OK);
2297
2298 /* Now see if we can see the file in a directory listing. */
2299
2300 /* Re-open dhandle. */
2301 status = torture_smb2_testdir(tree1, BASEDIR, &dhandle);
2302 CHECK_STATUS(status, NT_STATUS_OK);
2303 f.in.file.handle = dhandle;
2304
2305 count = 0;
2306 d = NULL;
2307 status = smb2_find_level(tree1, tree1, &f, &count, &d);
2308 TALLOC_FREE(d);
2309
2310 CHECK_STATUS(status, NT_STATUS_OK);
2311
2312 smb2_util_close(tree1, dhandle);
2313 ZERO_STRUCT(dhandle);
2314
2315 if (i == 0) {
2316 /* We should see the first sd. */
2317 if (count != 3) {
2318 torture_result(tctx, TORTURE_FAIL,
2319 "(%s) Normal SD - Unable "
2320 "to see file %s\n",
2321 __location__,
2322 BASEDIR);
2323 ret = false;
2324 goto done;
2325 }
2326 } else {
2327 /* But no others. */
2328 if (count != 2) {
2329 torture_result(tctx, TORTURE_FAIL,
2330 "(%s) SD 0x%x - can "
2331 "see file %s\n",
2332 __location__,
2333 access_masks[i],
2334 BASEDIR);
2335 ret = false;
2336 goto done;
2337 }
2338 }
2339 }
2340
2341 done:
2342 if (tree1) {
2343 torture_comment(tctx, "put back original sd\n");
2344 restore_sd_orig(tree1, &set, fhandle, sd_orig);
2345 if (!smb2_util_handle_empty(fhandle)) {
2346 smb2_util_close(tree1, fhandle);
2347 }
2348 smb2_util_close(tree1, dhandle);
2349 smb2_util_unlink(tree1, fname);
2350 smb2_deltree(tree1, BASEDIR);
2351 smb2_tdis(tree1);
2352 smb2_logoff(tree1->session);
2353 }
2354
2355 if (tree != tree1) {
2356 smb2_tdis(tree);
2357 smb2_logoff(tree->session);
2358 }
2359
2360 return ret;
2361 }
2362
2363 /*
2364 * test Owner Rights, S-1-3-4
2365 */
2366 static bool test_owner_rights(struct torture_context *tctx,
2367 struct smb2_tree *tree)
2368 {
2369 const char *fname = BASEDIR "\\owner_right.txt";
2370 struct smb2_create cr;
2371 struct smb2_handle handle = {{0}};
2372 union smb_fileinfo gi;
2373 union smb_setfileinfo si;
2374 struct security_descriptor *sd_orig = NULL;
2375 struct security_descriptor *sd = NULL;
2376 const char *owner_sid = NULL;
2377 NTSTATUS mxac_status;
2378 NTSTATUS status;
2379 bool ret = true;
2380
2381 smb2_deltree(tree, BASEDIR);
2382
2383 ret = smb2_util_setup_dir(tctx, tree, BASEDIR);
2384 torture_assert_goto(tctx, ret, ret, done,
2385 "smb2_util_setup_dir failed\n");
2386
2387 torture_comment(tctx, "TESTING OWNER RIGHTS\n");
2388
2389 cr = (struct smb2_create) {
2390 .in.desired_access = SEC_STD_READ_CONTROL |
2391 SEC_STD_WRITE_DAC |SEC_STD_WRITE_OWNER,
2392 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2393 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2394 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2395 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2396 .in.fname = fname,
2397 };
2398
2399 status = smb2_create(tree, tctx, &cr);
2400 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2401 "smb2_create failed\n");
2402 handle = cr.out.file.handle;
2403
2404 torture_comment(tctx, "get the original sd\n");
2405
2406 gi = (union smb_fileinfo) {
2407 .query_secdesc.level = RAW_FILEINFO_SEC_DESC,
2408 .query_secdesc.in.file.handle = handle,
2409 .query_secdesc.in.secinfo_flags = SECINFO_DACL|SECINFO_OWNER,
2410 };
2411
2412 status = smb2_getinfo_file(tree, tctx, &gi);
2413 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2414 "smb2_getinfo_file failed\n");
2415
2416 sd_orig = gi.query_secdesc.out.sd;
2417 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
2418
2419 /*
2420 * Add a 2 element ACL
2421 * SEC_RIGHTS_FILE_READ for the owner,
2422 * SEC_FILE_WRITE_DATA for SID_OWNER_RIGHTS.
2423 *
2424 * Proves that the owner and SID_OWNER_RIGHTS
2425 * ACE entries are additive.
2426 */
2427 sd = security_descriptor_dacl_create(tctx, 0, NULL, NULL,
2428 owner_sid,
2429 SEC_ACE_TYPE_ACCESS_ALLOWED,
2430 SEC_RIGHTS_FILE_READ,
2431 0,
2432 SID_OWNER_RIGHTS,
2433 SEC_ACE_TYPE_ACCESS_ALLOWED,
2434 SEC_FILE_WRITE_DATA,
2435 0,
2436 NULL);
2437 torture_assert_not_null_goto(tctx, sd, ret, done,
2438 "SD create failed\n");
2439
2440 si = (union smb_setfileinfo) {
2441 .set_secdesc.level = RAW_SFILEINFO_SEC_DESC,
2442 .set_secdesc.in.file.handle = handle,
2443 .set_secdesc.in.secinfo_flags = SECINFO_DACL,
2444 .set_secdesc.in.sd = sd,
2445 };
2446
2447 status = smb2_setinfo_file(tree, &si);
2448 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2449 "smb2_setinfo_file failed\n");
2450
2451 status = smb2_util_close(tree, handle);
2452 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2453 "smb2_util_close failed\n");
2454 ZERO_STRUCT(handle);
2455
2456 cr = (struct smb2_create) {
2457 .in.desired_access = SEC_STD_READ_CONTROL,
2458 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2459 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2460 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2461 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2462 .in.query_maximal_access = true,
2463 .in.fname = fname,
2464 };
2465
2466 status = smb2_create(tree, tctx, &cr);
2467 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2468 "smb2_setinfo_file failed\n");
2469 handle = cr.out.file.handle;
2470
2471 mxac_status = NT_STATUS(cr.out.maximal_access_status);
2472 torture_assert_ntstatus_ok_goto(tctx, mxac_status, ret, done,
2473 "smb2_setinfo_file failed\n");
2474
2475 /*
2476 * For some reasons Windows 2016 doesn't set SEC_STD_DELETE but we
2477 * do. Mask it out so the test passes against Samba and Windows.
2478 */
2479 torture_assert_int_equal_goto(tctx,
2480 cr.out.maximal_access & ~SEC_STD_DELETE,
2481 SEC_RIGHTS_FILE_READ |
2482 SEC_FILE_WRITE_DATA,
2483 ret, done,
2484 "Wrong maximum access\n");
2485
2486 status = smb2_util_close(tree, handle);
2487 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2488 "smb2_util_close failed\n");
2489 ZERO_STRUCT(handle);
2490
2491 done:
2492 torture_comment(tctx, "put back original sd\n");
2493 restore_sd_orig(tree, &si, handle, sd_orig);
2494 if (!smb2_util_handle_empty(handle)) {
2495 smb2_util_close(tree, handle);
2496 }
2497 smb2_util_unlink(tree, fname);
2498 smb2_deltree(tree, BASEDIR);
2499 return ret;
2500 }
2501
2502 /*
2503 * test Owner Rights with a leading DENY ACE, S-1-3-4
2504 */
2505 static bool test_owner_rights_deny(struct torture_context *tctx,
2506 struct smb2_tree *tree)
2507 {
2508 const char *fname = BASEDIR "\\owner_right_deny.txt";
2509 struct smb2_create cr;
2510 struct smb2_handle handle = {{0}};
2511 struct smb2_handle handle2 = {{0}};
2512 union smb_fileinfo gi;
2513 union smb_setfileinfo si;
2514 struct security_descriptor *sd_orig = NULL;
2515 struct security_descriptor *sd = NULL;
2516 const char *owner_sid = NULL;
2517 NTSTATUS mxac_status;
2518 NTSTATUS status;
2519 bool ret = true;
2520
2521 smb2_deltree(tree, BASEDIR);
2522
2523 ret = smb2_util_setup_dir(tctx, tree, BASEDIR);
2524 torture_assert_goto(tctx, ret, ret, done,
2525 "smb2_util_setup_dir failed\n");
2526
2527 torture_comment(tctx, "TESTING OWNER RIGHTS DENY\n");
2528
2529 cr = (struct smb2_create) {
2530 .in.desired_access = SEC_STD_READ_CONTROL |
2531 SEC_STD_WRITE_DAC |SEC_STD_WRITE_OWNER,
2532 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2533 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2534 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2535 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2536 .in.fname = fname,
2537 };
2538
2539 status = smb2_create(tree, tctx, &cr);
2540 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2541 "smb2_create failed\n");
2542 handle = cr.out.file.handle;
2543
2544 torture_comment(tctx, "get the original sd\n");
2545
2546 gi = (union smb_fileinfo) {
2547 .query_secdesc.level = RAW_FILEINFO_SEC_DESC,
2548 .query_secdesc.in.file.handle = handle,
2549 .query_secdesc.in.secinfo_flags = SECINFO_DACL|SECINFO_OWNER,
2550 };
2551
2552 status = smb2_getinfo_file(tree, tctx, &gi);
2553 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2554 "smb2_getinfo_file failed\n");
2555
2556 sd_orig = gi.query_secdesc.out.sd;
2557 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
2558
2559 /*
2560 * Add a 2 element ACL
2561 * DENY SEC_FILE_DATA_READ for SID_OWNER_RIGHTS
2562 * SEC_FILE_READ_DATA for the owner.
2563 *
2564 * Proves that the owner and SID_OWNER_RIGHTS
2565 * ACE entries are additive.
2566 */
2567 sd = security_descriptor_dacl_create(tctx, 0, NULL, NULL,
2568 SID_OWNER_RIGHTS,
2569 SEC_ACE_TYPE_ACCESS_DENIED,
2570 SEC_FILE_READ_DATA,
2571 0,
2572 owner_sid,
2573 SEC_ACE_TYPE_ACCESS_ALLOWED,
2574 SEC_RIGHTS_FILE_READ,
2575 0,
2576 NULL);
2577 torture_assert_not_null_goto(tctx, sd, ret, done,
2578 "SD create failed\n");
2579
2580 si = (union smb_setfileinfo) {
2581 .set_secdesc.level = RAW_SFILEINFO_SEC_DESC,
2582 .set_secdesc.in.file.handle = handle,
2583 .set_secdesc.in.secinfo_flags = SECINFO_DACL,
2584 .set_secdesc.in.sd = sd,
2585 };
2586
2587 status = smb2_setinfo_file(tree, &si);
2588 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2589 "smb2_setinfo_file failed\n");
2590
2591 cr = (struct smb2_create) {
2592 .in.desired_access = SEC_STD_READ_CONTROL,
2593 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2594 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2595 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2596 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2597 .in.query_maximal_access = true,
2598 .in.fname = fname,
2599 };
2600
2601 status = smb2_create(tree, tctx, &cr);
2602 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2603 "smb2_create failed\n");
2604 handle2 = cr.out.file.handle;
2605
2606 mxac_status = NT_STATUS(cr.out.maximal_access_status);
2607 torture_assert_ntstatus_ok_goto(tctx, mxac_status, ret, done,
2608 "Invalid maximal access status\n");
2609
2610 /*
2611 * For some reasons Windows 2016 doesn't set SEC_STD_DELETE but we
2612 * do. Mask it out so the test passes against Samba and Windows.
2613 */
2614 torture_assert_int_equal_goto(tctx,
2615 cr.out.maximal_access & ~SEC_STD_DELETE,
2616 SEC_RIGHTS_FILE_READ & ~SEC_FILE_READ_DATA,
2617 ret, done,
2618 "Wrong maximum access\n");
2619
2620 status = smb2_util_close(tree, handle2);
2621 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2622 "smb2_util_close failed\n");
2623 ZERO_STRUCT(handle2);
2624
2625 done:
2626 torture_comment(tctx, "put back original sd\n");
2627 restore_sd_orig(tree, &si, handle, sd_orig);
2628
2629 if (!smb2_util_handle_empty(handle2)) {
2630 smb2_util_close(tree, handle2);
2631 }
2632
2633 if (!smb2_util_handle_empty(handle)) {
2634 smb2_util_close(tree, handle);
2635 }
2636 smb2_util_unlink(tree, fname);
2637 smb2_deltree(tree, BASEDIR);
2638 return ret;
2639 }
2640
2641 /*
2642 * test Owner Rights with a trailing DENY ACE, S-1-3-4
2643 */
2644 static bool test_owner_rights_deny1(struct torture_context *tctx,
2645 struct smb2_tree *tree)
2646 {
2647 const char *fname = BASEDIR "\\owner_right_deny1.txt";
2648 struct smb2_create cr;
2649 struct smb2_handle handle = {{0}};
2650 struct smb2_handle handle2 = {{0}};
2651 union smb_fileinfo gi;
2652 union smb_setfileinfo si;
2653 struct security_descriptor *sd_orig = NULL;
2654 struct security_descriptor *sd = NULL;
2655 const char *owner_sid = NULL;
2656 NTSTATUS mxac_status;
2657 NTSTATUS status;
2658 bool ret = true;
2659
2660 smb2_deltree(tree, BASEDIR);
2661
2662 ret = smb2_util_setup_dir(tctx, tree, BASEDIR);
2663 torture_assert_goto(tctx, ret, ret, done,
2664 "smb2_util_setup_dir failed\n");
2665
2666 torture_comment(tctx, "TESTING OWNER RIGHTS DENY1\n");
2667
2668 cr = (struct smb2_create) {
2669 .in.desired_access = SEC_STD_READ_CONTROL |
2670 SEC_STD_WRITE_DAC |SEC_STD_WRITE_OWNER,
2671 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2672 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2673 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2674 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2675 .in.fname = fname,
2676 };
2677
2678 status = smb2_create(tree, tctx, &cr);
2679 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2680 "smb2_create failed\n");
2681 handle = cr.out.file.handle;
2682
2683 torture_comment(tctx, "get the original sd\n");
2684
2685 gi = (union smb_fileinfo) {
2686 .query_secdesc.level = RAW_FILEINFO_SEC_DESC,
2687 .query_secdesc.in.file.handle = handle,
2688 .query_secdesc.in.secinfo_flags = SECINFO_DACL|SECINFO_OWNER,
2689 };
2690
2691 status = smb2_getinfo_file(tree, tctx, &gi);
2692 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2693 "smb2_getinfo_file failed\n");
2694
2695 sd_orig = gi.query_secdesc.out.sd;
2696 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
2697
2698 /*
2699 * Add a 3 element ACL
2700 *
2701 * SEC_RIGHTS_FILE_READ allow for owner.
2702 * SEC_FILE_WRITE_DATA allow for SID-OWNER-RIGHTS.
2703 * SEC_FILE_WRITE_DATA|SEC_FILE_READ_DATA) deny for SID-OWNER-RIGHTS.
2704 *
2705 * Shows on Windows that trailing DENY entries don't
2706 * override granted permissions in max access calculations.
2707 */
2708 sd = security_descriptor_dacl_create(tctx, 0, NULL, NULL,
2709 owner_sid,
2710 SEC_ACE_TYPE_ACCESS_ALLOWED,
2711 SEC_RIGHTS_FILE_READ,
2712 0,
2713 SID_OWNER_RIGHTS,
2714 SEC_ACE_TYPE_ACCESS_ALLOWED,
2715 SEC_FILE_WRITE_DATA,
2716 0,
2717 SID_OWNER_RIGHTS,
2718 SEC_ACE_TYPE_ACCESS_DENIED,
2719 (SEC_FILE_WRITE_DATA|
2720 SEC_FILE_READ_DATA),
2721 0,
2722 NULL);
2723 torture_assert_not_null_goto(tctx, sd, ret, done,
2724 "SD create failed\n");
2725
2726 si = (union smb_setfileinfo) {
2727 .set_secdesc.level = RAW_SFILEINFO_SEC_DESC,
2728 .set_secdesc.in.file.handle = handle,
2729 .set_secdesc.in.secinfo_flags = SECINFO_DACL,
2730 .set_secdesc.in.sd = sd,
2731 };
2732
2733 status = smb2_setinfo_file(tree, &si);
2734 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2735 "smb2_setinfo_file failed\n");
2736
2737 cr = (struct smb2_create) {
2738 .in.desired_access = SEC_STD_READ_CONTROL,
2739 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2740 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2741 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2742 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2743 .in.query_maximal_access = true,
2744 .in.fname = fname,
2745 };
2746
2747 status = smb2_create(tree, tctx, &cr);
2748 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2749 "smb2_create failed\n");
2750 handle2 = cr.out.file.handle;
2751
2752 mxac_status = NT_STATUS(cr.out.maximal_access_status);
2753 torture_assert_ntstatus_ok_goto(tctx, mxac_status, ret, done,
2754 "Invalid maximal access status\n");
2755
2756 /*
2757 * For some reasons Windows 2016 doesn't set SEC_STD_DELETE but we
2758 * do. Mask it out so the test passes against Samba and Windows.
2759 */
2760 torture_assert_int_equal_goto(tctx,
2761 cr.out.maximal_access & ~SEC_STD_DELETE,
2762 SEC_RIGHTS_FILE_READ | SEC_FILE_WRITE_DATA,
2763 ret, done,
2764 "Wrong maximum access\n");
2765
2766 status = smb2_util_close(tree, handle2);
2767 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2768 "smb2_util_close failed\n");
2769 ZERO_STRUCT(handle2);
2770
2771 done:
2772 torture_comment(tctx, "put back original sd\n");
2773 restore_sd_orig(tree, &si, handle, sd_orig);
2774
2775 if (!smb2_util_handle_empty(handle2)) {
2776 smb2_util_close(tree, handle2);
2777 }
2778
2779 if (!smb2_util_handle_empty(handle)) {
2780 smb2_util_close(tree, handle);
2781 }
2782 smb2_util_unlink(tree, fname);
2783 smb2_deltree(tree, BASEDIR);
2784 return ret;
2785 }
2786
2787 /*
2788 * test that shows that a DENY ACE doesn't remove rights granted
2789 * by a previous ALLOW ACE.
2790 */
2791 static bool test_deny1(struct torture_context *tctx,
2792 struct smb2_tree *tree)
2793 {
2794 const char *fname = BASEDIR "\\test_deny1.txt";
2795 struct smb2_create cr;
2796 struct smb2_handle handle = {{0}};
2797 struct smb2_handle handle2 = {{0}};
2798 union smb_fileinfo gi;
2799 union smb_setfileinfo si;
2800 struct security_descriptor *sd_orig = NULL;
2801 struct security_descriptor *sd = NULL;
2802 const char *owner_sid = NULL;
2803 NTSTATUS mxac_status;
2804 NTSTATUS status;
2805 bool ret = true;
2806
2807 smb2_deltree(tree, BASEDIR);
2808
2809 ret = smb2_util_setup_dir(tctx, tree, BASEDIR);
2810 torture_assert_goto(tctx, ret, ret, done,
2811 "smb2_util_setup_dir failed\n");
2812
2813 cr = (struct smb2_create) {
2814 .in.desired_access = SEC_STD_READ_CONTROL |
2815 SEC_STD_WRITE_DAC |SEC_STD_WRITE_OWNER,
2816 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2817 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2818 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2819 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2820 .in.fname = fname,
2821 };
2822
2823 status = smb2_create(tree, tctx, &cr);
2824 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2825 "smb2_create failed\n");
2826 handle = cr.out.file.handle;
2827
2828 torture_comment(tctx, "get the original sd\n");
2829
2830 gi = (union smb_fileinfo) {
2831 .query_secdesc.level = RAW_FILEINFO_SEC_DESC,
2832 .query_secdesc.in.file.handle = handle,
2833 .query_secdesc.in.secinfo_flags = SECINFO_DACL|SECINFO_OWNER,
2834 };
2835
2836 status = smb2_getinfo_file(tree, tctx, &gi);
2837 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2838 "smb2_getinfo_file failed\n");
2839
2840 sd_orig = gi.query_secdesc.out.sd;
2841 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
2842
2843 /*
2844 * Add a 2 element ACL
2845 *
2846 * SEC_RIGHTS_FILE_READ|SEC_FILE_WRITE_DATA allow for owner.
2847 * SEC_FILE_WRITE_DATA deny for owner
2848 *
2849 * Shows on Windows that trailing DENY entries don't
2850 * override granted permissions.
2851 */
2852 sd = security_descriptor_dacl_create(tctx, 0, NULL, NULL,
2853 owner_sid,
2854 SEC_ACE_TYPE_ACCESS_ALLOWED,
2855 SEC_RIGHTS_FILE_READ|SEC_FILE_WRITE_DATA,
2856 0,
2857 owner_sid,
2858 SEC_ACE_TYPE_ACCESS_DENIED,
2859 SEC_FILE_WRITE_DATA,
2860 0,
2861 NULL);
2862 torture_assert_not_null_goto(tctx, sd, ret, done,
2863 "SD create failed\n");
2864
2865 si = (union smb_setfileinfo) {
2866 .set_secdesc.level = RAW_SFILEINFO_SEC_DESC,
2867 .set_secdesc.in.file.handle = handle,
2868 .set_secdesc.in.secinfo_flags = SECINFO_DACL,
2869 .set_secdesc.in.sd = sd,
2870 };
2871
2872 status = smb2_setinfo_file(tree, &si);
2873 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2874 "smb2_setinfo_file failed\n");
2875
2876
2877 cr = (struct smb2_create) {
2878 .in.desired_access = SEC_STD_READ_CONTROL | SEC_FILE_WRITE_DATA,
2879 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2880 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2881 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2882 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2883 .in.query_maximal_access = true,
2884 .in.fname = fname,
2885 };
2886
2887 status = smb2_create(tree, tctx, &cr);
2888 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2889 "smb2_create failed\n");
2890 handle2 = cr.out.file.handle;
2891
2892 mxac_status = NT_STATUS(cr.out.maximal_access_status);
2893 torture_assert_ntstatus_ok_goto(tctx, mxac_status, ret, done,
2894 "Wrong maximum access status\n");
2895
2896 /*
2897 * For some reasons Windows 2016 doesn't set SEC_STD_DELETE but we
2898 * do. Mask it out so the test passes against Samba and Windows.
2899 * SEC_STD_WRITE_DAC comes from being the owner.
2900 */
2901 torture_assert_int_equal_goto(tctx,
2902 cr.out.maximal_access & ~SEC_STD_DELETE,
2903 SEC_RIGHTS_FILE_READ |
2904 SEC_FILE_WRITE_DATA |
2905 SEC_STD_WRITE_DAC,
2906 ret, done,
2907 "Wrong maximum access\n");
2908
2909 status = smb2_util_close(tree, handle2);
2910 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2911 "smb2_util_close failed\n");
2912 ZERO_STRUCT(handle2);
2913
2914 done:
2915 torture_comment(tctx, "put back original sd\n");
2916 restore_sd_orig(tree, &si, handle, sd_orig);
2917 if (!smb2_util_handle_empty(handle)) {
2918 smb2_util_close(tree, handle);
2919 }
2920
2921 if (!smb2_util_handle_empty(handle2)) {
2922 smb2_util_close(tree, handle2);
2923 }
2924 smb2_util_unlink(tree, fname);
2925 smb2_deltree(tree, BASEDIR);
2926 return ret;
2927 }
2928
2929 /*
2930 * test SEC_FLAG_MAXIMUM_ALLOWED with not-granted access
2931 *
2932 * When access_mask contains SEC_FLAG_MAXIMUM_ALLOWED, the server must still
2933 * process other bits from access_mask. Eg if access_mask contains a right that
2934 * the requester doesn't have, the function must validate that against the
2935 * effective permissions.
2936 */
2937 static bool test_mxac_not_granted(struct torture_context *tctx,
2938 struct smb2_tree *tree)
2939 {
2940 const char *fname = BASEDIR "\\test_mxac_not_granted.txt";
2941 struct smb2_create cr;
2942 struct smb2_handle handle = {{0}};
2943 struct smb2_handle handle2 = {{0}};
2944 union smb_fileinfo gi;
2945 union smb_setfileinfo si;
2946 struct security_descriptor *sd_orig = NULL;
2947 struct security_descriptor *sd = NULL;
2948 const char *owner_sid = NULL;
2949 NTSTATUS status;
2950 bool ret = true;
2951
2952 smb2_deltree(tree, BASEDIR);
2953
2954 ret = smb2_util_setup_dir(tctx, tree, BASEDIR);
2955 torture_assert_goto(tctx, ret, ret, done,
2956 "smb2_util_setup_dir failed\n");
2957
2958 torture_comment(tctx, "TESTING OWNER RIGHTS DENY\n");
2959
2960 cr = (struct smb2_create) {
2961 .in.desired_access = SEC_STD_READ_CONTROL |
2962 SEC_STD_WRITE_DAC |SEC_STD_WRITE_OWNER,
2963 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
2964 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
2965 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
2966 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
2967 .in.fname = fname,
2968 };
2969
2970 status = smb2_create(tree, tctx, &cr);
2971 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2972 "smb2_create failed\n");
2973 handle = cr.out.file.handle;
2974
2975 torture_comment(tctx, "get the original sd\n");
2976
2977 gi = (union smb_fileinfo) {
2978 .query_secdesc.level = RAW_FILEINFO_SEC_DESC,
2979 .query_secdesc.in.file.handle = handle,
2980 .query_secdesc.in.secinfo_flags = SECINFO_DACL|SECINFO_OWNER,
2981 };
2982
2983 status = smb2_getinfo_file(tree, tctx, &gi);
2984 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
2985 "smb2_getinfo_file failed\n");
2986
2987 sd_orig = gi.query_secdesc.out.sd;
2988 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
2989
2990 sd = security_descriptor_dacl_create(tctx, 0, NULL, NULL,
2991 owner_sid,
2992 SEC_ACE_TYPE_ACCESS_ALLOWED,
2993 SEC_FILE_READ_DATA,
2994 0,
2995 NULL);
2996 torture_assert_not_null_goto(tctx, sd, ret, done,
2997 "SD create failed\n");
2998
2999 si = (union smb_setfileinfo) {
3000 .set_secdesc.level = RAW_SFILEINFO_SEC_DESC,
3001 .set_secdesc.in.file.handle = handle,
3002 .set_secdesc.in.secinfo_flags = SECINFO_DACL,
3003 .set_secdesc.in.sd = sd,
3004 };
3005
3006 status = smb2_setinfo_file(tree, &si);
3007 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3008 "smb2_setinfo_file failed\n");
3009
3010 cr = (struct smb2_create) {
3011 .in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED |
3012 SEC_FILE_WRITE_DATA,
3013 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3014 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
3015 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
3016 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3017 .in.fname = fname,
3018 };
3019
3020 status = smb2_create(tree, tctx, &cr);
3021 torture_assert_ntstatus_equal_goto(tctx, status,
3022 NT_STATUS_ACCESS_DENIED,
3023 ret, done,
3024 "Wrong smb2_create result\n");
3025
3026 done:
3027 torture_comment(tctx, "put back original sd\n");
3028 restore_sd_orig(tree, &si, handle, sd_orig);
3029
3030 if (!smb2_util_handle_empty(handle2)) {
3031 smb2_util_close(tree, handle2);
3032 }
3033
3034 if (!smb2_util_handle_empty(handle)) {
3035 smb2_util_close(tree, handle);
3036 }
3037 smb2_util_unlink(tree, fname);
3038 smb2_deltree(tree, BASEDIR);
3039 return ret;
3040 }
3041
3042 static bool test_overwrite_read_only_file(struct torture_context *tctx,
3043 struct smb2_tree *tree)
3044 {
3045 NTSTATUS status;
3046 struct smb2_create c = {};
3047 struct smb2_create c2 = {};
3048 const char *fname = BASEDIR "\\test_overwrite_read_only_file.txt";
3049 struct smb2_handle handle = {{0}};
3050 struct smb2_handle h2 = {{0}};
3051 struct smb2_handle h3 = {{0}};
3052 union smb_fileinfo q;
3053 union smb_setfileinfo set;
3054 struct security_descriptor *sd = NULL, *sd_orig = NULL;
3055 const char *owner_sid = NULL;
3056 int i;
3057 bool ret = true;
3058
3059 struct tcase {
3060 int disposition;
3061 const char *disposition_string;
3062 NTSTATUS expected_status;
3063 };
3064
3065 #define TCASE(d, s) { \
3066 .disposition = d, \
3067 .disposition_string = #d, \
3068 .expected_status = s, \
3069 }
3070
3071 struct tcase fs_tcases[] = {
3072 TCASE(NTCREATEX_DISP_OPEN, NT_STATUS_OK),
3073 TCASE(NTCREATEX_DISP_SUPERSEDE, NT_STATUS_ACCESS_DENIED),
3074 TCASE(NTCREATEX_DISP_OVERWRITE, NT_STATUS_ACCESS_DENIED),
3075 TCASE(NTCREATEX_DISP_OVERWRITE_IF, NT_STATUS_ACCESS_DENIED),
3076 };
3077
3078 struct tcase sharing_tcases[] = {
3079 TCASE(NTCREATEX_DISP_SUPERSEDE, NT_STATUS_SHARING_VIOLATION),
3080 TCASE(NTCREATEX_DISP_OVERWRITE, NT_STATUS_SHARING_VIOLATION),
3081 TCASE(NTCREATEX_DISP_OVERWRITE_IF, NT_STATUS_SHARING_VIOLATION),
3082 };
3083 #undef TCASE
3084
3085 ret = smb2_util_setup_dir(tctx, tree, BASEDIR);
3086 torture_assert_goto(tctx, ret, ret, done, "smb2_util_setup_dir not ok");
3087
3088 c = (struct smb2_create) {
3089 .in.desired_access = SEC_STD_READ_CONTROL |
3090 SEC_STD_WRITE_DAC |
3091 SEC_STD_WRITE_OWNER,
3092 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3093 .in.share_access = NTCREATEX_SHARE_ACCESS_READ |
3094 NTCREATEX_SHARE_ACCESS_WRITE,
3095 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
3096 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3097 .in.fname = fname,
3098 };
3099
3100 status = smb2_create(tree, tctx, &c);
3101 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3102 "smb2_create failed\n");
3103 handle = c.out.file.handle;
3104
3105 torture_comment(tctx, "get the original sd\n");
3106
3107 ZERO_STRUCT(q);
3108 q.query_secdesc.level = RAW_FILEINFO_SEC_DESC;
3109 q.query_secdesc.in.file.handle = handle;
3110 q.query_secdesc.in.secinfo_flags = SECINFO_DACL | SECINFO_OWNER;
3111
3112 status = smb2_getinfo_file(tree, tctx, &q);
3113 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3114 "smb2_getinfo_file failed\n");
3115 sd_orig = q.query_secdesc.out.sd;
3116
3117 owner_sid = dom_sid_string(tctx, sd_orig->owner_sid);
3118
3119 sd = security_descriptor_dacl_create(tctx,
3120 0, NULL, NULL,
3121 owner_sid,
3122 SEC_ACE_TYPE_ACCESS_ALLOWED,
3123 SEC_FILE_READ_DATA,
3124 0,
3125 NULL);
3126
3127 ZERO_STRUCT(set);
3128 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
3129 set.set_secdesc.in.file.handle = handle;
3130 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
3131 set.set_secdesc.in.sd = sd;
3132
3133 status = smb2_setinfo_file(tree, &set);
3134 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3135 "smb2_setinfo_file failed\n");
3136
3137 for (i = 0; i < ARRAY_SIZE(fs_tcases); i++) {
3138 torture_comment(tctx, "Verify open with %s disposition\n",
3139 fs_tcases[i].disposition_string);
3140
3141 c = (struct smb2_create) {
3142 .in.create_disposition = fs_tcases[i].disposition,
3143 .in.desired_access = SEC_FILE_READ_DATA,
3144 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3145 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
3146 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3147 .in.fname = fname,
3148 };
3149
3150 status = smb2_create(tree, tctx, &c);
3151 smb2_util_close(tree, c.out.file.handle);
3152 torture_assert_ntstatus_equal_goto(
3153 tctx, status, fs_tcases[i].expected_status, ret, done,
3154 "smb2_create failed\n");
3155 };
3156
3157 torture_comment(tctx, "put back original sd\n");
3158
3159 c = (struct smb2_create) {
3160 .in.desired_access = SEC_STD_WRITE_DAC,
3161 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3162 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
3163 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
3164 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3165 .in.fname = fname,
3166 };
3167
3168 status = smb2_create(tree, tctx, &c);
3169 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3170 "smb2_create failed\n");
3171 h2 = c.out.file.handle;
3172
3173 ZERO_STRUCT(set);
3174 set.set_secdesc.level = RAW_SFILEINFO_SEC_DESC;
3175 set.set_secdesc.in.file.handle = h2;
3176 set.set_secdesc.in.secinfo_flags = SECINFO_DACL;
3177 set.set_secdesc.in.sd = sd_orig;
3178
3179 status = smb2_setinfo_file(tree, &set);
3180 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3181 "smb2_setinfo_file failed\n");
3182
3183 status = smb2_util_close(tree, h2);
3184 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3185 "smb2_util_close failed\n");
3186 ZERO_STRUCT(h2);
3187
3188 for (i = 0; i < ARRAY_SIZE(sharing_tcases); i++) {
3189 struct tcase *tcase = &sharing_tcases[i];
3190
3191 torture_comment(tctx, "Verify %s disposition\n",
3192 tcase->disposition_string);
3193
3194 torture_comment(tctx, "Read-nonly open file with SHARE_READ\n");
3195
3196 c = (struct smb2_create) {
3197 .in.desired_access = SEC_FILE_READ_DATA,
3198 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3199 .in.share_access = NTCREATEX_SHARE_ACCESS_READ,
3200 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
3201 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3202 .in.fname = fname,
3203 };
3204
3205 status = smb2_create(tree, tctx, &c);
3206 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3207 "smb2_create failed\n");
3208 h2 = c.out.file.handle;
3209
3210 torture_comment(tctx, "A second open with %s must return %s\n",
3211 tcase->disposition_string, nt_errstr(tcase->expected_status));
3212
3213 c2 = (struct smb2_create) {
3214 .in.desired_access = SEC_FILE_READ_DATA,
3215 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3216 .in.share_access = NTCREATEX_SHARE_ACCESS_READ,
3217 .in.create_disposition = tcase->disposition,
3218 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3219 .in.fname = fname,
3220 };
3221
3222 status = smb2_create(tree, tctx, &c2);
3223 torture_assert_ntstatus_equal_goto(tctx, status,
3224 tcase->expected_status,
3225 ret, done,
3226 "Wrong status code\n");
3227
3228 status = smb2_util_close(tree, h2);
3229 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3230 "smb2_util_close failed\n");
3231 ZERO_STRUCT(h2);
3232
3233 torture_comment(tctx, "First open with %s\n",
3234 tcase->disposition_string);
3235
3236 c = (struct smb2_create) {
3237 .in.desired_access = SEC_FILE_READ_DATA,
3238 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3239 .in.share_access = NTCREATEX_SHARE_ACCESS_READ,
3240 .in.create_disposition = tcase->disposition,
3241 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3242 .in.fname = fname,
3243 };
3244
3245 status = smb2_create(tree, tctx, &c);
3246 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3247 "smb2_create failed\n");
3248 h2 = c.out.file.handle;
3249
3250 torture_comment(tctx, "A second read-only open with SHARE_READ "
3251 "must work\n");
3252
3253 c = (struct smb2_create) {
3254 .in.desired_access = SEC_FILE_READ_DATA,
3255 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3256 .in.share_access = NTCREATEX_SHARE_ACCESS_READ,
3257 .in.create_disposition = NTCREATEX_DISP_OPEN,
3258 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3259 .in.fname = fname,
3260 };
3261
3262 status = smb2_create(tree, tctx, &c);
3263 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3264 "smb2_create failed\n");
3265 h3 = c.out.file.handle;
3266
3267 status = smb2_util_close(tree, h2);
3268 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3269 "smb2_util_close failed\n");
3270 ZERO_STRUCT(h2);
3271
3272 status = smb2_util_close(tree, h3);
3273 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3274 "smb2_util_close failed\n");
3275 ZERO_STRUCT(h3);
3276 }
3277
3278 done:
3279 torture_comment(tctx, "put back original sd\n");
3280 restore_sd_orig(tree, &set, handle, sd_orig);
3281 if (!smb2_util_handle_empty(h2)) {
3282 smb2_util_close(tree, h2);
3283 }
3284 if (!smb2_util_handle_empty(h3)) {
3285 smb2_util_close(tree, h3);
3286 }
3287 if (!smb2_util_handle_empty(handle)) {
3288 smb2_util_close(tree, handle);
3289 }
3290 smb2_util_unlink(tree, fname);
3291 smb2_deltree(tree, BASEDIR);
3292 return ret;
3293 }
3294
3295 /*
3296 basic testing of SMB2 ACLs
3297 */
3298 struct torture_suite *torture_smb2_acls_init(TALLOC_CTX *ctx)
3299 {
3300 struct torture_suite *suite = torture_suite_create(ctx, "acls");
3301
3302 torture_suite_add_1smb2_test(suite, "CREATOR", test_creator_sid);
3303 torture_suite_add_1smb2_test(suite, "GENERIC", test_generic_bits);
3304 torture_suite_add_1smb2_test(suite, "OWNER", test_owner_bits);
3305 torture_suite_add_1smb2_test(suite, "INHERITANCE", test_inheritance);
3306 torture_suite_add_1smb2_test(suite, "INHERITFLAGS", test_inheritance_flags);
3307 torture_suite_add_1smb2_test(suite, "SDFLAGSVSCHOWN", test_sd_flags_vs_chown);
3308 torture_suite_add_1smb2_test(suite, "DYNAMIC", test_inheritance_dynamic);
3309 #if 0
3310 /* XXX This test does not work against XP or Vista. */
3311 torture_suite_add_1smb2_test(suite, "GETSET", test_sd_get_set);
3312 #endif
3313 torture_suite_add_1smb2_test(suite, "ACCESSBASED", test_access_based);
3314 torture_suite_add_1smb2_test(suite, "OWNER-RIGHTS", test_owner_rights);
3315 torture_suite_add_1smb2_test(suite, "OWNER-RIGHTS-DENY",
3316 test_owner_rights_deny);
3317 torture_suite_add_1smb2_test(suite, "OWNER-RIGHTS-DENY1",
3318 test_owner_rights_deny1);
3319 torture_suite_add_1smb2_test(suite, "DENY1",
3320 test_deny1);
3321 torture_suite_add_1smb2_test(suite, "MXAC-NOT-GRANTED",
3322 test_mxac_not_granted);
3323 torture_suite_add_1smb2_test(suite, "OVERWRITE_READ_ONLY_FILE", test_overwrite_read_only_file);
3324
3325 suite->description = talloc_strdup(suite, "SMB2-ACLS tests");
3326
3327 return suite;
3328 }
3329
3330 static bool test_acls_non_canonical_flags(struct torture_context *tctx,
3331 struct smb2_tree *tree)
3332 {
3333 const char *fname = BASEDIR "\\test_acls_non_canonical_flags.txt";
3334 struct smb2_create cr;
3335 struct smb2_handle testdirh = {{0}};
3336 struct smb2_handle handle = {{0}};
3337 union smb_fileinfo gi;
3338 union smb_setfileinfo si;
3339 struct security_descriptor *sd_orig = NULL;
3340 struct security_descriptor *sd = NULL;
3341 NTSTATUS status;
3342 bool ret = true;
3343
3344 smb2_deltree(tree, BASEDIR);
3345
3346 status = torture_smb2_testdir(tree, BASEDIR, &testdirh);
3347 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3348 "torture_smb2_testdir failed\n");
3349
3350 sd = security_descriptor_dacl_create(tctx,
3351 SEC_DESC_DACL_AUTO_INHERITED
3352 | SEC_DESC_DACL_AUTO_INHERIT_REQ,
3353 NULL,
3354 NULL,
3355 SID_WORLD,
3356 SEC_ACE_TYPE_ACCESS_ALLOWED,
3357 SEC_RIGHTS_DIR_ALL,
3358 SEC_ACE_FLAG_OBJECT_INHERIT
3359 | SEC_ACE_FLAG_CONTAINER_INHERIT,
3360 NULL);
3361 torture_assert_not_null_goto(tctx, sd, ret, done,
3362 "SD create failed\n");
3363
3364 si = (union smb_setfileinfo) {
3365 .set_secdesc.level = RAW_SFILEINFO_SEC_DESC,
3366 .set_secdesc.in.file.handle = testdirh,
3367 .set_secdesc.in.secinfo_flags = SECINFO_DACL,
3368 .set_secdesc.in.sd = sd,
3369 };
3370
3371 status = smb2_setinfo_file(tree, &si);
3372 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3373 "smb2_setinfo_file failed\n");
3374
3375 gi = (union smb_fileinfo) {
3376 .query_secdesc.level = RAW_FILEINFO_SEC_DESC,
3377 .query_secdesc.in.file.handle = testdirh,
3378 .query_secdesc.in.secinfo_flags = SECINFO_DACL,
3379 };
3380
3381 status = smb2_getinfo_file(tree, tctx, &gi);
3382 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3383 "smb2_getinfo_file failed\n");
3384
3385 cr = (struct smb2_create) {
3386 .in.desired_access = SEC_STD_READ_CONTROL |
3387 SEC_STD_WRITE_DAC,
3388 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3389 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
3390 .in.create_disposition = NTCREATEX_DISP_OPEN_IF,
3391 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3392 .in.fname = fname,
3393 };
3394
3395 status = smb2_create(tree, tctx, &cr);
3396 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3397 "smb2_create failed\n");
3398 handle = cr.out.file.handle;
3399
3400 torture_comment(tctx, "get the original sd\n");
3401
3402 gi = (union smb_fileinfo) {
3403 .query_secdesc.level = RAW_FILEINFO_SEC_DESC,
3404 .query_secdesc.in.file.handle = handle,
3405 .query_secdesc.in.secinfo_flags = SECINFO_DACL,
3406 };
3407
3408 status = smb2_getinfo_file(tree, tctx, &gi);
3409 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3410 "smb2_getinfo_file failed\n");
3411
3412 sd_orig = gi.query_secdesc.out.sd;
3413
3414 torture_assert_goto(tctx, sd_orig->type & SEC_DESC_DACL_AUTO_INHERITED,
3415 ret, done, "Missing SEC_DESC_DACL_AUTO_INHERITED\n");
3416
3417 /*
3418 * SD with SEC_DESC_DACL_AUTO_INHERITED but without
3419 * SEC_DESC_DACL_AUTO_INHERITED_REQ, so the resulting SD should not have
3420 * SEC_DESC_DACL_AUTO_INHERITED on a Windows box.
3421 *
3422 * But as we're testing against a share with
3423 *
3424 * "acl flag inherited canonicalization = no"
3425 *
3426 * the resulting SD should have acl flag inherited canonicalization set.
3427 */
3428 sd = security_descriptor_dacl_create(tctx,
3429 SEC_DESC_DACL_AUTO_INHERITED,
3430 NULL,
3431 NULL,
3432 SID_WORLD,
3433 SEC_ACE_TYPE_ACCESS_ALLOWED,
3434 SEC_FILE_ALL,
3435 0,
3436 NULL);
3437 torture_assert_not_null_goto(tctx, sd, ret, done,
3438 "SD create failed\n");
3439
3440 si = (union smb_setfileinfo) {
3441 .set_secdesc.level = RAW_SFILEINFO_SEC_DESC,
3442 .set_secdesc.in.file.handle = handle,
3443 .set_secdesc.in.secinfo_flags = SECINFO_DACL,
3444 .set_secdesc.in.sd = sd,
3445 };
3446
3447 status = smb2_setinfo_file(tree, &si);
3448 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3449 "smb2_setinfo_file failed\n");
3450
3451 status = smb2_util_close(tree, handle);
3452 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3453 "smb2_util_close failed\n");
3454 ZERO_STRUCT(handle);
3455
3456 cr = (struct smb2_create) {
3457 .in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED ,
3458 .in.file_attributes = FILE_ATTRIBUTE_NORMAL,
3459 .in.share_access = NTCREATEX_SHARE_ACCESS_MASK,
3460 .in.create_disposition = NTCREATEX_DISP_OPEN,
3461 .in.impersonation_level = NTCREATEX_IMPERSONATION_ANONYMOUS,
3462 .in.fname = fname,
3463 };
3464
3465 status = smb2_create(tree, tctx, &cr);
3466 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3467 "smb2_create failed\n");
3468 handle = cr.out.file.handle;
3469
3470 gi = (union smb_fileinfo) {
3471 .query_secdesc.level = RAW_FILEINFO_SEC_DESC,
3472 .query_secdesc.in.file.handle = handle,
3473 .query_secdesc.in.secinfo_flags = SECINFO_DACL,
3474 };
3475
3476 status = smb2_getinfo_file(tree, tctx, &gi);
3477 torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
3478 "smb2_getinfo_file failed\n");
3479
3480 sd_orig = gi.query_secdesc.out.sd;
3481 torture_assert_goto(tctx, sd_orig->type & SEC_DESC_DACL_AUTO_INHERITED,
3482 ret, done, "Missing SEC_DESC_DACL_AUTO_INHERITED\n");
3483
3484 done:
3485 if (!smb2_util_handle_empty(handle)) {
3486 smb2_util_close(tree, testdirh);
3487 }
3488 if (!smb2_util_handle_empty(handle)) {
3489 smb2_util_close(tree, handle);
3490 }
3491 smb2_deltree(tree, BASEDIR);
3492 return ret;
3493 }
3494
3495 struct torture_suite *torture_smb2_acls_non_canonical_init(TALLOC_CTX *ctx)
3496 {
3497 struct torture_suite *suite = torture_suite_create(ctx, "acls_non_canonical");
3498
3499 torture_suite_add_1smb2_test(suite, "flags", test_acls_non_canonical_flags);
3500 return suite;
3501 }