| 1 |
import yaml |
| 2 |
|
| 3 |
from ..check import Check |
| 4 |
|
| 5 |
class CheckHarnessFeatures(Check): |
| 6 |
'''Ensure tests that use harnesses with explicit features flag requirements |
| 7 |
specify only `features` from a list of valid values.''' |
| 8 |
ID = 'HARNESS_FEATURES' |
| 9 |
|
| 10 |
def __init__(self): |
| 11 |
with open('./harness/features.yml', 'r') as f: |
| 12 |
self.include_has_features = yaml.load(f.read()) |
| 13 |
|
| 14 |
def comparison_result_lists(self, meta): |
| 15 |
|
| 16 |
result = {'features': set(), 'missing': set()} |
| 17 |
|
| 18 |
if not meta or 'includes' not in meta: |
| 19 |
return result |
| 20 |
|
| 21 |
meta_features = meta['features'] if 'features' in meta else [] |
| 22 |
meta_includes = meta['includes'] |
| 23 |
features = [] |
| 24 |
|
| 25 |
|
| 26 |
if len(meta_includes) == 0: |
| 27 |
return result |
| 28 |
|
| 29 |
for meta_include in meta_includes: |
| 30 |
if meta_include in self.include_has_features: |
| 31 |
features = self.include_has_features[meta_include] |
| 32 |
|
| 33 |
if len(features) == 0: |
| 34 |
return result |
| 35 |
|
| 36 |
if 'features' not in meta or len(meta['features']) == 0: |
| 37 |
result['missing'].update(features) |
| 38 |
else: |
| 39 |
meta_features = meta['features'] |
| 40 |
|
| 41 |
for feature in features: |
| 42 |
if feature not in meta_features: |
| 43 |
result['missing'].add(feature) |
| 44 |
|
| 45 |
result['features'].update(meta_features); |
| 46 |
|
| 47 |
return result |
| 48 |
|
| 49 |
|
| 50 |
def run(self, name, meta, source): |
| 51 |
|
| 52 |
result = self.comparison_result_lists(meta) |
| 53 |
|
| 54 |
if len(result['features']) == 0 and len(result['missing']) == 0: |
| 55 |
return |
| 56 |
|
| 57 |
if len(result['missing']) > 0: |
| 58 |
if len(result['features']) == 0: |
| 59 |
return 'Missing: `features: [%s]`' % ', '.join(list(result['missing'])) |
| 60 |
else: |
| 61 |
return 'Missing from `features`: %s' % ', '.join(list(result['missing'])) |
| 62 |
else: |
| 63 |
return |