| 1 |
# -*- coding: utf-8 -*- |
| 2 |
# Part of Odoo. See LICENSE file for full copyright and licensing details. |
| 3 |
|
| 4 |
from odoo import Command |
| 5 |
from odoo.tests import Form |
| 6 |
from odoo.addons.sale.tests.common import TestSaleCommon |
| 7 |
from odoo.exceptions import ValidationError |
| 8 |
from odoo.tests.common import tagged |
| 9 |
from psycopg2.errors import NotNullViolation |
| 10 |
|
| 11 |
|
| 12 |
@tagged('post_install', '-at_install') |
| 13 |
class TestSoLineMilestones(TestSaleCommon): |
| 14 |
|
| 15 |
@classmethod |
| 16 |
def setUpClass(cls): |
| 17 |
super().setUpClass() |
| 18 |
cls.env.user.group_ids += cls.quick_ref('project.group_project_manager') |
| 19 |
|
| 20 |
cls.env.user.group_ids += cls.env.ref('project.group_project_milestone') |
| 21 |
uom_hour = cls.env.ref('uom.product_uom_hour') |
| 22 |
|
| 23 |
cls.product_delivery_milestones1 = cls.env['product.product'].create({ |
| 24 |
'name': "Milestones 1, create project only", |
| 25 |
'standard_price': 15, |
| 26 |
'list_price': 30, |
| 27 |
'type': 'service', |
| 28 |
'invoice_policy': 'delivery', |
| 29 |
'uom_id': uom_hour.id, |
| 30 |
'default_code': 'MILE-DELI4', |
| 31 |
'service_type': 'milestones', |
| 32 |
'service_tracking': 'project_only', |
| 33 |
}) |
| 34 |
cls.product_delivery_milestones2 = cls.env['product.product'].create({ |
| 35 |
'name': "Milestones 2, create project only", |
| 36 |
'standard_price':20, |
| 37 |
'list_price': 35, |
| 38 |
'type': 'service', |
| 39 |
'invoice_policy': 'delivery', |
| 40 |
'uom_id': uom_hour.id, |
| 41 |
'default_code': 'MILE-DELI4', |
| 42 |
'service_type': 'milestones', |
| 43 |
'service_tracking': 'project_only', |
| 44 |
}) |
| 45 |
cls.product_delivery_milestones3 = cls.env['product.product'].create({ |
| 46 |
'name': "Milestones 3, create project & task", |
| 47 |
'standard_price': 20, |
| 48 |
'list_price': 35, |
| 49 |
'type': 'service', |
| 50 |
'invoice_policy': 'delivery', |
| 51 |
'uom_id': uom_hour.id, |
| 52 |
'default_code': 'MILE-DELI4', |
| 53 |
'service_type': 'milestones', |
| 54 |
'service_tracking': 'task_in_project', |
| 55 |
}) |
| 56 |
|
| 57 |
cls.sale_order = cls.env['sale.order'].create({ |
| 58 |
'partner_id': cls.partner_a.id, |
| 59 |
'partner_invoice_id': cls.partner_a.id, |
| 60 |
'partner_shipping_id': cls.partner_a.id, |
| 61 |
}) |
| 62 |
cls.sol1 = cls.env['sale.order.line'].create({ |
| 63 |
'product_id': cls.product_delivery_milestones1.id, |
| 64 |
'product_uom_qty': 20, |
| 65 |
'order_id': cls.sale_order.id, |
| 66 |
}) |
| 67 |
cls.sol2 = cls.env['sale.order.line'].create({ |
| 68 |
'product_id': cls.product_delivery_milestones2.id, |
| 69 |
'product_uom_qty': 30, |
| 70 |
'order_id': cls.sale_order.id, |
| 71 |
}) |
| 72 |
cls.sale_order.action_confirm() |
| 73 |
|
| 74 |
cls.project = cls.sol1.project_id |
| 75 |
|
| 76 |
cls.milestone1 = cls.env['project.milestone'].create({ |
| 77 |
'name': 'Milestone 1', |
| 78 |
'project_id': cls.project.id, |
| 79 |
'is_reached': False, |
| 80 |
'sale_line_id': cls.sol1.id, |
| 81 |
'quantity_percentage': 0.5, |
| 82 |
}) |
| 83 |
|
| 84 |
def test_reached_milestones_delivered_quantity(self): |
| 85 |
self.milestone2 = self.env['project.milestone'].create({ |
| 86 |
'name': 'Milestone 2', |
| 87 |
'project_id': self.project.id, |
| 88 |
'is_reached': False, |
| 89 |
'sale_line_id': self.sol2.id, |
| 90 |
'quantity_percentage': 0.2, |
| 91 |
}) |
| 92 |
self.milestone3 = self.env['project.milestone'].create({ |
| 93 |
'name': 'Milestone 3', |
| 94 |
'project_id': self.project.id, |
| 95 |
'is_reached': False, |
| 96 |
'sale_line_id': self.sol2.id, |
| 97 |
'quantity_percentage': 0.4, |
| 98 |
}) |
| 99 |
|
| 100 |
self.assertEqual(self.sol1.qty_delivered, 0.0, "Delivered quantity should start at 0") |
| 101 |
self.assertEqual(self.sol2.qty_delivered, 0.0, "Delivered quantity should start at 0") |
| 102 |
|
| 103 |
self.milestone1.is_reached = True |
| 104 |
self.assertEqual(self.sol1.qty_delivered, 10.0, "Delivered quantity should update after a milestone is reached") |
| 105 |
|
| 106 |
self.milestone2.is_reached = True |
| 107 |
self.assertEqual(self.sol2.qty_delivered, 6.0, "Delivered quantity should update after a milestone is reached") |
| 108 |
|
| 109 |
self.milestone3.is_reached = True |
| 110 |
self.assertEqual(self.sol2.qty_delivered, 18.0, "Delivered quantity should update after a milestone is reached") |
| 111 |
|
| 112 |
def test_update_reached_milestone_quantity(self): |
| 113 |
self.milestone1.is_reached = True |
| 114 |
self.assertEqual(self.sol1.qty_delivered, 10.0, "Delivered quantity should start at 10") |
| 115 |
|
| 116 |
self.milestone1.quantity_percentage = 0.75 |
| 117 |
self.assertEqual(self.sol1.qty_delivered, 15.0, "Delivered quantity should update after a milestone's quantity is updated") |
| 118 |
|
| 119 |
def test_remove_reached_milestone(self): |
| 120 |
self.milestone1.is_reached = True |
| 121 |
self.assertEqual(self.sol1.qty_delivered, 10.0, "Delivered quantity should start at 10") |
| 122 |
|
| 123 |
self.milestone1.unlink() |
| 124 |
self.assertEqual(self.sol1.qty_delivered, 0.0, "Delivered quantity should update when a milestone is removed") |
| 125 |
|
| 126 |
def test_compute_sale_line_in_task(self): |
| 127 |
task = self.env['project.task'].create({ |
| 128 |
'name': 'Test Task', |
| 129 |
'project_id': self.project.id, |
| 130 |
}) |
| 131 |
self.assertEqual(task.sale_line_id, self.sol1, 'The task should have the one of the project linked') |
| 132 |
self.project.sale_line_id = False |
| 133 |
task.sale_line_id = False |
| 134 |
self.assertFalse(task.sale_line_id) |
| 135 |
task.write({'milestone_id': self.milestone1.id}) |
| 136 |
self.assertEqual(task.sale_line_id, self.milestone1.sale_line_id, 'The task should have the SOL from the milestone.') |
| 137 |
self.project.sale_line_id = self.sol2 |
| 138 |
self.assertEqual(task.sale_line_id, self.sol1, 'The task should keep the SOL linked to the milestone.') |
| 139 |
|
| 140 |
def test_default_values_milestone(self): |
| 141 |
""" This test checks that newly created milestones have the correct default values: |
| 142 |
1) the first SOL of the SO linked to the project should be used as the default one. |
| 143 |
2) the quantity percentage should be 100% (1.0 in backend). |
| 144 |
""" |
| 145 |
project = self.env['project.project'].create({ |
| 146 |
'name': 'Test project', |
| 147 |
'sale_line_id': self.sol2.id, # sol1 was created first so we use sol2 to demonstrate that sol1 is used |
| 148 |
}) |
| 149 |
milestone = self.env['project.milestone'].with_context({'default_project_id': project.id}).create({ |
| 150 |
'name': 'Test milestone', |
| 151 |
'project_id': project.id, |
| 152 |
'is_reached': False, |
| 153 |
}) |
| 154 |
# since SOL1 was created before SOL2, it should be selected |
| 155 |
self.assertEqual(milestone.sale_line_id, self.sol1, "The milestone's sale order line should be the first one in the project's SO") #1 |
| 156 |
self.assertEqual(milestone.quantity_percentage, 1.0, "The milestone's quantity percentage should be 1.0") #2 |
| 157 |
|
| 158 |
def test_compute_qty_milestone(self): |
| 159 |
""" This test will check that the compute methods for the milestone quantity fields work properly. """ |
| 160 |
ratio = self.milestone1.quantity_percentage / self.milestone1.product_uom_qty |
| 161 |
self.milestone1.quantity_percentage = 1.0 |
| 162 |
self.assertEqual(self.milestone1.quantity_percentage / self.milestone1.product_uom_qty, ratio, "The ratio should be the same as before") |
| 163 |
self.milestone1.product_uom_qty = 25 |
| 164 |
self.assertEqual(self.milestone1.quantity_percentage / self.milestone1.product_uom_qty, ratio, "The ratio should be the same as before") |
| 165 |
|
| 166 |
def test_create_milestone_on_project_set_on_sales_order(self): |
| 167 |
""" |
| 168 |
Regression Test: |
| 169 |
If we confirm an SO with a service with a delivery based on milestones, |
| 170 |
that creates both a project & task, and we set a project on the SO, |
| 171 |
the project for the milestone should be the one set on the SO, |
| 172 |
and no ValidationError or NotNullViolation should be raised. |
| 173 |
""" |
| 174 |
sale_order = self.env['sale.order'].create({ |
| 175 |
'partner_id': self.partner_a.id, |
| 176 |
'partner_invoice_id': self.partner_a.id, |
| 177 |
'partner_shipping_id': self.partner_a.id, |
| 178 |
}) |
| 179 |
self.env['sale.order.line'].create({ |
| 180 |
'product_id': self.product_delivery_milestones3.id, |
| 181 |
'product_uom_qty': 20, |
| 182 |
'order_id': sale_order.id, |
| 183 |
}) |
| 184 |
try: |
| 185 |
sale_order.action_confirm() |
| 186 |
except (ValidationError, NotNullViolation): |
| 187 |
self.fail("The sale order should be confirmed, " |
| 188 |
"and no ValidationError or NotNullViolation should be raised, " |
| 189 |
"for a missing project on the milestone.") |
| 190 |
|
| 191 |
def test_so_with_milestone_products(self): |
| 192 |
""" |
| 193 |
If a SO contains products invoiced based on milestones, a milestone should be created for each of them |
| 194 |
in their project. |
| 195 |
""" |
| 196 |
sale_order = self.env['sale.order'].create({ |
| 197 |
'partner_id': self.partner_a.id, |
| 198 |
}) |
| 199 |
products = self.product_delivery_milestones1 | self.product_delivery_milestones2 | self.product_delivery_milestones3 |
| 200 |
products.service_tracking = 'task_in_project' |
| 201 |
|
| 202 |
self.env['sale.order.line'].create([{ |
| 203 |
'product_id': product.id, |
| 204 |
'product_uom_qty': 20, |
| 205 |
'order_id': sale_order.id, |
| 206 |
} for product in products]) |
| 207 |
sale_order.action_confirm() |
| 208 |
project = sale_order.project_ids |
| 209 |
self.assertEqual(len(project.milestone_ids), 3, "The project should have a milestone for each product.") |
| 210 |
self.assertCountEqual({m.name for m in project.milestone_ids}, {f"[{products[0].default_code}] {p.name}" for p in products}, "The milestones should be named after the products.") |
| 211 |
|
| 212 |
def test_project_template_with_milestones(self): |
| 213 |
""" |
| 214 |
If a milestone product has a project template with configured milestones, use those instead of creating |
| 215 |
a new milestone and set a quantity equal to the quantity of the SOL divided by the number of milestones. |
| 216 |
""" |
| 217 |
project_template = self.env['project.project'].create({ |
| 218 |
'name': 'Project Template', |
| 219 |
'allow_milestones': True, |
| 220 |
}) |
| 221 |
self.env['project.milestone'].create([{ |
| 222 |
'project_id': project_template.id, |
| 223 |
'name': str(i), |
| 224 |
} for i in range(4)]) |
| 225 |
self.product_delivery_milestones1.project_template_id = project_template.id |
| 226 |
|
| 227 |
sale_order = self.env['sale.order'].create({ |
| 228 |
'partner_id': self.partner_a.id, |
| 229 |
}) |
| 230 |
self.env['sale.order.line'].create({ |
| 231 |
'product_id': self.product_delivery_milestones1.id, |
| 232 |
'product_uom_qty': 20, |
| 233 |
'order_id': sale_order.id, |
| 234 |
}) |
| 235 |
sale_order.action_confirm() |
| 236 |
|
| 237 |
project = sale_order.project_ids |
| 238 |
self.assertEqual(len(project.milestone_ids), 4, "The generated project should have 4 milestones.") |
| 239 |
self.assertEqual({m.quantity_percentage for m in project.milestone_ids}, {0.25}, "All milestones of the generated project should have a quantity percentage of 25%.") |
| 240 |
self.assertTrue(project.allow_milestones, "The project should allow milestones as it was created from a product configured to create milestones.") |
| 241 |
|
| 242 |
def test_project_template_with_milestones_multiple_products(self): |
| 243 |
""" |
| 244 |
If multiple products use the same project template, which has configured milestones, use the first product |
| 245 |
on those milestones, but generate the other default milestones as normal |
| 246 |
""" |
| 247 |
project_template = self.env['project.project'].create({ |
| 248 |
'name': 'Project Template', |
| 249 |
'allow_milestones': True, |
| 250 |
}) |
| 251 |
self.env['project.milestone'].create([{ |
| 252 |
'project_id': project_template.id, |
| 253 |
'name': str(i), |
| 254 |
} for i in range(4)]) |
| 255 |
products = self.product_delivery_milestones1 | self.product_delivery_milestones2 |
| 256 |
products.write({ |
| 257 |
'project_template_id': project_template.id, |
| 258 |
'service_tracking': 'task_in_project', |
| 259 |
}) |
| 260 |
sale_order = self.env['sale.order'].create({ |
| 261 |
'partner_id': self.partner_a.id, |
| 262 |
}) |
| 263 |
self.env['sale.order.line'].create([{ |
| 264 |
'product_id': product.id, |
| 265 |
'product_uom_qty': 20, |
| 266 |
'order_id': sale_order.id, |
| 267 |
} for product in products]) |
| 268 |
sale_order.action_confirm() |
| 269 |
|
| 270 |
project = sale_order.project_ids |
| 271 |
self.assertEqual(len(project.milestone_ids), 5, "The project should have 5 milestones") |
| 272 |
self.assertTrue(project.allow_milestones, "The project should allow milestones as it was created from a product configured to create milestones.") |
| 273 |
|
| 274 |
def test_subtask_milestone_sol(self): |
| 275 |
""" A task should keep its sale line according to its milestone is changed. """ |
| 276 |
# Create a sale order with two milestone lines |
| 277 |
sale_order = self.env['sale.order'].create({ |
| 278 |
'partner_id': self.partner.id, |
| 279 |
'order_line': [ |
| 280 |
Command.create({ |
| 281 |
'product_id': self.product_delivery_milestones3.id, |
| 282 |
'product_uom_qty': 1, |
| 283 |
'name': name, |
| 284 |
}) for name in ["m1", "m2"] |
| 285 |
] |
| 286 |
}) |
| 287 |
sale_order.action_confirm() |
| 288 |
|
| 289 |
# Case 1: parent task is present set SOL according parent's SOL |
| 290 |
parent_task = self.env['project.task'].create({ |
| 291 |
'name': 'Test Task', |
| 292 |
'partner_id': self.partner.id, |
| 293 |
'project_id': sale_order.project_id.id, |
| 294 |
'sale_line_id': self.sol1.id |
| 295 |
}) |
| 296 |
tasks = sale_order.project_id.task_ids |
| 297 |
tasks[0].parent_id = parent_task.id |
| 298 |
with Form(tasks[0]) as task_form: |
| 299 |
task_form.sale_line_id = self.env['sale.order.line'] |
| 300 |
task_form.milestone_id = tasks[1].milestone_id |
| 301 |
self.assertEqual(tasks[0].sale_line_id, |
| 302 |
parent_task.sale_line_id, |
| 303 |
"Task should have the correct sale line based on parent task.") |
| 304 |
|
| 305 |
# Case 2: parent task not present set SOL according Milestone's SOL |
| 306 |
tasks[0].parent_id = False |
| 307 |
with Form(tasks[0]) as task_form: |
| 308 |
task_form.sale_line_id = self.env['sale.order.line'] |
| 309 |
task_form.milestone_id = tasks[0].milestone_id |
| 310 |
self.assertEqual(tasks[0].sale_line_id, |
| 311 |
tasks[0].milestone_id.sale_line_id, |
| 312 |
"Task should have the correct sale line based on milestone.") |
| 313 |
|
| 314 |
# Case 3: parent task and milestone not present set SOL according project's SOL |
| 315 |
with Form(tasks[0]) as task_form: |
| 316 |
task_form.sale_line_id = self.env['sale.order.line'] |
| 317 |
task_form.milestone_id = self.env['project.milestone'] |
| 318 |
self.assertEqual(tasks[0].sale_line_id, |
| 319 |
tasks[0].project_id.sale_line_id, |
| 320 |
"Task should have the correct sale line based on project.") |