| 1 |
From: =?utf-8?b?Ik1hcmNvIFRyZXZpc2FuIChUcmV2acOxbyki?= <[email protected]> |
| 2 |
Date: Tue, 18 Feb 2020 20:27:15 +0100 |
| 3 |
Subject: Skip time-zone tests that fails with system ICU |
| 4 |
|
| 5 |
There have been various changes upstream as part of the revision [1] that |
| 6 |
change the handling of timezones to use ICU all the times when available, |
| 7 |
and by "available" they meant only in the !MOZ_SYSTEM_ICU case, and |
| 8 |
changing the system-ICU code path to fix it, is not trivial. |
| 9 |
|
| 10 |
One of the bugs fixed with this change is this one (TZ dependent): |
| 11 |
|
| 12 |
>>> new Date(1970,0,1,0,0,0,0) |
| 13 |
Thu Jan 01 1970 01:00:00 GMT+0100 (IST) // Expected time 00:00:00 ... |
| 14 |
>>> new Date(1970,0,1,0,0,0,0).getHours() |
| 15 |
1 // Expected 0 |
| 16 |
|
| 17 |
Not being a regression, but an 11-years old (at the date), I think we can |
| 18 |
sadly accept it, until we don't start compile SpiderMonkey to use Mozilla's |
| 19 |
ICU. |
| 20 |
|
| 21 |
[1] https://hg.mozilla.org/mozilla-central/rev/7b1a3a49547d |
| 22 |
|
| 23 |
Forwarded: no |
| 24 |
Bug-Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=487897 |
| 25 |
Bug-Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1346211 |
| 26 |
--- |
| 27 |
js/src/tests/jstests.list | 5 +++++ |
| 28 |
1 file changed, 5 insertions(+) |
| 29 |
|
| 30 |
diff --git a/js/src/tests/jstests.list b/js/src/tests/jstests.list |
| 31 |
index 2cdd969..3120523 100644 |
| 32 |
--- a/js/src/tests/jstests.list |
| 33 |
+++ b/js/src/tests/jstests.list |
| 34 |
@@ -643,6 +643,11 @@ skip script non262/Date/time-zones-imported.js |
| 35 |
# https://bugzilla.mozilla.org/show_bug.cgi?id=1755531 |
| 36 |
skip-if(xulRuntime.debian.DEB_HOST_ARCH_CPU.match(/i386|s390x|arm64|ppc64|riscv64/)) script test262/built-ins/Date/UTC/fp-evaluation-order.js |
| 37 |
|
| 38 |
+# This test fails when using system ICU because the related bug has been fixed only when using local ICU |
| 39 |
+# See https://bugzilla.mozilla.org/show_bug.cgi?id=1346211#c7 |
| 40 |
+# https://hg.mozilla.org/mozilla-central/rev/7b1a3a49547d |
| 41 |
+skip script non262/Date/time-zones-historic.js |
| 42 |
+ |
| 43 |
########################################################### |
| 44 |
# Tests disabled due to issues in test262 importer script # |
| 45 |
########################################################### |