| 1 |
// RUN: %check_clang_tidy %s readability-implicit-bool-conversion %t -- -- -std=c23 |
| 2 |
|
| 3 |
#undef NULL |
| 4 |
#define NULL 0L |
| 5 |
|
| 6 |
void functionTakingBool(bool); |
| 7 |
void functionTakingInt(int); |
| 8 |
void functionTakingUnsignedLong(unsigned long); |
| 9 |
void functionTakingChar(char); |
| 10 |
void functionTakingFloat(float); |
| 11 |
void functionTakingDouble(double); |
| 12 |
void functionTakingSignedChar(signed char); |
| 13 |
|
| 14 |
|
| 15 |
////////// Implicit conversion from bool. |
| 16 |
|
| 17 |
void implicitConversionFromBoolSimpleCases() { |
| 18 |
bool boolean = true; |
| 19 |
|
| 20 |
functionTakingBool(boolean); |
| 21 |
|
| 22 |
functionTakingInt(boolean); |
| 23 |
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion] |
| 24 |
// CHECK-FIXES: functionTakingInt((int)boolean); |
| 25 |
|
| 26 |
functionTakingUnsignedLong(boolean); |
| 27 |
// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: implicit conversion 'bool' -> 'unsigned long' |
| 28 |
// CHECK-FIXES: functionTakingUnsignedLong((unsigned long)boolean); |
| 29 |
|
| 30 |
functionTakingChar(boolean); |
| 31 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'bool' -> 'char' |
| 32 |
// CHECK-FIXES: functionTakingChar((char)boolean); |
| 33 |
|
| 34 |
functionTakingFloat(boolean); |
| 35 |
// CHECK-MESSAGES: :[[@LINE-1]]:23: warning: implicit conversion 'bool' -> 'float' |
| 36 |
// CHECK-FIXES: functionTakingFloat((float)boolean); |
| 37 |
|
| 38 |
functionTakingDouble(boolean); |
| 39 |
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'bool' -> 'double' |
| 40 |
// CHECK-FIXES: functionTakingDouble((double)boolean); |
| 41 |
} |
| 42 |
|
| 43 |
float implicitConversionFromBoolInReturnValue() { |
| 44 |
bool boolean = false; |
| 45 |
return boolean; |
| 46 |
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: implicit conversion 'bool' -> 'float' |
| 47 |
// CHECK-FIXES: return (float)boolean; |
| 48 |
} |
| 49 |
|
| 50 |
void implicitConversionFromBoolInSingleBoolExpressions(bool b1, bool b2) { |
| 51 |
bool boolean = true; |
| 52 |
boolean = b1 ^ b2; |
| 53 |
boolean |= !b1 || !b2; |
| 54 |
boolean &= b1; |
| 55 |
|
| 56 |
int integer = boolean - 3; |
| 57 |
// CHECK-MESSAGES: :[[@LINE-1]]:17: warning: implicit conversion 'bool' -> 'int' |
| 58 |
// CHECK-FIXES: int integer = (int)boolean - 3; |
| 59 |
|
| 60 |
float floating = boolean / 0.3f; |
| 61 |
// CHECK-MESSAGES: :[[@LINE-1]]:20: warning: implicit conversion 'bool' -> 'float' |
| 62 |
// CHECK-FIXES: float floating = (float)boolean / 0.3f; |
| 63 |
|
| 64 |
char character = boolean; |
| 65 |
// CHECK-MESSAGES: :[[@LINE-1]]:20: warning: implicit conversion 'bool' -> 'char' |
| 66 |
// CHECK-FIXES: char character = (char)boolean; |
| 67 |
} |
| 68 |
|
| 69 |
void implicitConversionFromBoolInComplexBoolExpressions() { |
| 70 |
bool boolean = true; |
| 71 |
bool anotherBoolean = false; |
| 72 |
|
| 73 |
int integer = boolean && anotherBoolean; |
| 74 |
// CHECK-MESSAGES: :[[@LINE-1]]:17: warning: implicit conversion 'bool' -> 'int' |
| 75 |
// CHECK-MESSAGES: :[[@LINE-2]]:28: warning: implicit conversion 'bool' -> 'int' |
| 76 |
// CHECK-FIXES: int integer = (int)boolean && (int)anotherBoolean; |
| 77 |
|
| 78 |
float floating = (boolean || anotherBoolean) * 0.3f; |
| 79 |
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: implicit conversion 'bool' -> 'int' |
| 80 |
// CHECK-MESSAGES: :[[@LINE-2]]:32: warning: implicit conversion 'bool' -> 'int' |
| 81 |
// CHECK-FIXES: float floating = ((int)boolean || (int)anotherBoolean) * 0.3f; |
| 82 |
|
| 83 |
double doubleFloating = (boolean && (anotherBoolean || boolean)) * 0.3; |
| 84 |
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: implicit conversion 'bool' -> 'int' |
| 85 |
// CHECK-MESSAGES: :[[@LINE-2]]:40: warning: implicit conversion 'bool' -> 'int' |
| 86 |
// CHECK-MESSAGES: :[[@LINE-3]]:58: warning: implicit conversion 'bool' -> 'int' |
| 87 |
// CHECK-FIXES: double doubleFloating = ((int)boolean && ((int)anotherBoolean || (int)boolean)) * 0.3; |
| 88 |
} |
| 89 |
|
| 90 |
void implicitConversionFromBoolLiterals() { |
| 91 |
functionTakingInt(true); |
| 92 |
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: implicit conversion 'bool' -> 'int' |
| 93 |
// CHECK-FIXES: functionTakingInt(1); |
| 94 |
|
| 95 |
functionTakingUnsignedLong(false); |
| 96 |
// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: implicit conversion 'bool' -> 'unsigned long' |
| 97 |
// CHECK-FIXES: functionTakingUnsignedLong(0u); |
| 98 |
|
| 99 |
functionTakingSignedChar(true); |
| 100 |
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: implicit conversion 'bool' -> 'signed char' |
| 101 |
// CHECK-FIXES: functionTakingSignedChar(1); |
| 102 |
|
| 103 |
functionTakingFloat(false); |
| 104 |
// CHECK-MESSAGES: :[[@LINE-1]]:23: warning: implicit conversion 'bool' -> 'float' |
| 105 |
// CHECK-FIXES: functionTakingFloat(0.0f); |
| 106 |
|
| 107 |
functionTakingDouble(true); |
| 108 |
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'bool' -> 'double' |
| 109 |
// CHECK-FIXES: functionTakingDouble(1.0); |
| 110 |
} |
| 111 |
|
| 112 |
void implicitConversionFromBoolInComparisons() { |
| 113 |
bool boolean = true; |
| 114 |
int integer = 0; |
| 115 |
|
| 116 |
functionTakingBool(boolean == integer); |
| 117 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'bool' -> 'int' |
| 118 |
// CHECK-FIXES: functionTakingBool((int)boolean == integer); |
| 119 |
|
| 120 |
functionTakingBool(integer != boolean); |
| 121 |
// CHECK-MESSAGES: :[[@LINE-1]]:33: warning: implicit conversion 'bool' -> 'int' |
| 122 |
// CHECK-FIXES: functionTakingBool(integer != (int)boolean); |
| 123 |
} |
| 124 |
|
| 125 |
void ignoreBoolComparisons() { |
| 126 |
bool boolean = true; |
| 127 |
bool anotherBoolean = false; |
| 128 |
|
| 129 |
functionTakingBool(boolean == anotherBoolean); |
| 130 |
functionTakingBool(boolean != anotherBoolean); |
| 131 |
} |
| 132 |
|
| 133 |
void ignoreExplicitCastsFromBool() { |
| 134 |
bool boolean = true; |
| 135 |
|
| 136 |
int integer = (int)boolean + 3; |
| 137 |
float floating = (float)boolean * 0.3f; |
| 138 |
char character = (char)boolean; |
| 139 |
} |
| 140 |
|
| 141 |
void ignoreImplicitConversionFromBoolInMacroExpansions() { |
| 142 |
bool boolean = true; |
| 143 |
|
| 144 |
#define CAST_FROM_BOOL_IN_MACRO_BODY boolean + 3 |
| 145 |
int integerFromMacroBody = CAST_FROM_BOOL_IN_MACRO_BODY; |
| 146 |
|
| 147 |
#define CAST_FROM_BOOL_IN_MACRO_ARGUMENT(x) x + 3 |
| 148 |
int integerFromMacroArgument = CAST_FROM_BOOL_IN_MACRO_ARGUMENT(boolean); |
| 149 |
} |
| 150 |
|
| 151 |
////////// Implicit conversions to bool. |
| 152 |
|
| 153 |
void implicitConversionToBoolSimpleCases() { |
| 154 |
int integer = 10; |
| 155 |
functionTakingBool(integer); |
| 156 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'int' -> 'bool' |
| 157 |
// CHECK-FIXES: functionTakingBool(integer != 0); |
| 158 |
|
| 159 |
unsigned long unsignedLong = 10; |
| 160 |
functionTakingBool(unsignedLong); |
| 161 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'unsigned long' -> 'bool' |
| 162 |
// CHECK-FIXES: functionTakingBool(unsignedLong != 0u); |
| 163 |
|
| 164 |
float floating = 0.0f; |
| 165 |
functionTakingBool(floating); |
| 166 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'float' -> 'bool' |
| 167 |
// CHECK-FIXES: functionTakingBool(floating != 0.0f); |
| 168 |
|
| 169 |
double doubleFloating = 1.0f; |
| 170 |
functionTakingBool(doubleFloating); |
| 171 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'double' -> 'bool' |
| 172 |
// CHECK-FIXES: functionTakingBool(doubleFloating != 0.0); |
| 173 |
|
| 174 |
signed char character = 'a'; |
| 175 |
functionTakingBool(character); |
| 176 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'signed char' -> 'bool' |
| 177 |
// CHECK-FIXES: functionTakingBool(character != 0); |
| 178 |
|
| 179 |
int* pointer = nullptr; |
| 180 |
functionTakingBool(pointer); |
| 181 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'int *' -> 'bool' |
| 182 |
// CHECK-FIXES: functionTakingBool(pointer != nullptr); |
| 183 |
} |
| 184 |
|
| 185 |
void implicitConversionToBoolInSingleExpressions() { |
| 186 |
int integer = 10; |
| 187 |
bool boolComingFromInt; |
| 188 |
boolComingFromInt = integer; |
| 189 |
// CHECK-MESSAGES: :[[@LINE-1]]:23: warning: implicit conversion 'int' -> 'bool' |
| 190 |
// CHECK-FIXES: boolComingFromInt = (integer != 0); |
| 191 |
|
| 192 |
float floating = 10.0f; |
| 193 |
bool boolComingFromFloat; |
| 194 |
boolComingFromFloat = floating; |
| 195 |
// CHECK-MESSAGES: :[[@LINE-1]]:25: warning: implicit conversion 'float' -> 'bool' |
| 196 |
// CHECK-FIXES: boolComingFromFloat = (floating != 0.0f); |
| 197 |
|
| 198 |
signed char character = 'a'; |
| 199 |
bool boolComingFromChar; |
| 200 |
boolComingFromChar = character; |
| 201 |
// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: implicit conversion 'signed char' -> 'bool' |
| 202 |
// CHECK-FIXES: boolComingFromChar = (character != 0); |
| 203 |
|
| 204 |
int* pointer = nullptr; |
| 205 |
bool boolComingFromPointer; |
| 206 |
boolComingFromPointer = pointer; |
| 207 |
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: implicit conversion 'int *' -> 'bool' |
| 208 |
// CHECK-FIXES: boolComingFromPointer = (pointer != nullptr); |
| 209 |
} |
| 210 |
|
| 211 |
void implicitConversionToBoolInComplexExpressions() { |
| 212 |
bool boolean = true; |
| 213 |
|
| 214 |
int integer = 10; |
| 215 |
int anotherInteger = 20; |
| 216 |
bool boolComingFromInteger; |
| 217 |
boolComingFromInteger = integer + anotherInteger; |
| 218 |
// CHECK-MESSAGES: :[[@LINE-1]]:27: warning: implicit conversion 'int' -> 'bool' |
| 219 |
// CHECK-FIXES: boolComingFromInteger = ((integer + anotherInteger) != 0); |
| 220 |
} |
| 221 |
|
| 222 |
void implicitConversionInNegationExpressions() { |
| 223 |
int integer = 10; |
| 224 |
bool boolComingFromNegatedInt; |
| 225 |
boolComingFromNegatedInt = !integer; |
| 226 |
// CHECK-MESSAGES: :[[@LINE-1]]:30: warning: implicit conversion 'int' -> 'bool' |
| 227 |
// CHECK-FIXES: boolComingFromNegatedInt = ((!integer) != 0); |
| 228 |
} |
| 229 |
|
| 230 |
bool implicitConversionToBoolInReturnValue() { |
| 231 |
float floating = 1.0f; |
| 232 |
return floating; |
| 233 |
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: implicit conversion 'float' -> 'bool' |
| 234 |
// CHECK-FIXES: return floating != 0.0f; |
| 235 |
} |
| 236 |
|
| 237 |
void implicitConversionToBoolFromLiterals() { |
| 238 |
functionTakingBool(0); |
| 239 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'int' -> 'bool' |
| 240 |
// CHECK-FIXES: functionTakingBool(false); |
| 241 |
|
| 242 |
functionTakingBool(1); |
| 243 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'int' -> 'bool' |
| 244 |
// CHECK-FIXES: functionTakingBool(true); |
| 245 |
|
| 246 |
functionTakingBool(2ul); |
| 247 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'unsigned long' -> 'bool' |
| 248 |
// CHECK-FIXES: functionTakingBool(true); |
| 249 |
|
| 250 |
functionTakingBool(0.0f); |
| 251 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'float' -> 'bool' |
| 252 |
// CHECK-FIXES: functionTakingBool(false); |
| 253 |
|
| 254 |
functionTakingBool(1.0f); |
| 255 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'float' -> 'bool' |
| 256 |
// CHECK-FIXES: functionTakingBool(true); |
| 257 |
|
| 258 |
functionTakingBool(2.0); |
| 259 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'double' -> 'bool' |
| 260 |
// CHECK-FIXES: functionTakingBool(true); |
| 261 |
|
| 262 |
functionTakingBool('\0'); |
| 263 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'int' -> 'bool' |
| 264 |
// CHECK-FIXES: functionTakingBool(false); |
| 265 |
|
| 266 |
functionTakingBool('a'); |
| 267 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'int' -> 'bool' |
| 268 |
// CHECK-FIXES: functionTakingBool(true); |
| 269 |
|
| 270 |
functionTakingBool(""); |
| 271 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'char *' -> 'bool' |
| 272 |
// CHECK-FIXES: functionTakingBool(true); |
| 273 |
|
| 274 |
functionTakingBool("abc"); |
| 275 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'char *' -> 'bool' |
| 276 |
// CHECK-FIXES: functionTakingBool(true); |
| 277 |
|
| 278 |
functionTakingBool(NULL); |
| 279 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'long' -> 'bool' |
| 280 |
// CHECK-FIXES: functionTakingBool(false); |
| 281 |
} |
| 282 |
|
| 283 |
void implicitConversionToBoolFromUnaryMinusAndZeroLiterals() { |
| 284 |
functionTakingBool(-0); |
| 285 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'int' -> 'bool' |
| 286 |
// CHECK-FIXES: functionTakingBool((-0) != 0); |
| 287 |
|
| 288 |
functionTakingBool(-0.0f); |
| 289 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'float' -> 'bool' |
| 290 |
// CHECK-FIXES: functionTakingBool((-0.0f) != 0.0f); |
| 291 |
|
| 292 |
functionTakingBool(-0.0); |
| 293 |
// CHECK-MESSAGES: :[[@LINE-1]]:22: warning: implicit conversion 'double' -> 'bool' |
| 294 |
// CHECK-FIXES: functionTakingBool((-0.0) != 0.0); |
| 295 |
} |
| 296 |
|
| 297 |
void ignoreExplicitCastsToBool() { |
| 298 |
int integer = 10; |
| 299 |
bool boolComingFromInt = (bool)integer; |
| 300 |
|
| 301 |
float floating = 10.0f; |
| 302 |
bool boolComingFromFloat = (bool)floating; |
| 303 |
|
| 304 |
char character = 'a'; |
| 305 |
bool boolComingFromChar = (bool)character; |
| 306 |
|
| 307 |
int* pointer = nullptr; |
| 308 |
bool booleanComingFromPointer = (bool)pointer; |
| 309 |
} |
| 310 |
|
| 311 |
void ignoreImplicitConversionToBoolInMacroExpansions() { |
| 312 |
int integer = 3; |
| 313 |
|
| 314 |
#define CAST_TO_BOOL_IN_MACRO_BODY integer && false |
| 315 |
bool boolFromMacroBody = CAST_TO_BOOL_IN_MACRO_BODY; |
| 316 |
|
| 317 |
#define CAST_TO_BOOL_IN_MACRO_ARGUMENT(x) x || true |
| 318 |
bool boolFromMacroArgument = CAST_TO_BOOL_IN_MACRO_ARGUMENT(integer); |
| 319 |
} |
| 320 |
|
| 321 |
int implicitConversionReturnInt() |
| 322 |
{ |
| 323 |
return true; |
| 324 |
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: implicit conversion 'bool' -> 'int' |
| 325 |
// CHECK-FIXES: return 1 |
| 326 |
} |
| 327 |
|
| 328 |
int implicitConversionReturnIntWithParens() |
| 329 |
{ |
| 330 |
return (true); |
| 331 |
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: implicit conversion 'bool' -> 'int' |
| 332 |
// CHECK-FIXES: return 1 |
| 333 |
} |
| 334 |
|
| 335 |
bool implicitConversionReturnBool() |
| 336 |
{ |
| 337 |
return 1; |
| 338 |
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: implicit conversion 'int' -> 'bool' |
| 339 |
// CHECK-FIXES: return true |
| 340 |
} |
| 341 |
|
| 342 |
bool implicitConversionReturnBoolWithParens() |
| 343 |
{ |
| 344 |
return (1); |
| 345 |
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: implicit conversion 'int' -> 'bool' |
| 346 |
// CHECK-FIXES: return true |
| 347 |
} |
| 348 |
|
| 349 |
int keepCompactReturnInC_PR71848() { |
| 350 |
bool foo = false; |
| 351 |
return( foo ); |
| 352 |
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion] |
| 353 |
// CHECK-FIXES: return(int)( foo ); |
| 354 |
} |