| 1 |
// RUN: %check_clang_tidy -std=c++20 %s modernize-use-ranges %t -- -- -I %S/Inputs/use-ranges/ |
| 2 |
// RUN: %check_clang_tidy -std=c++23 %s modernize-use-ranges %t -check-suffixes=,CPP23 -- -I %S/Inputs/use-ranges/ |
| 3 |
|
| 4 |
// CHECK-FIXES: #include <algorithm> |
| 5 |
// CHECK-FIXES-CPP23: #include <numeric> |
| 6 |
// CHECK-FIXES: #include <ranges> |
| 7 |
|
| 8 |
#include "fake_std.h" |
| 9 |
|
| 10 |
void Positives() { |
| 11 |
std::vector<int> I, J; |
| 12 |
std::find(I.begin(), I.end(), 0); |
| 13 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 14 |
// CHECK-FIXES: std::ranges::find(I, 0); |
| 15 |
|
| 16 |
std::find(I.cbegin(), I.cend(), 1); |
| 17 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 18 |
// CHECK-FIXES: std::ranges::find(I, 1); |
| 19 |
|
| 20 |
std::find(std::begin(I), std::end(I), 2); |
| 21 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 22 |
// CHECK-FIXES: std::ranges::find(I, 2); |
| 23 |
|
| 24 |
std::find(std::cbegin(I), std::cend(I), 3); |
| 25 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 26 |
// CHECK-FIXES: std::ranges::find(I, 3); |
| 27 |
|
| 28 |
std::find(std::cbegin(I), I.cend(), 4); |
| 29 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 30 |
// CHECK-FIXES: std::ranges::find(I, 4); |
| 31 |
|
| 32 |
std::reverse(I.begin(), I.end()); |
| 33 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 34 |
// CHECK-FIXES: std::ranges::reverse(I); |
| 35 |
|
| 36 |
std::includes(I.begin(), I.end(), I.begin(), I.end()); |
| 37 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 38 |
// CHECK-FIXES: std::ranges::includes(I, I); |
| 39 |
|
| 40 |
std::includes(I.begin(), I.end(), J.begin(), J.end()); |
| 41 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 42 |
// CHECK-FIXES: std::ranges::includes(I, J); |
| 43 |
|
| 44 |
std::is_permutation(I.begin(), I.end(), J.begin(), J.end()); |
| 45 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 46 |
// CHECK-FIXES: std::ranges::is_permutation(I, J); |
| 47 |
|
| 48 |
std::equal(I.begin(), I.end(), J.begin(), J.end()); |
| 49 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 50 |
// CHECK-FIXES: std::ranges::equal(I, J); |
| 51 |
|
| 52 |
std::equal(I.begin(), I.end(), J.begin(), J.end(), [](int a, int b){ return a == b; }); |
| 53 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 54 |
// CHECK-FIXES: std::ranges::equal(I, J, [](int a, int b){ return a == b; }); |
| 55 |
|
| 56 |
std::iota(I.begin(), I.end(), 0); |
| 57 |
// CHECK-MESSAGES-CPP23: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 58 |
// CHECK-FIXES-CPP23: std::ranges::iota(I, 0); |
| 59 |
|
| 60 |
std::rotate(I.begin(), I.begin() + 2, I.end()); |
| 61 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 62 |
// CHECK-FIXES: std::ranges::rotate(I, I.begin() + 2); |
| 63 |
|
| 64 |
using std::find; |
| 65 |
namespace my_std = std; |
| 66 |
|
| 67 |
// Potentially these could be updated to better qualify the replaced function name |
| 68 |
find(I.begin(), I.end(), 5); |
| 69 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 70 |
// CHECK-FIXES: std::ranges::find(I, 5); |
| 71 |
|
| 72 |
my_std::find(I.begin(), I.end(), 6); |
| 73 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 74 |
// CHECK-FIXES: std::ranges::find(I, 6); |
| 75 |
} |
| 76 |
|
| 77 |
void Reverse(){ |
| 78 |
std::vector<int> I, J; |
| 79 |
std::find(I.rbegin(), I.rend(), 0); |
| 80 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 81 |
// CHECK-FIXES: std::ranges::find(std::ranges::reverse_view(I), 0); |
| 82 |
|
| 83 |
std::equal(std::rbegin(I), std::rend(I), J.begin(), J.end()); |
| 84 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 85 |
// CHECK-FIXES: std::ranges::equal(std::ranges::reverse_view(I), J); |
| 86 |
|
| 87 |
std::equal(I.begin(), I.end(), std::crbegin(J), std::crend(J)); |
| 88 |
// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use a ranges version of this algorithm |
| 89 |
// CHECK-FIXES: std::ranges::equal(I, std::ranges::reverse_view(J)); |
| 90 |
} |
| 91 |
|
| 92 |
void Negatives() { |
| 93 |
std::vector<int> I, J; |
| 94 |
std::find(I.begin(), J.end(), 0); |
| 95 |
std::find(I.begin(), I.begin(), 0); |
| 96 |
std::find(I.end(), I.begin(), 0); |
| 97 |
|
| 98 |
|
| 99 |
// Need both ranges for this one |
| 100 |
std::is_permutation(I.begin(), I.end(), J.begin()); |
| 101 |
|
| 102 |
// We only have one valid match here and the ranges::equal function needs 2 complete ranges |
| 103 |
std::equal(I.begin(), I.end(), J.begin()); |
| 104 |
std::equal(I.begin(), I.end(), J.end(), J.end()); |
| 105 |
std::equal(std::rbegin(I), std::rend(I), std::rend(J), std::rbegin(J)); |
| 106 |
std::equal(I.begin(), J.end(), I.begin(), I.end()); |
| 107 |
|
| 108 |
// std::rotate expects the full range in the 1st and 3rd argument. |
| 109 |
// Anyone writing this code has probably written a bug, but this isn't the |
| 110 |
// purpose of this check. |
| 111 |
std::rotate(I.begin(), I.end(), I.begin() + 2); |
| 112 |
// Pathological, but probably shouldn't diagnose this |
| 113 |
std::rotate(I.begin(), I.end(), I.end() + 0); |
| 114 |
} |