| 1 |
* I don't like the indentation style at all, but for the most part |
| 2 |
I've left it alone. |
| 3 |
|
| 4 |
* Much of the code looks ugly to me. |
| 5 |
|
| 6 |
* Group the members of MidiSong into logical units, i.e. structs? |
| 7 |
|
| 8 |
* The debug messages are probably a bit too noisy. I've removed one |
| 9 |
particularly annoying one, but... |
| 10 |
|
| 11 |
Some of them should be turned into error messages instead. |
| 12 |
|
| 13 |
* Can the instrument handling be made more efficient? At the moment |
| 14 |
different MidiSongs may separately load the same instrument. |
| 15 |
|
| 16 |
Note that the MidiSong's audio format affects how the instrument is |
| 17 |
loaded, so it's not as easy as just letting all MidiSongs share tone |
| 18 |
and drum banks. |
| 19 |
|
| 20 |
At the moment they do share the data that is simply read from the |
| 21 |
config file, but that's just a quick hack to avoid having to read |
| 22 |
the config file every time a MIDI song is loaded. |
| 23 |
|
| 24 |
* Check if any of MidiStruct's members can safely be made into static |
| 25 |
globals again. |
| 26 |
|
| 27 |
* TiMidity++ adds a number of undocumented (?) extensions to the |
| 28 |
configuration syntax. These are not implemented here. In particular, |
| 29 |
the "map" keyword used by the "eawpats". |
| 30 |
|
| 31 |
* The other decoders generally only read as much of the file as is |
| 32 |
necessary. Could we do that in this decoder as well? (Currently it |
| 33 |
seems to convert the entire file into MIDI events first.) |
| 34 |
|
| 35 |
* Can it be optimized? |