| 1 |
The Qt coding style is defined at |
| 2 |
http://qt.gitorious.org/qt/pages/QtCodingStyle |
| 3 |
so let's follow that. |
| 4 |
|
| 5 |
Overall, the basic rule is simple: follow the coding style, and the design and |
| 6 |
functionality patterns that are already there. There are patterns for |
| 7 |
getting and setting oFono properties, calling methods and getting the |
| 8 |
method call result, setting the errors, and receiving out-of-band signals. |
| 9 |
Hopefully that should be enough for any remaining APIs which are currently |
| 10 |
missing (some APIs such as SIM toolkit require implementing a d-bus agent for |
| 11 |
which there is no example yet). |
| 12 |
|
| 13 |
For any new API that is added, there should also be a test case. Again, try to |
| 14 |
imitate existing test cases. It is not necessary to thoroughly test the |
| 15 |
functionality; it is enough to go through all properties, methods and signals |
| 16 |
and check that they work, return sane values and match the actual oFono API. |
| 17 |
The tests should be written against Phonesim phone simulator and it's |
| 18 |
preferred that they should be able to run without manual intervention. |