| 1 |
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> |
| 2 |
<html xmlns="http://www.w3.org/1999/xhtml"> |
| 3 |
<head> |
| 4 |
<title>FindBugs Report</title> |
| 5 |
<style type="text/css"> |
| 6 |
.tablerow0 { |
| 7 |
background: #EEEEEE; |
| 8 |
} |
| 9 |
|
| 10 |
.tablerow1 { |
| 11 |
background: white; |
| 12 |
} |
| 13 |
|
| 14 |
.detailrow0 { |
| 15 |
background: #EEEEEE; |
| 16 |
} |
| 17 |
|
| 18 |
.detailrow1 { |
| 19 |
background: white; |
| 20 |
} |
| 21 |
|
| 22 |
.tableheader { |
| 23 |
background: #b9b9fe; |
| 24 |
font-size: larger; |
| 25 |
} |
| 26 |
|
| 27 |
.tablerow0:hover, .tablerow1:hover { |
| 28 |
background: #aaffaa; |
| 29 |
} |
| 30 |
|
| 31 |
.priority-1 { |
| 32 |
color: red; |
| 33 |
font-weight: bold; |
| 34 |
} |
| 35 |
.priority-2 { |
| 36 |
color: orange; |
| 37 |
font-weight: bold; |
| 38 |
} |
| 39 |
.priority-3 { |
| 40 |
color: green; |
| 41 |
font-weight: bold; |
| 42 |
} |
| 43 |
.priority-4 { |
| 44 |
color: blue; |
| 45 |
font-weight: bold; |
| 46 |
} |
| 47 |
</style> |
| 48 |
<script type="text/javascript"> |
| 49 |
function toggleRow(elid) { |
| 50 |
if (document.getElementById) { |
| 51 |
element = document.getElementById(elid); |
| 52 |
if (element) { |
| 53 |
if (element.style.display == 'none') { |
| 54 |
element.style.display = 'block'; |
| 55 |
//window.status = 'Toggle on!'; |
| 56 |
} else { |
| 57 |
element.style.display = 'none'; |
| 58 |
//window.status = 'Toggle off!'; |
| 59 |
} |
| 60 |
} |
| 61 |
} |
| 62 |
} |
| 63 |
</script> |
| 64 |
</head> |
| 65 |
<body> |
| 66 |
<h1> |
| 67 |
<a href="http://findbugs.sourceforge.net">FindBugs</a> Report</h1> |
| 68 |
<h2>Project Information</h2> |
| 69 |
<p>Project: |
| 70 |
</p> |
| 71 |
<p>FindBugs version: 3.0.1</p> |
| 72 |
<p>Code analyzed:</p> |
| 73 |
<ul> |
| 74 |
<li>/home/kredel/jas/edu/jas/</li> |
| 75 |
</ul> |
| 76 |
<p> |
| 77 |
<br/> |
| 78 |
<br/> |
| 79 |
</p> |
| 80 |
<h2>Metrics</h2> |
| 81 |
<p>113838 lines of code analyzed, |
| 82 |
in 1016 classes, |
| 83 |
in 16 packages.</p> |
| 84 |
<table width="500" cellpadding="5" cellspacing="2"> |
| 85 |
<tr class="tableheader"> |
| 86 |
<th align="left">Metric</th> |
| 87 |
<th align="right">Total</th> |
| 88 |
<th align="right">Density*</th> |
| 89 |
</tr> |
| 90 |
<tr class="tablerow0"> |
| 91 |
<td>High Priority Warnings</td> |
| 92 |
<td align="right">1</td> |
| 93 |
<td align="right">0.01</td> |
| 94 |
</tr> |
| 95 |
<tr class="tablerow1"> |
| 96 |
<td>Medium Priority Warnings</td> |
| 97 |
<td align="right">37</td> |
| 98 |
<td align="right">0.33</td> |
| 99 |
</tr> |
| 100 |
<tr class="$totalClass"> |
| 101 |
<td> |
| 102 |
<b>Total Warnings</b> |
| 103 |
</td> |
| 104 |
<td align="right"> |
| 105 |
<b>38</b> |
| 106 |
</td> |
| 107 |
<td align="right"> |
| 108 |
<b>0.33</b> |
| 109 |
</td> |
| 110 |
</tr> |
| 111 |
</table> |
| 112 |
<p> |
| 113 |
<i>(* Defects per Thousand lines of non-commenting source statements)</i> |
| 114 |
</p> |
| 115 |
<p> |
| 116 |
<br/> |
| 117 |
<br/> |
| 118 |
</p> |
| 119 |
<h2>Contents</h2> |
| 120 |
<ul> |
| 121 |
<li> |
| 122 |
<a href="#Warnings_BAD_PRACTICE">Bad practice Warnings</a> |
| 123 |
</li> |
| 124 |
<li> |
| 125 |
<a href="#Warnings_MALICIOUS_CODE">Malicious code vulnerability Warnings</a> |
| 126 |
</li> |
| 127 |
<li> |
| 128 |
<a href="#Warnings_STYLE">Dodgy code Warnings</a> |
| 129 |
</li> |
| 130 |
<li> |
| 131 |
<a href="#Details">Details</a> |
| 132 |
</li> |
| 133 |
</ul> |
| 134 |
<h1>Summary</h1> |
| 135 |
<table width="500" cellpadding="5" cellspacing="2"> |
| 136 |
<tr class="tableheader"> |
| 137 |
<th align="left">Warning Type</th> |
| 138 |
<th align="right">Number</th> |
| 139 |
</tr> |
| 140 |
<tr class="tablerow0"> |
| 141 |
<td> |
| 142 |
<a href="#Warnings_BAD_PRACTICE">Bad practice Warnings</a> |
| 143 |
</td> |
| 144 |
<td align="right">22</td> |
| 145 |
</tr> |
| 146 |
<tr class="tablerow1"> |
| 147 |
<td> |
| 148 |
<a href="#Warnings_MALICIOUS_CODE">Malicious code vulnerability Warnings</a> |
| 149 |
</td> |
| 150 |
<td align="right">1</td> |
| 151 |
</tr> |
| 152 |
<tr class="tablerow0"> |
| 153 |
<td> |
| 154 |
<a href="#Warnings_STYLE">Dodgy code Warnings</a> |
| 155 |
</td> |
| 156 |
<td align="right">15</td> |
| 157 |
</tr> |
| 158 |
<tr class="tablerow1"> |
| 159 |
<td> |
| 160 |
<b>Total</b> |
| 161 |
</td> |
| 162 |
<td align="right"> |
| 163 |
<b>38</b> |
| 164 |
</td> |
| 165 |
</tr> |
| 166 |
</table> |
| 167 |
<h1>Warnings</h1> |
| 168 |
<p>Click on a warning row to see full context information.</p> |
| 169 |
<h2> |
| 170 |
<a name="Warnings_BAD_PRACTICE">Bad practice Warnings</a> |
| 171 |
</h2> |
| 172 |
<table class="warningtable" width="100%" cellspacing="0"> |
| 173 |
<tr class="tableheader"> |
| 174 |
<th align="left">Code</th> |
| 175 |
<th align="left">Warning</th> |
| 176 |
</tr> |
| 177 |
<tr class="tablerow1" onclick="toggleRow('N65548');"> |
| 178 |
<td> |
| 179 |
<span class="priority-1">Nm</span> |
| 180 |
</td> |
| 181 |
<td>The class name edu.jas.application.FactorFactory shadows the simple name of the superclass edu.jas.ufd.FactorFactory</td> |
| 182 |
</tr> |
| 183 |
<tr class="detailrow1"> |
| 184 |
<td/> |
| 185 |
<td> |
| 186 |
<p id="N65548" style="display: none;"> |
| 187 |
<a href="#NM_SAME_SIMPLE_NAME_AS_SUPERCLASS">Bug type NM_SAME_SIMPLE_NAME_AS_SUPERCLASS (click for details)</a> |
| 188 |
<br/>In class edu.jas.application.FactorFactory<br/>In class edu.jas.ufd.FactorFactory<br/>At FactorFactory.java:[lines 66-212]</p> |
| 189 |
</td> |
| 190 |
</tr> |
| 191 |
<tr class="tablerow0" onclick="toggleRow('N65595');"> |
| 192 |
<td> |
| 193 |
<span class="priority-2">Nm</span> |
| 194 |
</td> |
| 195 |
<td>The method name edu.jas.application.GBAlgorithmBuilder.Arri() doesn't start with a lower case letter</td> |
| 196 |
</tr> |
| 197 |
<tr class="detailrow0"> |
| 198 |
<td/> |
| 199 |
<td> |
| 200 |
<p id="N65595" style="display: none;"> |
| 201 |
<a href="#NM_METHOD_NAMING_CONVENTION">Bug type NM_METHOD_NAMING_CONVENTION (click for details)</a> |
| 202 |
<br/>In class edu.jas.application.GBAlgorithmBuilder<br/>In method edu.jas.application.GBAlgorithmBuilder.Arri()<br/>At GBAlgorithmBuilder.java:[lines 523-536]</p> |
| 203 |
</td> |
| 204 |
</tr> |
| 205 |
<tr class="tablerow1" onclick="toggleRow('N65711');"> |
| 206 |
<td> |
| 207 |
<span class="priority-2">OS</span> |
| 208 |
</td> |
| 209 |
<td>edu.jas.application.RunGB.getReader(String) may fail to close stream</td> |
| 210 |
</tr> |
| 211 |
<tr class="detailrow1"> |
| 212 |
<td/> |
| 213 |
<td> |
| 214 |
<p id="N65711" style="display: none;"> |
| 215 |
<a href="#OS_OPEN_STREAM">Bug type OS_OPEN_STREAM (click for details)</a> |
| 216 |
<br/>In class edu.jas.application.RunGB<br/>In method edu.jas.application.RunGB.getReader(String)<br/>Need to close java.util.zip.ZipFile <br/>At RunGB.java:[line 489]</p> |
| 217 |
</td> |
| 218 |
</tr> |
| 219 |
<tr class="tablerow0" onclick="toggleRow('N67185');"> |
| 220 |
<td> |
| 221 |
<span class="priority-2">RV</span> |
| 222 |
</td> |
| 223 |
<td>edu.jas.poly.PolynomialComparator.compare(GenPolynomial, GenPolynomial) negates the return value of edu.jas.poly.GenPolynomial.compareTo(GenPolynomial)</td> |
| 224 |
</tr> |
| 225 |
<tr class="detailrow0"> |
| 226 |
<td/> |
| 227 |
<td> |
| 228 |
<p id="N67185" style="display: none;"> |
| 229 |
<a href="#RV_NEGATING_RESULT_OF_COMPARETO">Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details)</a> |
| 230 |
<br/>In class edu.jas.poly.PolynomialComparator<br/>In method edu.jas.poly.PolynomialComparator.compare(GenPolynomial, GenPolynomial)<br/>Called method edu.jas.poly.GenPolynomial.compareTo(GenPolynomial)<br/>Return value of edu.jas.poly.GenPolynomial.compareTo(GenPolynomial) of type int<br/>At PolynomialComparator.java:[line 51]</p> |
| 231 |
</td> |
| 232 |
</tr> |
| 233 |
<tr class="tablerow1" onclick="toggleRow('N67511');"> |
| 234 |
<td> |
| 235 |
<span class="priority-2">RV</span> |
| 236 |
</td> |
| 237 |
<td>edu.jas.poly.TermOrder$11.compare(ExpVector, ExpVector) negates the return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector)</td> |
| 238 |
</tr> |
| 239 |
<tr class="detailrow1"> |
| 240 |
<td/> |
| 241 |
<td> |
| 242 |
<p id="N67511" style="display: none;"> |
| 243 |
<a href="#RV_NEGATING_RESULT_OF_COMPARETO">Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details)</a> |
| 244 |
<br/>In class edu.jas.poly.TermOrder$11<br/>In method edu.jas.poly.TermOrder$11.compare(ExpVector, ExpVector)<br/>Called method edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector)<br/>Return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector) of type int<br/>At TermOrder.java:[line 292]</p> |
| 245 |
</td> |
| 246 |
</tr> |
| 247 |
<tr class="tablerow0" onclick="toggleRow('N67589');"> |
| 248 |
<td> |
| 249 |
<span class="priority-2">RV</span> |
| 250 |
</td> |
| 251 |
<td>edu.jas.poly.TermOrder$71.compare(ExpVector, ExpVector) negates the return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector)</td> |
| 252 |
</tr> |
| 253 |
<tr class="detailrow0"> |
| 254 |
<td/> |
| 255 |
<td> |
| 256 |
<p id="N67589" style="display: none;"> |
| 257 |
<a href="#RV_NEGATING_RESULT_OF_COMPARETO">Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details)</a> |
| 258 |
<br/>In class edu.jas.poly.TermOrder$71<br/>In method edu.jas.poly.TermOrder$71.compare(ExpVector, ExpVector)<br/>Called method edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector)<br/>Return value of edu.jas.poly.TermOrder$EVComparator.compare(ExpVector, ExpVector) of type int<br/>At TermOrder.java:[line 1316]</p> |
| 259 |
</td> |
| 260 |
</tr> |
| 261 |
<tr class="tablerow1" onclick="toggleRow('N67667');"> |
| 262 |
<td> |
| 263 |
<span class="priority-2">RV</span> |
| 264 |
</td> |
| 265 |
<td>edu.jas.poly.Word.gradInvlexCompareTo(Word) negates the return value of edu.jas.poly.Word.compareTo(Word)</td> |
| 266 |
</tr> |
| 267 |
<tr class="detailrow1"> |
| 268 |
<td/> |
| 269 |
<td> |
| 270 |
<p id="N67667" style="display: none;"> |
| 271 |
<a href="#RV_NEGATING_RESULT_OF_COMPARETO">Bug type RV_NEGATING_RESULT_OF_COMPARETO (click for details)</a> |
| 272 |
<br/>In class edu.jas.poly.Word<br/>In method edu.jas.poly.Word.gradInvlexCompareTo(Word)<br/>Called method edu.jas.poly.Word.compareTo(Word)<br/>Return value of edu.jas.poly.Word.compareTo(Word) of type int<br/>At Word.java:[line 553]</p> |
| 273 |
</td> |
| 274 |
</tr> |
| 275 |
<tr class="tablerow0" onclick="toggleRow('N66352');"> |
| 276 |
<td> |
| 277 |
<span class="priority-2">SnVI</span> |
| 278 |
</td> |
| 279 |
<td>edu.jas.fd.SGCDParallelProxy is Serializable; consider declaring a serialVersionUID</td> |
| 280 |
</tr> |
| 281 |
<tr class="detailrow0"> |
| 282 |
<td/> |
| 283 |
<td> |
| 284 |
<p id="N66352" style="display: none;"> |
| 285 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 286 |
<br/>In class edu.jas.fd.SGCDParallelProxy<br/>At SGCDParallelProxy.java:[lines 34-646]</p> |
| 287 |
</td> |
| 288 |
</tr> |
| 289 |
<tr class="tablerow1" onclick="toggleRow('N66561');"> |
| 290 |
<td> |
| 291 |
<span class="priority-2">SnVI</span> |
| 292 |
</td> |
| 293 |
<td>edu.jas.gb.GBProxy is Serializable; consider declaring a serialVersionUID</td> |
| 294 |
</tr> |
| 295 |
<tr class="detailrow1"> |
| 296 |
<td/> |
| 297 |
<td> |
| 298 |
<p id="N66561" style="display: none;"> |
| 299 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 300 |
<br/>In class edu.jas.gb.GBProxy<br/>At GBProxy.java:[lines 28-165]</p> |
| 301 |
</td> |
| 302 |
</tr> |
| 303 |
<tr class="tablerow0" onclick="toggleRow('N66596');"> |
| 304 |
<td> |
| 305 |
<span class="priority-2">SnVI</span> |
| 306 |
</td> |
| 307 |
<td>edu.jas.gb.GroebnerBaseDistributedEC is Serializable; consider declaring a serialVersionUID</td> |
| 308 |
</tr> |
| 309 |
<tr class="detailrow0"> |
| 310 |
<td/> |
| 311 |
<td> |
| 312 |
<p id="N66596" style="display: none;"> |
| 313 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 314 |
<br/>In class edu.jas.gb.GroebnerBaseDistributedEC<br/>At GroebnerBaseDistributedEC.java:[lines 44-470]</p> |
| 315 |
</td> |
| 316 |
</tr> |
| 317 |
<tr class="tablerow1" onclick="toggleRow('N66631');"> |
| 318 |
<td> |
| 319 |
<span class="priority-2">SnVI</span> |
| 320 |
</td> |
| 321 |
<td>edu.jas.gb.GroebnerBaseDistributedHybridEC is Serializable; consider declaring a serialVersionUID</td> |
| 322 |
</tr> |
| 323 |
<tr class="detailrow1"> |
| 324 |
<td/> |
| 325 |
<td> |
| 326 |
<p id="N66631" style="display: none;"> |
| 327 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 328 |
<br/>In class edu.jas.gb.GroebnerBaseDistributedHybridEC<br/>At GroebnerBaseDistributedHybridEC.java:[lines 46-546]</p> |
| 329 |
</td> |
| 330 |
</tr> |
| 331 |
<tr class="tablerow0" onclick="toggleRow('N66701');"> |
| 332 |
<td> |
| 333 |
<span class="priority-2">SnVI</span> |
| 334 |
</td> |
| 335 |
<td>edu.jas.gb.GroebnerBaseParallel is Serializable; consider declaring a serialVersionUID</td> |
| 336 |
</tr> |
| 337 |
<tr class="detailrow0"> |
| 338 |
<td/> |
| 339 |
<td> |
| 340 |
<p id="N66701" style="display: none;"> |
| 341 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 342 |
<br/>In class edu.jas.gb.GroebnerBaseParallel<br/>At GroebnerBaseParallel.java:[lines 39-281]</p> |
| 343 |
</td> |
| 344 |
</tr> |
| 345 |
<tr class="tablerow1" onclick="toggleRow('N66666');"> |
| 346 |
<td> |
| 347 |
<span class="priority-2">SnVI</span> |
| 348 |
</td> |
| 349 |
<td>edu.jas.gb.GroebnerBaseParIter is Serializable; consider declaring a serialVersionUID</td> |
| 350 |
</tr> |
| 351 |
<tr class="detailrow1"> |
| 352 |
<td/> |
| 353 |
<td> |
| 354 |
<p id="N66666" style="display: none;"> |
| 355 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 356 |
<br/>In class edu.jas.gb.GroebnerBaseParIter<br/>At GroebnerBaseParIter.java:[lines 40-331]</p> |
| 357 |
</td> |
| 358 |
</tr> |
| 359 |
<tr class="tablerow0" onclick="toggleRow('N66736');"> |
| 360 |
<td> |
| 361 |
<span class="priority-2">SnVI</span> |
| 362 |
</td> |
| 363 |
<td>edu.jas.gb.GroebnerBaseSeqPairDistributed is Serializable; consider declaring a serialVersionUID</td> |
| 364 |
</tr> |
| 365 |
<tr class="detailrow0"> |
| 366 |
<td/> |
| 367 |
<td> |
| 368 |
<p id="N66736" style="display: none;"> |
| 369 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 370 |
<br/>In class edu.jas.gb.GroebnerBaseSeqPairDistributed<br/>At GroebnerBaseSeqPairDistributed.java:[lines 44-385]</p> |
| 371 |
</td> |
| 372 |
</tr> |
| 373 |
<tr class="tablerow1" onclick="toggleRow('N66771');"> |
| 374 |
<td> |
| 375 |
<span class="priority-2">SnVI</span> |
| 376 |
</td> |
| 377 |
<td>edu.jas.gb.GroebnerBaseSeqPairParallel is Serializable; consider declaring a serialVersionUID</td> |
| 378 |
</tr> |
| 379 |
<tr class="detailrow1"> |
| 380 |
<td/> |
| 381 |
<td> |
| 382 |
<p id="N66771" style="display: none;"> |
| 383 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 384 |
<br/>In class edu.jas.gb.GroebnerBaseSeqPairParallel<br/>At GroebnerBaseSeqPairParallel.java:[lines 36-267]</p> |
| 385 |
</td> |
| 386 |
</tr> |
| 387 |
<tr class="tablerow0" onclick="toggleRow('N66806');"> |
| 388 |
<td> |
| 389 |
<span class="priority-2">SnVI</span> |
| 390 |
</td> |
| 391 |
<td>edu.jas.gb.SGBProxy is Serializable; consider declaring a serialVersionUID</td> |
| 392 |
</tr> |
| 393 |
<tr class="detailrow0"> |
| 394 |
<td/> |
| 395 |
<td> |
| 396 |
<p id="N66806" style="display: none;"> |
| 397 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 398 |
<br/>In class edu.jas.gb.SGBProxy<br/>At SGBProxy.java:[lines 28-314]</p> |
| 399 |
</td> |
| 400 |
</tr> |
| 401 |
<tr class="tablerow1" onclick="toggleRow('N66841');"> |
| 402 |
<td> |
| 403 |
<span class="priority-2">SnVI</span> |
| 404 |
</td> |
| 405 |
<td>edu.jas.gb.SolvableGroebnerBaseParallel is Serializable; consider declaring a serialVersionUID</td> |
| 406 |
</tr> |
| 407 |
<tr class="detailrow1"> |
| 408 |
<td/> |
| 409 |
<td> |
| 410 |
<p id="N66841" style="display: none;"> |
| 411 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 412 |
<br/>In class edu.jas.gb.SolvableGroebnerBaseParallel<br/>At SolvableGroebnerBaseParallel.java:[lines 36-354]</p> |
| 413 |
</td> |
| 414 |
</tr> |
| 415 |
<tr class="tablerow0" onclick="toggleRow('N66876');"> |
| 416 |
<td> |
| 417 |
<span class="priority-2">SnVI</span> |
| 418 |
</td> |
| 419 |
<td>edu.jas.gb.SolvableGroebnerBaseSeqPairParallel is Serializable; consider declaring a serialVersionUID</td> |
| 420 |
</tr> |
| 421 |
<tr class="detailrow0"> |
| 422 |
<td/> |
| 423 |
<td> |
| 424 |
<p id="N66876" style="display: none;"> |
| 425 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 426 |
<br/>In class edu.jas.gb.SolvableGroebnerBaseSeqPairParallel<br/>At SolvableGroebnerBaseSeqPairParallel.java:[lines 39-346]</p> |
| 427 |
</td> |
| 428 |
</tr> |
| 429 |
<tr class="tablerow1" onclick="toggleRow('N66911');"> |
| 430 |
<td> |
| 431 |
<span class="priority-2">SnVI</span> |
| 432 |
</td> |
| 433 |
<td>edu.jas.gbufd.GroebnerBasePseudoParallel is Serializable; consider declaring a serialVersionUID</td> |
| 434 |
</tr> |
| 435 |
<tr class="detailrow1"> |
| 436 |
<td/> |
| 437 |
<td> |
| 438 |
<p id="N66911" style="display: none;"> |
| 439 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 440 |
<br/>In class edu.jas.gbufd.GroebnerBasePseudoParallel<br/>At GroebnerBasePseudoParallel.java:[lines 45-279]</p> |
| 441 |
</td> |
| 442 |
</tr> |
| 443 |
<tr class="tablerow0" onclick="toggleRow('N66946');"> |
| 444 |
<td> |
| 445 |
<span class="priority-2">SnVI</span> |
| 446 |
</td> |
| 447 |
<td>edu.jas.gbufd.GroebnerBasePseudoRecParallel is Serializable; consider declaring a serialVersionUID</td> |
| 448 |
</tr> |
| 449 |
<tr class="detailrow0"> |
| 450 |
<td/> |
| 451 |
<td> |
| 452 |
<p id="N66946" style="display: none;"> |
| 453 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 454 |
<br/>In class edu.jas.gbufd.GroebnerBasePseudoRecParallel<br/>At GroebnerBasePseudoRecParallel.java:[lines 46-350]</p> |
| 455 |
</td> |
| 456 |
</tr> |
| 457 |
<tr class="tablerow1" onclick="toggleRow('N67033');"> |
| 458 |
<td> |
| 459 |
<span class="priority-2">SnVI</span> |
| 460 |
</td> |
| 461 |
<td>edu.jas.poly.GenPolynomial is Serializable; consider declaring a serialVersionUID</td> |
| 462 |
</tr> |
| 463 |
<tr class="detailrow1"> |
| 464 |
<td/> |
| 465 |
<td> |
| 466 |
<p id="N67033" style="display: none;"> |
| 467 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 468 |
<br/>In class edu.jas.poly.GenPolynomial<br/>At GenPolynomial.java:[lines 47-2487]</p> |
| 469 |
</td> |
| 470 |
</tr> |
| 471 |
<tr class="tablerow0" onclick="toggleRow('N67753');"> |
| 472 |
<td> |
| 473 |
<span class="priority-2">SnVI</span> |
| 474 |
</td> |
| 475 |
<td>edu.jas.ufd.GCDProxy is Serializable; consider declaring a serialVersionUID</td> |
| 476 |
</tr> |
| 477 |
<tr class="detailrow0"> |
| 478 |
<td/> |
| 479 |
<td> |
| 480 |
<p id="N67753" style="display: none;"> |
| 481 |
<a href="#SE_NO_SERIALVERSIONID">Bug type SE_NO_SERIALVERSIONID (click for details)</a> |
| 482 |
<br/>In class edu.jas.ufd.GCDProxy<br/>At GCDProxy.java:[lines 30-583]</p> |
| 483 |
</td> |
| 484 |
</tr> |
| 485 |
</table> |
| 486 |
<h2> |
| 487 |
<a name="Warnings_MALICIOUS_CODE">Malicious code vulnerability Warnings</a> |
| 488 |
</h2> |
| 489 |
<table class="warningtable" width="100%" cellspacing="0"> |
| 490 |
<tr class="tableheader"> |
| 491 |
<th align="left">Code</th> |
| 492 |
<th align="left">Warning</th> |
| 493 |
</tr> |
| 494 |
<tr class="tablerow1" onclick="toggleRow('N66981');"> |
| 495 |
<td> |
| 496 |
<span class="priority-2">MS</span> |
| 497 |
</td> |
| 498 |
<td>edu.jas.kern.ComputerThreads.NO_THREADS isn't final and can't be protected from malicious code </td> |
| 499 |
</tr> |
| 500 |
<tr class="detailrow1"> |
| 501 |
<td/> |
| 502 |
<td> |
| 503 |
<p id="N66981" style="display: none;"> |
| 504 |
<a href="#MS_CANNOT_BE_FINAL">Bug type MS_CANNOT_BE_FINAL (click for details)</a> |
| 505 |
<br/>In class edu.jas.kern.ComputerThreads<br/>Field edu.jas.kern.ComputerThreads.NO_THREADS<br/>At ComputerThreads.java:[line 42]</p> |
| 506 |
</td> |
| 507 |
</tr> |
| 508 |
</table> |
| 509 |
<h2> |
| 510 |
<a name="Warnings_STYLE">Dodgy code Warnings</a> |
| 511 |
</h2> |
| 512 |
<table class="warningtable" width="100%" cellspacing="0"> |
| 513 |
<tr class="tableheader"> |
| 514 |
<th align="left">Code</th> |
| 515 |
<th align="left">Warning</th> |
| 516 |
</tr> |
| 517 |
<tr class="tablerow1" onclick="toggleRow('N65777');"> |
| 518 |
<td> |
| 519 |
<span class="priority-2">BC</span> |
| 520 |
</td> |
| 521 |
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial)</td> |
| 522 |
</tr> |
| 523 |
<tr class="detailrow1"> |
| 524 |
<td/> |
| 525 |
<td> |
| 526 |
<p id="N65777" style="display: none;"> |
| 527 |
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a> |
| 528 |
<br/>In class edu.jas.application.SolvableLocalResidueRing<br/>In method edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableLocalResidueRing.java:[line 123]</p> |
| 529 |
</td> |
| 530 |
</tr> |
| 531 |
<tr class="tablerow0" onclick="toggleRow('N65864');"> |
| 532 |
<td> |
| 533 |
<span class="priority-2">BC</span> |
| 534 |
</td> |
| 535 |
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial, GenPolynomial)</td> |
| 536 |
</tr> |
| 537 |
<tr class="detailrow0"> |
| 538 |
<td/> |
| 539 |
<td> |
| 540 |
<p id="N65864" style="display: none;"> |
| 541 |
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a> |
| 542 |
<br/>In class edu.jas.application.SolvableLocalResidueRing<br/>In method edu.jas.application.SolvableLocalResidueRing.create(GenPolynomial, GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableLocalResidueRing.java:[line 132]</p> |
| 543 |
</td> |
| 544 |
</tr> |
| 545 |
<tr class="tablerow1" onclick="toggleRow('N65951');"> |
| 546 |
<td> |
| 547 |
<span class="priority-2">BC</span> |
| 548 |
</td> |
| 549 |
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalRing.create(GenPolynomial)</td> |
| 550 |
</tr> |
| 551 |
<tr class="detailrow1"> |
| 552 |
<td/> |
| 553 |
<td> |
| 554 |
<p id="N65951" style="display: none;"> |
| 555 |
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a> |
| 556 |
<br/>In class edu.jas.application.SolvableLocalRing<br/>In method edu.jas.application.SolvableLocalRing.create(GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableLocalRing.java:[line 121]</p> |
| 557 |
</td> |
| 558 |
</tr> |
| 559 |
<tr class="tablerow0" onclick="toggleRow('N66038');"> |
| 560 |
<td> |
| 561 |
<span class="priority-2">BC</span> |
| 562 |
</td> |
| 563 |
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableLocalRing.create(GenPolynomial, GenPolynomial)</td> |
| 564 |
</tr> |
| 565 |
<tr class="detailrow0"> |
| 566 |
<td/> |
| 567 |
<td> |
| 568 |
<p id="N66038" style="display: none;"> |
| 569 |
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a> |
| 570 |
<br/>In class edu.jas.application.SolvableLocalRing<br/>In method edu.jas.application.SolvableLocalRing.create(GenPolynomial, GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableLocalRing.java:[line 130]</p> |
| 571 |
</td> |
| 572 |
</tr> |
| 573 |
<tr class="tablerow1" onclick="toggleRow('N66125');"> |
| 574 |
<td> |
| 575 |
<span class="priority-2">BC</span> |
| 576 |
</td> |
| 577 |
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableResidueRing.create(GenPolynomial)</td> |
| 578 |
</tr> |
| 579 |
<tr class="detailrow1"> |
| 580 |
<td/> |
| 581 |
<td> |
| 582 |
<p id="N66125" style="display: none;"> |
| 583 |
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a> |
| 584 |
<br/>In class edu.jas.application.SolvableResidueRing<br/>In method edu.jas.application.SolvableResidueRing.create(GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableResidueRing.java:[line 124]</p> |
| 585 |
</td> |
| 586 |
</tr> |
| 587 |
<tr class="tablerow0" onclick="toggleRow('N66212');"> |
| 588 |
<td> |
| 589 |
<span class="priority-2">BC</span> |
| 590 |
</td> |
| 591 |
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.application.SolvableResidueRing.create(GenPolynomial, GenPolynomial)</td> |
| 592 |
</tr> |
| 593 |
<tr class="detailrow0"> |
| 594 |
<td/> |
| 595 |
<td> |
| 596 |
<p id="N66212" style="display: none;"> |
| 597 |
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a> |
| 598 |
<br/>In class edu.jas.application.SolvableResidueRing<br/>In method edu.jas.application.SolvableResidueRing.create(GenPolynomial, GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableResidueRing.java:[line 136]</p> |
| 599 |
</td> |
| 600 |
</tr> |
| 601 |
<tr class="tablerow1" onclick="toggleRow('N66387');"> |
| 602 |
<td> |
| 603 |
<span class="priority-2">BC</span> |
| 604 |
</td> |
| 605 |
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.fd.SolvableQuotientRing.create(GenPolynomial)</td> |
| 606 |
</tr> |
| 607 |
<tr class="detailrow1"> |
| 608 |
<td/> |
| 609 |
<td> |
| 610 |
<p id="N66387" style="display: none;"> |
| 611 |
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a> |
| 612 |
<br/>In class edu.jas.fd.SolvableQuotientRing<br/>In method edu.jas.fd.SolvableQuotientRing.create(GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableQuotientRing.java:[line 81]</p> |
| 613 |
</td> |
| 614 |
</tr> |
| 615 |
<tr class="tablerow0" onclick="toggleRow('N66474');"> |
| 616 |
<td> |
| 617 |
<span class="priority-2">BC</span> |
| 618 |
</td> |
| 619 |
<td>Unchecked/unconfirmed cast from edu.jas.poly.GenPolynomial<C> to edu.jas.poly.GenSolvablePolynomial in edu.jas.fd.SolvableQuotientRing.create(GenPolynomial, GenPolynomial)</td> |
| 620 |
</tr> |
| 621 |
<tr class="detailrow0"> |
| 622 |
<td/> |
| 623 |
<td> |
| 624 |
<p id="N66474" style="display: none;"> |
| 625 |
<a href="#BC_UNCONFIRMED_CAST">Bug type BC_UNCONFIRMED_CAST (click for details)</a> |
| 626 |
<br/>In class edu.jas.fd.SolvableQuotientRing<br/>In method edu.jas.fd.SolvableQuotientRing.create(GenPolynomial, GenPolynomial)<br/>Actual type edu.jas.poly.GenPolynomial<C><br/>Expected edu.jas.poly.GenSolvablePolynomial<br/>Value loaded from ?<br/>At SolvableQuotientRing.java:[line 90]</p> |
| 627 |
</td> |
| 628 |
</tr> |
| 629 |
<tr class="tablerow1" onclick="toggleRow('N67271');"> |
| 630 |
<td> |
| 631 |
<span class="priority-2">BC</span> |
| 632 |
</td> |
| 633 |
<td>instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.evalAsRightRecursivePolynomial(), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial</td> |
| 634 |
</tr> |
| 635 |
<tr class="detailrow1"> |
| 636 |
<td/> |
| 637 |
<td> |
| 638 |
<p id="N67271" style="display: none;"> |
| 639 |
<a href="#BC_VACUOUS_INSTANCEOF">Bug type BC_VACUOUS_INSTANCEOF (click for details)</a> |
| 640 |
<br/>In class edu.jas.poly.RecSolvablePolynomial<br/>In method edu.jas.poly.RecSolvablePolynomial.evalAsRightRecursivePolynomial()<br/>Actual type edu.jas.poly.RecSolvablePolynomial<br/>Expected edu.jas.poly.RecSolvablePolynomial<br/>At RecSolvablePolynomial.java:[line 764]</p> |
| 641 |
</td> |
| 642 |
</tr> |
| 643 |
<tr class="tablerow0" onclick="toggleRow('N67351');"> |
| 644 |
<td> |
| 645 |
<span class="priority-2">BC</span> |
| 646 |
</td> |
| 647 |
<td>instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.isRightRecursivePolynomial(GenSolvablePolynomial), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial</td> |
| 648 |
</tr> |
| 649 |
<tr class="detailrow0"> |
| 650 |
<td/> |
| 651 |
<td> |
| 652 |
<p id="N67351" style="display: none;"> |
| 653 |
<a href="#BC_VACUOUS_INSTANCEOF">Bug type BC_VACUOUS_INSTANCEOF (click for details)</a> |
| 654 |
<br/>In class edu.jas.poly.RecSolvablePolynomial<br/>In method edu.jas.poly.RecSolvablePolynomial.isRightRecursivePolynomial(GenSolvablePolynomial)<br/>Actual type edu.jas.poly.RecSolvablePolynomial<br/>Expected edu.jas.poly.RecSolvablePolynomial<br/>At RecSolvablePolynomial.java:[line 806]</p> |
| 655 |
</td> |
| 656 |
</tr> |
| 657 |
<tr class="tablerow1" onclick="toggleRow('N67431');"> |
| 658 |
<td> |
| 659 |
<span class="priority-2">BC</span> |
| 660 |
</td> |
| 661 |
<td>instanceof will always return true for all non-null values in edu.jas.poly.RecSolvablePolynomial.rightRecursivePolynomial(), since all edu.jas.poly.RecSolvablePolynomial are instances of edu.jas.poly.RecSolvablePolynomial</td> |
| 662 |
</tr> |
| 663 |
<tr class="detailrow1"> |
| 664 |
<td/> |
| 665 |
<td> |
| 666 |
<p id="N67431" style="display: none;"> |
| 667 |
<a href="#BC_VACUOUS_INSTANCEOF">Bug type BC_VACUOUS_INSTANCEOF (click for details)</a> |
| 668 |
<br/>In class edu.jas.poly.RecSolvablePolynomial<br/>In method edu.jas.poly.RecSolvablePolynomial.rightRecursivePolynomial()<br/>Actual type edu.jas.poly.RecSolvablePolynomial<br/>Expected edu.jas.poly.RecSolvablePolynomial<br/>At RecSolvablePolynomial.java:[line 723]</p> |
| 669 |
</td> |
| 670 |
</tr> |
| 671 |
<tr class="tablerow0" onclick="toggleRow('N65648');"> |
| 672 |
<td> |
| 673 |
<span class="priority-2">DB</span> |
| 674 |
</td> |
| 675 |
<td>edu.jas.application.RingFactoryTokenizer.nextCoefficientRing() uses the same code for two branches</td> |
| 676 |
</tr> |
| 677 |
<tr class="detailrow0"> |
| 678 |
<td/> |
| 679 |
<td> |
| 680 |
<p id="N65648" style="display: none;"> |
| 681 |
<a href="#DB_DUPLICATE_BRANCHES">Bug type DB_DUPLICATE_BRANCHES (click for details)</a> |
| 682 |
<br/>In class edu.jas.application.RingFactoryTokenizer<br/>In method edu.jas.application.RingFactoryTokenizer.nextCoefficientRing()<br/>At RingFactoryTokenizer.java:[line 471]<br/>At RingFactoryTokenizer.java:[line 473]</p> |
| 683 |
</td> |
| 684 |
</tr> |
| 685 |
<tr class="tablerow1" onclick="toggleRow('N67068');"> |
| 686 |
<td> |
| 687 |
<span class="priority-2">DB</span> |
| 688 |
</td> |
| 689 |
<td>edu.jas.poly.GenPolynomialTokenizer.nextCoefficientRing() uses the same code for two branches</td> |
| 690 |
</tr> |
| 691 |
<tr class="detailrow1"> |
| 692 |
<td/> |
| 693 |
<td> |
| 694 |
<p id="N67068" style="display: none;"> |
| 695 |
<a href="#DB_DUPLICATE_BRANCHES">Bug type DB_DUPLICATE_BRANCHES (click for details)</a> |
| 696 |
<br/>In class edu.jas.poly.GenPolynomialTokenizer<br/>In method edu.jas.poly.GenPolynomialTokenizer.nextCoefficientRing()<br/>At GenPolynomialTokenizer.java:[line 826]<br/>At GenPolynomialTokenizer.java:[line 828]</p> |
| 697 |
</td> |
| 698 |
</tr> |
| 699 |
<tr class="tablerow0" onclick="toggleRow('N67131');"> |
| 700 |
<td> |
| 701 |
<span class="priority-2">SF</span> |
| 702 |
</td> |
| 703 |
<td>Switch statement found in edu.jas.poly.GenPolynomialTokenizer.nextPolynomial() where one case falls through to the next case</td> |
| 704 |
</tr> |
| 705 |
<tr class="detailrow0"> |
| 706 |
<td/> |
| 707 |
<td> |
| 708 |
<p id="N67131" style="display: none;"> |
| 709 |
<a href="#SF_SWITCH_FALLTHROUGH">Bug type SF_SWITCH_FALLTHROUGH (click for details)</a> |
| 710 |
<br/>In class edu.jas.poly.GenPolynomialTokenizer<br/>In method edu.jas.poly.GenPolynomialTokenizer.nextPolynomial()<br/>At GenPolynomialTokenizer.java:[lines 329-332]</p> |
| 711 |
</td> |
| 712 |
</tr> |
| 713 |
<tr class="tablerow1" onclick="toggleRow('N66299');"> |
| 714 |
<td> |
| 715 |
<span class="priority-2">UCF</span> |
| 716 |
</td> |
| 717 |
<td>Useless control flow in edu.jas.fd.GCDLeftRightTest.testBaseQR()</td> |
| 718 |
</tr> |
| 719 |
<tr class="detailrow1"> |
| 720 |
<td/> |
| 721 |
<td> |
| 722 |
<p id="N66299" style="display: none;"> |
| 723 |
<a href="#UCF_USELESS_CONTROL_FLOW">Bug type UCF_USELESS_CONTROL_FLOW (click for details)</a> |
| 724 |
<br/>In class edu.jas.fd.GCDLeftRightTest<br/>In method edu.jas.fd.GCDLeftRightTest.testBaseQR()<br/>At GCDLeftRightTest.java:[line 591]</p> |
| 725 |
</td> |
| 726 |
</tr> |
| 727 |
</table> |
| 728 |
<h1> |
| 729 |
<a name="Details">Details</a> |
| 730 |
</h1> |
| 731 |
<h2> |
| 732 |
<a name="BC_VACUOUS_INSTANCEOF">BC_VACUOUS_INSTANCEOF: instanceof will always return true</a> |
| 733 |
</h2> |
| 734 |
|
| 735 |
<p> |
| 736 |
This instanceof test will always return true (unless the value being tested is null). |
| 737 |
Although this is safe, make sure it isn't |
| 738 |
an indication of some misunderstanding or some other logic error. |
| 739 |
If you really want to test the value for being null, perhaps it would be clearer to do |
| 740 |
better to do a null test rather than an instanceof test. |
| 741 |
</p> |
| 742 |
|
| 743 |
|
| 744 |
<h2> |
| 745 |
<a name="BC_UNCONFIRMED_CAST">BC_UNCONFIRMED_CAST: Unchecked/unconfirmed cast</a> |
| 746 |
</h2> |
| 747 |
|
| 748 |
<p> |
| 749 |
This cast is unchecked, and not all instances of the type casted from can be cast to |
| 750 |
the type it is being cast to. Check that your program logic ensures that this |
| 751 |
cast will not fail. |
| 752 |
</p> |
| 753 |
|
| 754 |
|
| 755 |
<h2> |
| 756 |
<a name="DB_DUPLICATE_BRANCHES">DB_DUPLICATE_BRANCHES: Method uses the same code for two branches</a> |
| 757 |
</h2> |
| 758 |
|
| 759 |
<p> |
| 760 |
This method uses the same code to implement two branches of a conditional branch. |
| 761 |
Check to ensure that this isn't a coding mistake. |
| 762 |
</p> |
| 763 |
|
| 764 |
|
| 765 |
<h2> |
| 766 |
<a name="MS_CANNOT_BE_FINAL">MS_CANNOT_BE_FINAL: Field isn't final and can't be protected from malicious code</a> |
| 767 |
</h2> |
| 768 |
|
| 769 |
<p> |
| 770 |
A mutable static field could be changed by malicious code or |
| 771 |
by accident from another package. |
| 772 |
Unfortunately, the way the field is used doesn't allow |
| 773 |
any easy fix to this problem.</p> |
| 774 |
|
| 775 |
|
| 776 |
<h2> |
| 777 |
<a name="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS">NM_SAME_SIMPLE_NAME_AS_SUPERCLASS: Class names shouldn't shadow simple name of superclass</a> |
| 778 |
</h2> |
| 779 |
|
| 780 |
<p> This class has a simple name that is identical to that of its superclass, except |
| 781 |
that its superclass is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>). |
| 782 |
This can be exceptionally confusing, create lots of situations in which you have to look at import statements |
| 783 |
to resolve references and creates many |
| 784 |
opportunities to accidentally define methods that do not override methods in their superclasses. |
| 785 |
</p> |
| 786 |
|
| 787 |
|
| 788 |
<h2> |
| 789 |
<a name="NM_METHOD_NAMING_CONVENTION">NM_METHOD_NAMING_CONVENTION: Method names should start with a lower case letter</a> |
| 790 |
</h2> |
| 791 |
|
| 792 |
<p> |
| 793 |
Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized. |
| 794 |
</p> |
| 795 |
|
| 796 |
|
| 797 |
<h2> |
| 798 |
<a name="OS_OPEN_STREAM">OS_OPEN_STREAM: Method may fail to close stream</a> |
| 799 |
</h2> |
| 800 |
|
| 801 |
<p> The method creates an IO stream object, does not assign it to any |
| 802 |
fields, pass it to other methods that might close it, |
| 803 |
or return it, and does not appear to close |
| 804 |
the stream on all paths out of the method. This may result in |
| 805 |
a file descriptor leak. It is generally a good |
| 806 |
idea to use a <code>finally</code> block to ensure that streams are |
| 807 |
closed.</p> |
| 808 |
|
| 809 |
|
| 810 |
<h2> |
| 811 |
<a name="RV_NEGATING_RESULT_OF_COMPARETO">RV_NEGATING_RESULT_OF_COMPARETO: Negating the result of compareTo()/compare()</a> |
| 812 |
</h2> |
| 813 |
|
| 814 |
<p> This code negatives the return value of a compareTo or compare method. |
| 815 |
This is a questionable or bad programming practice, since if the return |
| 816 |
value is Integer.MIN_VALUE, negating the return value won't |
| 817 |
negate the sign of the result. You can achieve the same intended result |
| 818 |
by reversing the order of the operands rather than by negating the results. |
| 819 |
</p> |
| 820 |
|
| 821 |
|
| 822 |
<h2> |
| 823 |
<a name="SF_SWITCH_FALLTHROUGH">SF_SWITCH_FALLTHROUGH: Switch statement found where one case falls through to the next case</a> |
| 824 |
</h2> |
| 825 |
|
| 826 |
<p> This method contains a switch statement where one case branch will fall through to the next case. |
| 827 |
Usually you need to end this case with a break or return.</p> |
| 828 |
|
| 829 |
|
| 830 |
<h2> |
| 831 |
<a name="SE_NO_SERIALVERSIONID">SE_NO_SERIALVERSIONID: Class is Serializable, but doesn't define serialVersionUID</a> |
| 832 |
</h2> |
| 833 |
|
| 834 |
<p> This class implements the <code>Serializable</code> interface, but does |
| 835 |
not define a <code>serialVersionUID</code> field. |
| 836 |
A change as simple as adding a reference to a .class object |
| 837 |
will add synthetic fields to the class, |
| 838 |
which will unfortunately change the implicit |
| 839 |
serialVersionUID (e.g., adding a reference to <code>String.class</code> |
| 840 |
will generate a static field <code>class$java$lang$String</code>). |
| 841 |
Also, different source code to bytecode compilers may use different |
| 842 |
naming conventions for synthetic variables generated for |
| 843 |
references to class objects or inner classes. |
| 844 |
To ensure interoperability of Serializable across versions, |
| 845 |
consider adding an explicit serialVersionUID.</p> |
| 846 |
|
| 847 |
|
| 848 |
<h2> |
| 849 |
<a name="UCF_USELESS_CONTROL_FLOW">UCF_USELESS_CONTROL_FLOW: Useless control flow</a> |
| 850 |
</h2> |
| 851 |
|
| 852 |
<p> This method contains a useless control flow statement, where |
| 853 |
control flow continues onto the same place regardless of whether or not |
| 854 |
the branch is taken. For example, |
| 855 |
this is caused by having an empty statement |
| 856 |
block for an <code>if</code> statement:</p> |
| 857 |
<pre> |
| 858 |
if (argv.length == 0) { |
| 859 |
// TODO: handle this case |
| 860 |
} |
| 861 |
</pre> |
| 862 |
|
| 863 |
</body> |
| 864 |
</html> |