| 1 |
/* |
| 2 |
Copyright 2020 The Kubernetes Authors. |
| 3 |
|
| 4 |
Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 |
you may not use this file except in compliance with the License. |
| 6 |
You may obtain a copy of the License at |
| 7 |
|
| 8 |
http://www.apache.org/licenses/LICENSE-2.0 |
| 9 |
|
| 10 |
Unless required by applicable law or agreed to in writing, software |
| 11 |
distributed under the License is distributed on an "AS IS" BASIS, |
| 12 |
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 |
See the License for the specific language governing permissions and |
| 14 |
limitations under the License. |
| 15 |
*/ |
| 16 |
|
| 17 |
package deprecation |
| 18 |
|
| 19 |
import ( |
| 20 |
"testing" |
| 21 |
|
| 22 |
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" |
| 23 |
"k8s.io/apimachinery/pkg/runtime" |
| 24 |
"k8s.io/apimachinery/pkg/runtime/schema" |
| 25 |
"k8s.io/apimachinery/pkg/version" |
| 26 |
) |
| 27 |
|
| 28 |
func TestMajorMinor(t *testing.T) { |
| 29 |
tests := []struct { |
| 30 |
name string |
| 31 |
v version.Info |
| 32 |
expectMajor int |
| 33 |
expectMinor int |
| 34 |
expectErr bool |
| 35 |
}{ |
| 36 |
{ |
| 37 |
name: "empty", |
| 38 |
v: version.Info{Major: "", Minor: ""}, |
| 39 |
expectMajor: 0, |
| 40 |
expectMinor: 0, |
| 41 |
expectErr: true, |
| 42 |
}, |
| 43 |
{ |
| 44 |
name: "non-numeric major", |
| 45 |
v: version.Info{Major: "A", Minor: "0"}, |
| 46 |
expectMajor: 0, |
| 47 |
expectMinor: 0, |
| 48 |
expectErr: true, |
| 49 |
}, |
| 50 |
{ |
| 51 |
name: "non-numeric minor", |
| 52 |
v: version.Info{Major: "1", Minor: "A"}, |
| 53 |
expectMajor: 0, |
| 54 |
expectMinor: 0, |
| 55 |
expectErr: true, |
| 56 |
}, |
| 57 |
{ |
| 58 |
name: "valid", |
| 59 |
v: version.Info{Major: "1", Minor: "2"}, |
| 60 |
expectMajor: 1, |
| 61 |
expectMinor: 2, |
| 62 |
expectErr: false, |
| 63 |
}, |
| 64 |
{ |
| 65 |
name: "valid zero", |
| 66 |
v: version.Info{Major: "0", Minor: "0"}, |
| 67 |
expectMajor: 0, |
| 68 |
expectMinor: 0, |
| 69 |
expectErr: false, |
| 70 |
}, |
| 71 |
{ |
| 72 |
name: "valid zero decimal", |
| 73 |
v: version.Info{Major: "01", Minor: "02"}, |
| 74 |
expectMajor: 1, |
| 75 |
expectMinor: 2, |
| 76 |
expectErr: false, |
| 77 |
}, |
| 78 |
{ |
| 79 |
name: "valid with extra minor", |
| 80 |
v: version.Info{Major: "1", Minor: "2+"}, |
| 81 |
expectMajor: 1, |
| 82 |
expectMinor: 2, |
| 83 |
expectErr: false, |
| 84 |
}, |
| 85 |
{ |
| 86 |
name: "valid with extra minor", |
| 87 |
v: version.Info{Major: "1", Minor: "2.3"}, |
| 88 |
expectMajor: 1, |
| 89 |
expectMinor: 2, |
| 90 |
expectErr: false, |
| 91 |
}, |
| 92 |
} |
| 93 |
for _, tt := range tests { |
| 94 |
t.Run(tt.name, func(t *testing.T) { |
| 95 |
major, minor, err := MajorMinor(tt.v) |
| 96 |
if (err != nil) != tt.expectErr { |
| 97 |
t.Errorf("MajorMinor() error = %v, wantErr %v", err, tt.expectErr) |
| 98 |
return |
| 99 |
} |
| 100 |
if major != tt.expectMajor { |
| 101 |
t.Errorf("MajorMinor() major = %v, want %v", major, tt.expectMajor) |
| 102 |
} |
| 103 |
if minor != tt.expectMinor { |
| 104 |
t.Errorf("MajorMinor() minor = %v, want %v", minor, tt.expectMinor) |
| 105 |
} |
| 106 |
}) |
| 107 |
} |
| 108 |
} |
| 109 |
|
| 110 |
func TestIsDeprecated(t *testing.T) { |
| 111 |
tests := []struct { |
| 112 |
name string |
| 113 |
|
| 114 |
obj runtime.Object |
| 115 |
currentMajor int |
| 116 |
currentMinor int |
| 117 |
|
| 118 |
want bool |
| 119 |
}{ |
| 120 |
{ |
| 121 |
name: "no interface", |
| 122 |
obj: &fakeObject{}, |
| 123 |
currentMajor: 0, |
| 124 |
currentMinor: 0, |
| 125 |
want: false, |
| 126 |
}, |
| 127 |
{ |
| 128 |
name: "interface, zero-value", |
| 129 |
obj: &fakeDeprecatedObject{}, |
| 130 |
currentMajor: 0, |
| 131 |
currentMinor: 0, |
| 132 |
want: false, |
| 133 |
}, |
| 134 |
{ |
| 135 |
name: "interface, non-zero-value, no current value", |
| 136 |
obj: &fakeDeprecatedObject{major: 10, minor: 20}, |
| 137 |
currentMajor: 0, |
| 138 |
currentMinor: 0, |
| 139 |
want: true, |
| 140 |
}, |
| 141 |
{ |
| 142 |
name: "interface, non-zero-value matching major, minor", |
| 143 |
obj: &fakeDeprecatedObject{major: 10, minor: 20}, |
| 144 |
currentMajor: 10, |
| 145 |
currentMinor: 20, |
| 146 |
want: true, |
| 147 |
}, |
| 148 |
{ |
| 149 |
name: "interface, non-zero-value after major, after minor", |
| 150 |
obj: &fakeDeprecatedObject{major: 10, minor: 20}, |
| 151 |
currentMajor: 9, |
| 152 |
currentMinor: 19, |
| 153 |
want: false, |
| 154 |
}, |
| 155 |
{ |
| 156 |
name: "interface, non-zero-value after major, before minor", |
| 157 |
obj: &fakeDeprecatedObject{major: 10, minor: 20}, |
| 158 |
currentMajor: 9, |
| 159 |
currentMinor: 21, |
| 160 |
want: false, |
| 161 |
}, |
| 162 |
{ |
| 163 |
name: "interface, non-zero-value before major, after minor", |
| 164 |
obj: &fakeDeprecatedObject{major: 10, minor: 20}, |
| 165 |
currentMajor: 11, |
| 166 |
currentMinor: 19, |
| 167 |
want: true, |
| 168 |
}, |
| 169 |
{ |
| 170 |
name: "interface, non-zero-value before major, before minor", |
| 171 |
obj: &fakeDeprecatedObject{major: 10, minor: 20}, |
| 172 |
currentMajor: 11, |
| 173 |
currentMinor: 21, |
| 174 |
want: true, |
| 175 |
}, |
| 176 |
} |
| 177 |
for _, tt := range tests { |
| 178 |
t.Run(tt.name, func(t *testing.T) { |
| 179 |
if got := IsDeprecated(tt.obj, tt.currentMajor, tt.currentMinor); got != tt.want { |
| 180 |
t.Errorf("IsDeprecated() = %v, want %v", got, tt.want) |
| 181 |
} |
| 182 |
}) |
| 183 |
} |
| 184 |
} |
| 185 |
|
| 186 |
func TestRemovedRelease(t *testing.T) { |
| 187 |
tests := []struct { |
| 188 |
name string |
| 189 |
obj runtime.Object |
| 190 |
want string |
| 191 |
}{ |
| 192 |
{ |
| 193 |
name: "no interface", |
| 194 |
obj: &fakeObject{}, |
| 195 |
want: "", |
| 196 |
}, |
| 197 |
{ |
| 198 |
name: "interface, zero-value", |
| 199 |
obj: &fakeRemovedObject{removedMajor: 0, removedMinor: 0}, |
| 200 |
want: "", |
| 201 |
}, |
| 202 |
{ |
| 203 |
name: "interface, non-zero major", |
| 204 |
obj: &fakeRemovedObject{removedMajor: 1, removedMinor: 0}, |
| 205 |
want: "1.0", |
| 206 |
}, |
| 207 |
{ |
| 208 |
name: "interface, non-zero minor", |
| 209 |
obj: &fakeRemovedObject{removedMajor: 0, removedMinor: 1}, |
| 210 |
want: "0.1", |
| 211 |
}, |
| 212 |
{ |
| 213 |
name: "interface, non-zero", |
| 214 |
obj: &fakeRemovedObject{removedMajor: 1, removedMinor: 2}, |
| 215 |
want: "1.2", |
| 216 |
}, |
| 217 |
} |
| 218 |
for _, tt := range tests { |
| 219 |
t.Run(tt.name, func(t *testing.T) { |
| 220 |
if got := RemovedRelease(tt.obj); got != tt.want { |
| 221 |
t.Errorf("RemovedRelease() = %v, want %v", got, tt.want) |
| 222 |
} |
| 223 |
}) |
| 224 |
} |
| 225 |
} |
| 226 |
|
| 227 |
func TestWarningMessage(t *testing.T) { |
| 228 |
tests := []struct { |
| 229 |
name string |
| 230 |
obj runtime.Object |
| 231 |
gvk schema.GroupVersionKind |
| 232 |
want string |
| 233 |
}{ |
| 234 |
{ |
| 235 |
name: "no interface, zero-value", |
| 236 |
obj: &fakeObject{}, |
| 237 |
want: "", |
| 238 |
}, |
| 239 |
{ |
| 240 |
name: "deprecated interface, zero-value", |
| 241 |
obj: &fakeDeprecatedObject{major: 0, minor: 0}, |
| 242 |
gvk: schema.GroupVersionKind{}, |
| 243 |
want: "", |
| 244 |
}, |
| 245 |
{ |
| 246 |
name: "deprecated interface, non-zero-value", |
| 247 |
obj: &fakeDeprecatedObject{major: 1, minor: 2}, |
| 248 |
gvk: schema.GroupVersionKind{Group: "mygroup", Version: "v1", Kind: "MyKind"}, |
| 249 |
want: "mygroup/v1 MyKind is deprecated in v1.2+", |
| 250 |
}, |
| 251 |
{ |
| 252 |
name: "removed interface, zero-value removal version", |
| 253 |
obj: &fakeRemovedObject{major: 1, minor: 2}, |
| 254 |
gvk: schema.GroupVersionKind{Group: "mygroup", Version: "v1", Kind: "MyKind"}, |
| 255 |
want: "mygroup/v1 MyKind is deprecated in v1.2+", |
| 256 |
}, |
| 257 |
{ |
| 258 |
name: "removed interface, non-zero-value removal version", |
| 259 |
obj: &fakeRemovedObject{major: 1, minor: 2, removedMajor: 3, removedMinor: 4}, |
| 260 |
gvk: schema.GroupVersionKind{Group: "mygroup", Version: "v1", Kind: "MyKind"}, |
| 261 |
want: "mygroup/v1 MyKind is deprecated in v1.2+, unavailable in v3.4+", |
| 262 |
}, |
| 263 |
{ |
| 264 |
name: "replaced interface, zero-value replacement", |
| 265 |
obj: &fakeReplacedObject{major: 1, minor: 2, removedMajor: 3, removedMinor: 4}, |
| 266 |
gvk: schema.GroupVersionKind{Group: "mygroup", Version: "v1", Kind: "MyKind"}, |
| 267 |
want: "mygroup/v1 MyKind is deprecated in v1.2+, unavailable in v3.4+", |
| 268 |
}, |
| 269 |
{ |
| 270 |
name: "replaced interface, non-zero-value replacement", |
| 271 |
obj: &fakeReplacedObject{major: 1, minor: 2, removedMajor: 3, removedMinor: 4, replacement: schema.GroupVersionKind{Group: "anothergroup", Version: "v2", Kind: "AnotherKind"}}, |
| 272 |
gvk: schema.GroupVersionKind{Group: "mygroup", Version: "v1", Kind: "MyKind"}, |
| 273 |
want: "mygroup/v1 MyKind is deprecated in v1.2+, unavailable in v3.4+; use anothergroup/v2 AnotherKind", |
| 274 |
}, |
| 275 |
} |
| 276 |
for _, tt := range tests { |
| 277 |
t.Run(tt.name, func(t *testing.T) { |
| 278 |
tt.obj.GetObjectKind().SetGroupVersionKind(tt.gvk) |
| 279 |
if got := WarningMessage(tt.obj); got != tt.want { |
| 280 |
t.Errorf("WarningMessage() = %v, want %v", got, tt.want) |
| 281 |
} |
| 282 |
}) |
| 283 |
} |
| 284 |
} |
| 285 |
|
| 286 |
type fakeObject struct { |
| 287 |
unstructured.Unstructured |
| 288 |
} |
| 289 |
type fakeDeprecatedObject struct { |
| 290 |
unstructured.Unstructured |
| 291 |
major int |
| 292 |
minor int |
| 293 |
} |
| 294 |
|
| 295 |
func (f *fakeDeprecatedObject) APILifecycleDeprecated() (int, int) { return f.major, f.minor } |
| 296 |
|
| 297 |
type fakeRemovedObject struct { |
| 298 |
unstructured.Unstructured |
| 299 |
major int |
| 300 |
minor int |
| 301 |
removedMajor int |
| 302 |
removedMinor int |
| 303 |
} |
| 304 |
|
| 305 |
func (f *fakeRemovedObject) APILifecycleDeprecated() (int, int) { return f.major, f.minor } |
| 306 |
func (f *fakeRemovedObject) APILifecycleRemoved() (int, int) { return f.removedMajor, f.removedMinor } |
| 307 |
|
| 308 |
type fakeReplacedObject struct { |
| 309 |
unstructured.Unstructured |
| 310 |
major int |
| 311 |
minor int |
| 312 |
replacement schema.GroupVersionKind |
| 313 |
removedMajor int |
| 314 |
removedMinor int |
| 315 |
} |
| 316 |
|
| 317 |
func (f *fakeReplacedObject) APILifecycleDeprecated() (int, int) { return f.major, f.minor } |
| 318 |
func (f *fakeReplacedObject) APILifecycleRemoved() (int, int) { return f.removedMajor, f.removedMinor } |
| 319 |
func (f *fakeReplacedObject) APILifecycleReplacement() schema.GroupVersionKind { return f.replacement } |