Debian Codegraph @

staticcheck/sa5001/testdata/go1.0/CheckEarlyDefer/CheckEarlyDefer.go

raw
1 package pkg
2
3 import (
4 "io"
5 "os"
6 )
7
8 func fn1() (io.ReadCloser, error) {
9 return nil, nil
10 }
11
12 type T struct {
13 rc io.ReadCloser
14 }
15
16 type T2 struct{}
17
18 func (T2) create() (io.ReadCloser, error) {
19 return nil, nil
20 }
21
22 func fn3() (T, error) {
23 return T{}, nil
24 }
25
26 func fn2() {
27 rc, err := fn1()
28 defer rc.Close() //@ diag(`should check error returned from fn1() before deferring rc.Close`)
29 if err != nil {
30 println()
31 }
32
33 rc, _ = fn1()
34 defer rc.Close()
35
36 rc, err = fn1()
37 if err != nil {
38 println()
39 }
40 defer rc.Close()
41
42 t, err := fn3()
43 defer t.rc.Close() //@ diag(`should check error returned from fn3() before deferring t.rc.Close`)
44 if err != nil {
45 println()
46 }
47
48 fp, err := os.Open("path")
49 defer fp.Close() //@ diag(`should check error returned from os.Open() before deferring fp.Close()`)
50 if err != nil {
51 println()
52 }
53
54 var t2 T2
55 rc2, err := t2.create()
56 defer rc2.Close() //@ diag(`should check error returned from t2.create() before deferring rc2.Close()`)
57 if err != nil {
58 println()
59 }
60
61 // Don't flag this, we're closing a different reader
62 x, err := fn1()
63 defer rc.Close()
64 if err != nil {
65 println()
66 }
67 _ = x
68 }