| 1 |
## Why do we have this "otel/baggage" folder? |
| 2 |
|
| 3 |
The root sentry-go SDK (namely, the Dynamic Sampling functionality) needs an implementation of the [baggage spec](https://www.w3.org/TR/baggage/). |
| 4 |
For that reason, we've taken the existing baggage implementation from the [opentelemetry-go](https://github.com/open-telemetry/opentelemetry-go/) repository, and fixed a few things that in our opinion were violating the specification. |
| 5 |
|
| 6 |
These issues are: |
| 7 |
1. Baggage string value `one%20two` should be properly parsed as "one two" |
| 8 |
1. Baggage string value `one+two` should be parsed as "one+two" |
| 9 |
1. Go string value "one two" should be encoded as `one%20two` (percent encoding), and NOT as `one+two` (URL query encoding). |
| 10 |
1. Go string value "1=1" might be encoded as `1=1`, because the spec says: "Note, value MAY contain any number of the equal sign (=) characters. Parsers MUST NOT assume that the equal sign is only used to separate key and value.". `1%3D1` is also valid, but to simplify the implementation we're not doing it. |
| 11 |
|
| 12 |
Changes were made in this PR: https://github.com/getsentry/sentry-go/pull/568 |