| 1 |
#include <QtCore/QList> |
| 2 |
#include <QtCore/QString> |
| 3 |
#include <QtCore/QJsonArray> |
| 4 |
#include <QtCore/QSequentialIterable> |
| 5 |
|
| 6 |
struct Trivial |
| 7 |
{ |
| 8 |
int a; |
| 9 |
}; |
| 10 |
|
| 11 |
struct BigTrivial |
| 12 |
{ |
| 13 |
int a, b, c, d, e; |
| 14 |
void constFoo() const {} |
| 15 |
void nonConstFoo() {} |
| 16 |
}; |
| 17 |
|
| 18 |
struct SmallNonTrivial |
| 19 |
{ |
| 20 |
int a; |
| 21 |
~SmallNonTrivial() {} |
| 22 |
}; |
| 23 |
|
| 24 |
extern void nop(); |
| 25 |
extern void nop2(BigTrivial &); // non-const-ref |
| 26 |
extern void nop3(const BigTrivial &); // const-ref |
| 27 |
extern void nop4(BigTrivial *); // pointer |
| 28 |
|
| 29 |
void test_missing_ref() |
| 30 |
{ |
| 31 |
const QList<Trivial> trivials; |
| 32 |
const QList<BigTrivial> bigTrivials; |
| 33 |
const QList<SmallNonTrivial> smallNonTrivials; |
| 34 |
|
| 35 |
// Test #2: No warning |
| 36 |
for (Trivial t : trivials) { |
| 37 |
nop(); |
| 38 |
} |
| 39 |
|
| 40 |
// Test #3: No warning |
| 41 |
for (BigTrivial t : bigTrivials) { |
| 42 |
nop(); |
| 43 |
} |
| 44 |
|
| 45 |
// Test #4: Warning |
| 46 |
for (const SmallNonTrivial &t : smallNonTrivials) { |
| 47 |
nop(); |
| 48 |
} |
| 49 |
|
| 50 |
// Test #5: No Warning |
| 51 |
for (const BigTrivial t : bigTrivials) { |
| 52 |
t.constFoo(); |
| 53 |
} |
| 54 |
|
| 55 |
// Test #6: No warning |
| 56 |
for (BigTrivial t : bigTrivials) { |
| 57 |
t.nonConstFoo(); |
| 58 |
} |
| 59 |
|
| 60 |
// Test #7: No warning |
| 61 |
for (BigTrivial t : bigTrivials) { |
| 62 |
t = BigTrivial(); |
| 63 |
} |
| 64 |
|
| 65 |
// Test #8: No warning |
| 66 |
for (BigTrivial t : bigTrivials) { |
| 67 |
nop2(t); |
| 68 |
} |
| 69 |
|
| 70 |
// Test #9: No Warning |
| 71 |
for (BigTrivial t : bigTrivials) { |
| 72 |
nop3(t); |
| 73 |
} |
| 74 |
|
| 75 |
// Test #9: No warning |
| 76 |
for (BigTrivial t : bigTrivials) { |
| 77 |
nop4(&t); |
| 78 |
} |
| 79 |
|
| 80 |
// Test #10: No warning (bug #362587) |
| 81 |
QSequentialIterable si = QVariant().value<QSequentialIterable>(); |
| 82 |
for (const auto &s : si) {} |
| 83 |
} |
| 84 |
|
| 85 |
void test_add_ref_fixits() |
| 86 |
{ |
| 87 |
QStringList strlist; |
| 88 |
for (const QString &s : strlist) {} // should add & |
| 89 |
for (const QString &s : strlist) {} // should add const-& |
| 90 |
|
| 91 |
for (QString s : strlist) { // shouldn't warn |
| 92 |
s = s.toLower(); |
| 93 |
} |
| 94 |
|
| 95 |
for (QString s : strlist) { // shouldn't warn |
| 96 |
s.clear(); |
| 97 |
} |
| 98 |
} |
| 99 |
|
| 100 |
void test_json_array() |
| 101 |
{ |
| 102 |
QJsonArray array; |
| 103 |
const QJsonArray const_array; |
| 104 |
for (const auto a : array) {} // OK |
| 105 |
for (const QJsonValue &a : const_array) {} // Warn |
| 106 |
for (const QJsonValue &a : const_array) {} // OK |
| 107 |
} |