| 1 |
#include <QtCore/QList> |
| 2 |
#include <QtCore/QString> |
| 3 |
#include <QtCore/QStringList> |
| 4 |
#include <QtCore/QMap> |
| 5 |
#include <QtCore/QFile> |
| 6 |
#include <QtCore/QHash> |
| 7 |
#include <QtCore/QSet> |
| 8 |
#include <QtCore/QJsonObject> |
| 9 |
|
| 10 |
QList<int> getList() |
| 11 |
{ |
| 12 |
return QList<int>(); |
| 13 |
} |
| 14 |
void detach1() |
| 15 |
{ |
| 16 |
getList().constFirst(); // Warning |
| 17 |
} |
| 18 |
|
| 19 |
void detach2() |
| 20 |
{ |
| 21 |
getList().at(0); // OK |
| 22 |
} |
| 23 |
|
| 24 |
void lvalue() |
| 25 |
{ |
| 26 |
QStringList s; |
| 27 |
s.first(); // OK |
| 28 |
} |
| 29 |
|
| 30 |
QStringList test_string() { return {}; } |
| 31 |
QStringList& test_string_ref() { static QStringList s; return s; } |
| 32 |
QStringList * test_string_ptr() { return {}; } |
| 33 |
const QStringList test_const_string() { return {}; } |
| 34 |
const QStringList & test_const_string_ref() { static QStringList s; return s; } |
| 35 |
const QStringList * test_const_string_ptr() { return {}; } |
| 36 |
|
| 37 |
void qstrings() |
| 38 |
{ |
| 39 |
QString s; |
| 40 |
s.toLatin1().data(); // OK, list isn't shared |
| 41 |
test_string().constFirst(); // Warning |
| 42 |
test_const_string().first(); // OK |
| 43 |
test_const_string_ref().first(); // OK |
| 44 |
test_const_string_ptr()->first(); // OK |
| 45 |
|
| 46 |
test_string().constFirst(); // Warning |
| 47 |
test_string_ref().first(); // Warning |
| 48 |
test_string_ptr()->first(); // OK |
| 49 |
} |
| 50 |
|
| 51 |
void more() |
| 52 |
{ |
| 53 |
QFile::encodeName("foo").data(); |
| 54 |
} |
| 55 |
|
| 56 |
void foo(QStringList *list) |
| 57 |
{ |
| 58 |
auto it = list->begin(); |
| 59 |
} |
| 60 |
|
| 61 |
typedef QMap<int, QStringList> StringMap; |
| 62 |
Q_GLOBAL_STATIC(StringMap, sISOMap) |
| 63 |
void test_global_static() |
| 64 |
{ |
| 65 |
sISOMap()->insert(1, QStringList()); |
| 66 |
sISOMap->insert(1, QStringList()); |
| 67 |
} |
| 68 |
|
| 69 |
struct TestThis : public QList<int> |
| 70 |
{ |
| 71 |
void foo() |
| 72 |
{ |
| 73 |
begin(); |
| 74 |
} |
| 75 |
}; |
| 76 |
|
| 77 |
class Foo |
| 78 |
{ |
| 79 |
public: |
| 80 |
QStringList list; |
| 81 |
}; |
| 82 |
|
| 83 |
Foo * getFoo() { return new Foo(); } |
| 84 |
Foo getFoo2() { return Foo(); } |
| 85 |
|
| 86 |
void testThroughPointer() |
| 87 |
{ |
| 88 |
Foo *f; |
| 89 |
f->list.first(); // OK |
| 90 |
getFoo()->list.first(); // OK |
| 91 |
getFoo2().list.first(); // OK |
| 92 |
} |
| 93 |
|
| 94 |
QMap<int,int> getMap() { return {}; }; |
| 95 |
void testWriteMethod() |
| 96 |
{ |
| 97 |
getMap().insert(1,1); // Warning |
| 98 |
int a = getMap().take(1); // Warning |
| 99 |
} |
| 100 |
|
| 101 |
void testSubscriptOperator() |
| 102 |
{ |
| 103 |
getList().at(0); // Warning |
| 104 |
if (test_string().at(0).isEmpty()) {} // Warning |
| 105 |
getMap().value(0); // Warning |
| 106 |
auto m = getMap(); |
| 107 |
m[0]; |
| 108 |
|
| 109 |
getList() .at(0); // Warning, test correct fixit range here |
| 110 |
getList().at(0); // Warning, test correct fixit range here |
| 111 |
} |
| 112 |
|
| 113 |
typedef QList<int> IntList; |
| 114 |
IntList getIntList() { return {}; } |
| 115 |
void testTypedef() |
| 116 |
{ |
| 117 |
getIntList().at(0); // Warning |
| 118 |
} |
| 119 |
|
| 120 |
QStringList getStringList() { return {}; } |
| 121 |
|
| 122 |
void testDerivedClass() |
| 123 |
{ |
| 124 |
getStringList().constFirst(); // Warning |
| 125 |
getStringList().at(0); // Warning |
| 126 |
} |
| 127 |
|
| 128 |
void testQStringListSpecificMethods() |
| 129 |
{ |
| 130 |
getStringList().removeDuplicates(); |
| 131 |
} |
| 132 |
|
| 133 |
QString getString() { return ""; } |
| 134 |
void testQString() |
| 135 |
{ |
| 136 |
getString().cbegin(); // Warning |
| 137 |
getString().at(1); // Warning |
| 138 |
} |
| 139 |
|
| 140 |
extern QHash<QString, int> &initializers(); |
| 141 |
QString getStr() { return QString(); } |
| 142 |
|
| 143 |
static auto bar = [] { |
| 144 |
return initializers().insert(getStr(), 1); // OK |
| 145 |
}(); |
| 146 |
|
| 147 |
|
| 148 |
QSet<int> getSet() { return {}; } |
| 149 |
|
| 150 |
void testIntersect() |
| 151 |
{ |
| 152 |
QSet<int> other; |
| 153 |
auto s = getSet().intersect(other); // OK |
| 154 |
} |
| 155 |
|
| 156 |
QJsonObject getObj(){return {};} |
| 157 |
void testJsonDetach() { |
| 158 |
getObj().value(QLatin1String("bla")); // Warning |
| 159 |
getObj().constFind(QLatin1String("bla")); // Warning |
| 160 |
getObj().value(QLatin1String("bla")); // OK |
| 161 |
} |
| 162 |
|
| 163 |
void testRIterators() |
| 164 |
{ |
| 165 |
getList().crbegin(); |
| 166 |
getList().crend(); |
| 167 |
getStringList().crbegin(); |
| 168 |
getStringList().crend(); |
| 169 |
} |
| 170 |
|
| 171 |
QVariantList getVariantList(){return {};} |
| 172 |
void chainedCalls() |
| 173 |
{ |
| 174 |
getVariantList().constLast().toStringList().constFirst()[0]; // Warn, twice |
| 175 |
getStringList().at(0)[0]; // Warn, but only once due to whitelisting |
| 176 |
getStringList().at(0)[0]; // OK, .at gives us a const value |
| 177 |
getVariantList().constFirst().toString().at(0); // Warn, detach |
| 178 |
getVariantList().at(0).toString().at(0); // Warn, detach twice |
| 179 |
} |