Debian Codegraph @

tests/prep/0206tests/tmpexport/doc/comments.txt

raw
1 1999-01-14: Some remarks (JoeB):
2 - Mostly the changes "Anick's resolution" --> "the Anick resolution"
3 is good. However, line 3 should be
4 "% Implementation of the initial Anick resolution routines."
5 (rather than "... initial the ...").
6
7 - Function names given to the MAP family pf procedures as second
8 arguments should preferably be quoted by means of FUNCTION instead
9 of QUOTE, since the compiler then might make more efficient code.
10 Thus, line 220 of aninterf.sl should be
11 " (MAPC (CDR anNEWCHAINS) (FUNCTION andiff))" rather than
12 "... 'anDIFF)".
13
14 - LINELENGTH resets the line length globally. Thus, when you call it
15 in particular printings to files, you should be careful to restore
16 the previous line length afterwards, in order not to give the user
17 any nasty surprises. (This is fairly easy to do, since the return
18 value of a call to LINELENGTH is the previous line length.) Cf. lines
19 247, 264, 360 in aninterf.sl.
20
21 - From the double prefix anch- I see that !*anchPrintEdgeString and
22 anchEdgeString!* were not supposed to be employed outside chrecord.sl.
23 In fact, we provide procedures GETEDGESTRING, GETEDGESTRINGPRINTING,
24 SETEDGESTRING, SETEDGESTRINGPRINTING for general access to these
25 variables. I think you either should use these procedures in
26 aninterf.sl (in the mode handlers), or we should agree on making
27 the variables general for anick, removing the -cr- prefix, and
28 document them. (I would prefer the first solution, to work only
29 through the enumerated procedures.)
30
31 ---------------------------------------
32 JoeB 1999-01-20: Comparing older and newer versions of the source files,
33 I noted the following procedure on gauss.sl from
34 Apr 14 1997:
35
36 > (DE antpPRINTSDP (sdp)
37 > (MAPC (CDR sdp)
38 > (FUNCTION
39 > (LAMBDA (tm)
40 > (PROGN (anPRINTCHAIN (anSDPTm2ChR tm))
41 > (PRIN2 ".")
42 > (antpPRINTQPOLORCONSTANT (anSDPTm2QPol tm)))))))
43
44 It seems to be fairly modularised. I think I'd like to compare it to
45 other printing procedures; for which purpose I note it here.