| 1 |
Closure Library welcomes patches/pulls for features and bugfixes. |
| 2 |
|
| 3 |
For contributors external to Google, follow the instructions given here: |
| 4 |
|
| 5 |
Notes on Contributions to Closure Library |
| 6 |
|
| 7 |
Google Individual Contributor License |
| 8 |
|
| 9 |
In all cases, contributors must sign a contributor license agreement, |
| 10 |
either for an individual or corporation, before a patch can be |
| 11 |
accepted. Please fill out the agreement for an individual or a |
| 12 |
corporation, as appropriate. |
| 13 |
|
| 14 |
https://developers.google.com/open-source/cla/individual |
| 15 |
https://developers.google.com/open-source/cla/corporate |
| 16 |
|
| 17 |
If you or your organization is not listed there already, you should |
| 18 |
add an entry to the AUTHORS file as part of your patch. |
| 19 |
|
| 20 |
If you plan to add a significant component or large chunk of code, it |
| 21 |
is recommended to bring it up on the discussion list for a design |
| 22 |
discussion before writing code. |
| 23 |
|
| 24 |
If appropriate, write a unit test that demonstrates your patch. Tests are the |
| 25 |
best way to ensure that future contributors do not break your code |
| 26 |
accidentally. |
| 27 |
|
| 28 |
To change the Closure Library source, you must submit a pull request |
| 29 |
in GitHub. See the GitHub documentation here: |
| 30 |
|
| 31 |
https://help.github.com/categories/63/articles |
| 32 |
|
| 33 |
Closure Library developers monitor outstanding pull requests. They may |
| 34 |
request changes on the pull request before accepting. They will also |
| 35 |
verify that the CLA has been signed. |
| 36 |
|
| 37 |
Oftentimes, the pull request will not be directly merged, but patched to |
| 38 |
the internal Google codebase to verify that unit and integration tests |
| 39 |
will pass before submitting (and optionally make changes to the patch to |
| 40 |
match style, fix text, or to make the code or comments clearer). In this |
| 41 |
case, the issue associated with the pull request will be closed when the |
| 42 |
patch is pushed to the repository via the MOE (Make Open Easy) system. |
| 43 |
|
| 44 |
https://github.com/google/MOE/ |