| 1 |
# --- BEGIN COPYRIGHT BLOCK --- |
| 2 |
# Copyright (C) 2026 Red Hat, Inc. |
| 3 |
# All rights reserved. |
| 4 |
# |
| 5 |
# License: GPL (version 3 or any later version). |
| 6 |
# See LICENSE for details. |
| 7 |
# --- END COPYRIGHT BLOCK --- |
| 8 |
# |
| 9 |
import pytest |
| 10 |
import logging |
| 11 |
from lib389._constants import DEFAULT_SUFFIX |
| 12 |
from test389.topologies import topology_m2 |
| 13 |
from lib389.plugins import MemberOfPlugin, ReferentialIntegrityPlugin |
| 14 |
from lib389.idm.user import UserAccounts |
| 15 |
from lib389.idm.group import Groups |
| 16 |
from lib389.replica import ReplicationManager, Changelog5 |
| 17 |
from lib389._mapped_object import DSLdapObjects |
| 18 |
|
| 19 |
log = logging.getLogger(__name__) |
| 20 |
|
| 21 |
pytestmark = pytest.mark.tier2 |
| 22 |
|
| 23 |
|
| 24 |
def _enable_plugins(inst): |
| 25 |
"""Enable MemberOf and ReferentialIntegrity plugins""" |
| 26 |
log.info(f"Enabling plugins on {inst.serverid}") |
| 27 |
|
| 28 |
memberof = MemberOfPlugin(inst) |
| 29 |
memberof.enable() |
| 30 |
memberof.set('memberOfAllBackends', 'on') |
| 31 |
|
| 32 |
referint = ReferentialIntegrityPlugin(inst) |
| 33 |
referint.enable() |
| 34 |
referint.set('referint-membership-attr', ['member', 'uniqueMember', 'memberOf']) |
| 35 |
|
| 36 |
inst.restart() |
| 37 |
log.info(f"Plugins enabled and {inst.serverid} restarted") |
| 38 |
|
| 39 |
|
| 40 |
def test_memberof_no_duplicate_on_delete(topology_m2): |
| 41 |
"""Test that deleting a user doesn't cause duplicate memberOf operations |
| 42 |
|
| 43 |
:id: 8f9a2b3c-4d5e-6f7a-8b9c-0d1e2f3a4b5c |
| 44 |
:setup: Two supplier replication topology |
| 45 |
:steps: |
| 46 |
1. Enable MemberOf and ReferentialIntegrity plugins on both suppliers |
| 47 |
2. Create multiple groups on supplier1 |
| 48 |
3. Create a user on supplier1 |
| 49 |
4. Add user to all groups |
| 50 |
5. Wait for replication to supplier2 |
| 51 |
6. Delete the user on supplier1 |
| 52 |
7. Wait for replication |
| 53 |
8. Verify user is removed from all groups |
| 54 |
9. Check replication changelog for duplicate operations |
| 55 |
:expectedresults: |
| 56 |
1. Plugins enabled successfully |
| 57 |
2. Groups created |
| 58 |
3. User created |
| 59 |
4. User is member of all groups |
| 60 |
5. Changes replicated |
| 61 |
6. User deleted |
| 62 |
7. Changes replicated |
| 63 |
8. User removed from all groups on both suppliers |
| 64 |
9. No duplicate member remove operations in changelog |
| 65 |
""" |
| 66 |
supplier1 = topology_m2.ms["supplier1"] |
| 67 |
supplier2 = topology_m2.ms["supplier2"] |
| 68 |
|
| 69 |
log.info("Enable plugins on both suppliers") |
| 70 |
_enable_plugins(supplier1) |
| 71 |
_enable_plugins(supplier2) |
| 72 |
|
| 73 |
log.info("Create test groups") |
| 74 |
groups_s1 = Groups(supplier1, DEFAULT_SUFFIX) |
| 75 |
group_list = [] |
| 76 |
group_names = [] |
| 77 |
for idx in range(3): |
| 78 |
group_name = f'testgroup{idx}' |
| 79 |
log.info(f"Creating group: {group_name}") |
| 80 |
group = groups_s1.create(properties={'cn': group_name}) |
| 81 |
group_list.append(group) |
| 82 |
group_names.append(group_name) |
| 83 |
|
| 84 |
log.info("Create test user") |
| 85 |
users_s1 = UserAccounts(supplier1, DEFAULT_SUFFIX) |
| 86 |
user = users_s1.create(properties={ |
| 87 |
'uid': 'testuser', |
| 88 |
'cn': 'Test User', |
| 89 |
'sn': 'User', |
| 90 |
'uidNumber': '1000', |
| 91 |
'gidNumber': '1000', |
| 92 |
'homeDirectory': '/home/testuser' |
| 93 |
}) |
| 94 |
log.info(f"Created user: {user.dn}") |
| 95 |
|
| 96 |
log.info("Add user to all groups") |
| 97 |
for group in group_list: |
| 98 |
group.add('member', user.dn) |
| 99 |
log.info(f"Added {user.dn} to {group.dn}") |
| 100 |
|
| 101 |
log.info("Wait for replication to supplier2") |
| 102 |
repl = ReplicationManager(DEFAULT_SUFFIX) |
| 103 |
repl.wait_for_replication(supplier1, supplier2, timeout=30) |
| 104 |
|
| 105 |
log.info("Verify user exists on supplier2 and is member of groups") |
| 106 |
users_s2 = UserAccounts(supplier2, DEFAULT_SUFFIX) |
| 107 |
user_s2 = users_s2.get('testuser') |
| 108 |
assert user_s2.exists() |
| 109 |
|
| 110 |
groups_s2 = Groups(supplier2, DEFAULT_SUFFIX) |
| 111 |
for group_name in group_names: |
| 112 |
group_s2 = groups_s2.get(group_name) |
| 113 |
members = group_s2.get_attr_vals_utf8('member') |
| 114 |
assert user.dn in members |
| 115 |
log.info(f"Verified {user.dn} in {group_s2.dn} on supplier2") |
| 116 |
|
| 117 |
log.info("Delete user on supplier1") |
| 118 |
user.delete() |
| 119 |
log.info(f"Deleted user: {user.dn}") |
| 120 |
|
| 121 |
log.info("Wait for replication") |
| 122 |
repl.wait_for_replication(supplier1, supplier2, timeout=30) |
| 123 |
|
| 124 |
log.info("Verify user removed from all groups on both suppliers") |
| 125 |
for group_name in group_names: |
| 126 |
group_s1 = groups_s1.get(group_name) |
| 127 |
members_s1 = group_s1.get_attr_vals_utf8('member') |
| 128 |
assert user.dn not in members_s1 |
| 129 |
log.info(f"Verified {user.dn} removed from {group_s1.dn} on supplier1") |
| 130 |
|
| 131 |
group_s2 = groups_s2.get(group_name) |
| 132 |
members_s2 = group_s2.get_attr_vals_utf8('member') |
| 133 |
assert user.dn not in members_s2 |
| 134 |
log.info(f"Verified {user.dn} removed from {group_s2.dn} on supplier2") |
| 135 |
|
| 136 |
log.info("Verify no user entry exists on supplier2") |
| 137 |
assert not user_s2.exists() |
| 138 |
|
| 139 |
log.info("Check changelog for duplicate modifications") |
| 140 |
for group in group_list: |
| 141 |
log.info(f"Checking changelog entries for {group.dn}") |
| 142 |
|
| 143 |
cl1 = Changelog5(supplier1) |
| 144 |
cl_entries_s1 = DSLdapObjects(supplier1, basedn=cl1.dn) |
| 145 |
cl_list_s1 = cl_entries_s1.filter(f'(&(targetdn={group.dn})(changeType=modify))') |
| 146 |
|
| 147 |
delete_count_s1 = 0 |
| 148 |
for entry in cl_list_s1: |
| 149 |
if entry.present('changes'): |
| 150 |
changes_str = str(entry.get_attr_vals_utf8('changes')) |
| 151 |
if 'delete: member' in changes_str and user.dn in changes_str: |
| 152 |
delete_count_s1 += 1 |
| 153 |
|
| 154 |
log.info(f"Found {delete_count_s1} member delete operations for {group.dn} on supplier1") |
| 155 |
assert delete_count_s1 == 0, f"Unexpected member delete in changelog on supplier1 for {group.dn}" |
| 156 |
|
| 157 |
cl2 = Changelog5(supplier2) |
| 158 |
cl_entries_s2 = DSLdapObjects(supplier2, basedn=cl2.dn) |
| 159 |
cl_list_s2 = cl_entries_s2.filter(f'(&(targetdn={group.dn})(changeType=modify))') |
| 160 |
|
| 161 |
delete_count_s2 = 0 |
| 162 |
for entry in cl_list_s2: |
| 163 |
if entry.present('changes'): |
| 164 |
changes_str = str(entry.get_attr_vals_utf8('changes')) |
| 165 |
if 'delete: member' in changes_str and user.dn in changes_str: |
| 166 |
delete_count_s2 += 1 |
| 167 |
|
| 168 |
log.info(f"Found {delete_count_s2} member delete operations for {group.dn} on supplier2") |
| 169 |
assert delete_count_s2 == 0, f"Unexpected member delete in changelog on supplier2 for {group.dn}" |
| 170 |
|
| 171 |
log.info("Test passed: No duplicate member delete operations found in changelog") |
| 172 |
|
| 173 |
|
| 174 |
def test_memberof_no_duplicate_on_rename(topology_m2): |
| 175 |
"""Test that renaming a user doesn't cause duplicate memberOf operations |
| 176 |
|
| 177 |
:id: 9a0b1c2d-3e4f-5a6b-7c8d-9e0f1a2b3c4d |
| 178 |
:setup: Two supplier replication topology |
| 179 |
:steps: |
| 180 |
1. Enable MemberOf and ReferentialIntegrity plugins on both suppliers |
| 181 |
2. Create multiple groups on supplier1 |
| 182 |
3. Create a user on supplier1 |
| 183 |
4. Add user to all groups |
| 184 |
5. Wait for replication to supplier2 |
| 185 |
6. Rename the user on supplier1 |
| 186 |
7. Wait for replication |
| 187 |
8. Verify old DN removed and new DN added to all groups |
| 188 |
9. Check for duplicate operations in changelog |
| 189 |
:expectedresults: |
| 190 |
1. Plugins enabled successfully |
| 191 |
2. Groups created |
| 192 |
3. User created |
| 193 |
4. User is member of all groups |
| 194 |
5. Changes replicated |
| 195 |
6. User renamed |
| 196 |
7. Changes replicated |
| 197 |
8. Old DN removed, new DN added to groups on both suppliers |
| 198 |
9. No duplicate member operations in changelog |
| 199 |
""" |
| 200 |
supplier1 = topology_m2.ms["supplier1"] |
| 201 |
supplier2 = topology_m2.ms["supplier2"] |
| 202 |
|
| 203 |
log.info("Enable plugins on both suppliers") |
| 204 |
_enable_plugins(supplier1) |
| 205 |
_enable_plugins(supplier2) |
| 206 |
|
| 207 |
log.info("Create test groups") |
| 208 |
groups_s1 = Groups(supplier1, DEFAULT_SUFFIX) |
| 209 |
group_list = [] |
| 210 |
group_names = [] |
| 211 |
for idx in range(3): |
| 212 |
group_name = f'renamegroup{idx}' |
| 213 |
log.info(f"Creating group: {group_name}") |
| 214 |
group = groups_s1.create(properties={'cn': group_name}) |
| 215 |
group_list.append(group) |
| 216 |
group_names.append(group_name) |
| 217 |
|
| 218 |
log.info("Create test user") |
| 219 |
users_s1 = UserAccounts(supplier1, DEFAULT_SUFFIX) |
| 220 |
user = users_s1.create(properties={ |
| 221 |
'uid': 'renameuser', |
| 222 |
'cn': 'Rename User', |
| 223 |
'sn': 'User', |
| 224 |
'uidNumber': '2000', |
| 225 |
'gidNumber': '2000', |
| 226 |
'homeDirectory': '/home/renameuser' |
| 227 |
}) |
| 228 |
old_dn = user.dn |
| 229 |
log.info(f"Created user: {old_dn}") |
| 230 |
|
| 231 |
log.info("Add user to all groups") |
| 232 |
for group in group_list: |
| 233 |
group.add('member', old_dn) |
| 234 |
log.info(f"Added {old_dn} to {group.dn}") |
| 235 |
|
| 236 |
log.info("Wait for replication to supplier2") |
| 237 |
repl = ReplicationManager(DEFAULT_SUFFIX) |
| 238 |
repl.wait_for_replication(supplier1, supplier2, timeout=30) |
| 239 |
|
| 240 |
log.info("Verify user exists on supplier2 with old DN") |
| 241 |
users_s2 = UserAccounts(supplier2, DEFAULT_SUFFIX) |
| 242 |
user_s2 = users_s2.get('renameuser') |
| 243 |
assert user_s2.exists() |
| 244 |
|
| 245 |
log.info("Rename user on supplier1") |
| 246 |
user.rename('uid=renameuser_new') |
| 247 |
new_dn = user.dn |
| 248 |
log.info(f"Renamed user from {old_dn} to {new_dn}") |
| 249 |
|
| 250 |
log.info("Wait for replication") |
| 251 |
repl.wait_for_replication(supplier1, supplier2, timeout=30) |
| 252 |
|
| 253 |
log.info("Verify old DN removed and new DN added to groups") |
| 254 |
for group_name in group_names: |
| 255 |
group_s1 = groups_s1.get(group_name) |
| 256 |
members_s1 = group_s1.get_attr_vals_utf8('member') |
| 257 |
members_s1_lower = [m.lower() for m in members_s1] |
| 258 |
assert old_dn.lower() not in members_s1_lower, f"Old DN still in {group_s1.dn}" |
| 259 |
assert new_dn.lower() in members_s1_lower, f"New DN not in {group_s1.dn}" |
| 260 |
log.info(f"Verified rename in {group_s1.dn} on supplier1") |
| 261 |
|
| 262 |
group_s2 = Groups(supplier2, DEFAULT_SUFFIX).get(group_name) |
| 263 |
members_s2 = group_s2.get_attr_vals_utf8('member') |
| 264 |
members_s2_lower = [m.lower() for m in members_s2] |
| 265 |
assert old_dn.lower() not in members_s2_lower, f"Old DN still in {group_s2.dn} on supplier2" |
| 266 |
assert new_dn.lower() in members_s2_lower, f"New DN not in {group_s2.dn} on supplier2" |
| 267 |
log.info(f"Verified rename in {group_s2.dn} on supplier2") |
| 268 |
|
| 269 |
log.info("Verify renamed user exists on supplier2") |
| 270 |
user_s2_new = users_s2.get('renameuser_new') |
| 271 |
assert user_s2_new.exists() |
| 272 |
|
| 273 |
log.info("Check changelog for duplicate modifications") |
| 274 |
for group in group_list: |
| 275 |
log.info(f"Checking changelog entries for {group.dn}") |
| 276 |
|
| 277 |
cl1 = Changelog5(supplier1) |
| 278 |
cl_entries_s1 = DSLdapObjects(supplier1, basedn=cl1.dn) |
| 279 |
cl_list_s1 = cl_entries_s1.filter(f'(&(targetdn={group.dn})(changeType=modify))') |
| 280 |
|
| 281 |
change_count_s1 = 0 |
| 282 |
for entry in cl_list_s1: |
| 283 |
if entry.present('changes'): |
| 284 |
changes_str = str(entry.get_attr_vals_utf8('changes')) |
| 285 |
if ('delete: member' in changes_str and old_dn in changes_str) or \ |
| 286 |
('add: member' in changes_str and new_dn in changes_str): |
| 287 |
change_count_s1 += 1 |
| 288 |
|
| 289 |
log.info(f"Found {change_count_s1} member change operations for {group.dn} on supplier1") |
| 290 |
assert change_count_s1 == 0, f"Unexpected member changes in changelog on supplier1 for {group.dn}" |
| 291 |
|
| 292 |
cl2 = Changelog5(supplier2) |
| 293 |
cl_entries_s2 = DSLdapObjects(supplier2, basedn=cl2.dn) |
| 294 |
cl_list_s2 = cl_entries_s2.filter(f'(&(targetdn={group.dn})(changeType=modify))') |
| 295 |
|
| 296 |
change_count_s2 = 0 |
| 297 |
for entry in cl_list_s2: |
| 298 |
if entry.present('changes'): |
| 299 |
changes_str = str(entry.get_attr_vals_utf8('changes')) |
| 300 |
if ('delete: member' in changes_str and old_dn in changes_str) or \ |
| 301 |
('add: member' in changes_str and new_dn in changes_str): |
| 302 |
change_count_s2 += 1 |
| 303 |
|
| 304 |
log.info(f"Found {change_count_s2} member change operations for {group.dn} on supplier2") |
| 305 |
assert change_count_s2 == 0, f"Unexpected member changes in changelog on supplier2 for {group.dn}" |
| 306 |
|
| 307 |
log.info("Test passed: No duplicate member change operations found in changelog") |
| 308 |
|
| 309 |
|
| 310 |
if __name__ == '__main__': |
| 311 |
# Run isolated |
| 312 |
# -s for DEBUG mode |
| 313 |
CURRENT_FILE = os.path.realpath(__file__) |
| 314 |
pytest.main(["-s", CURRENT_FILE]) |