| 1 |
# --- BEGIN COPYRIGHT BLOCK --- |
| 2 |
# Copyright (C) 2022 Red Hat, Inc. |
| 3 |
# All rights reserved. |
| 4 |
# |
| 5 |
# License: GPL (version 3 or any later version). |
| 6 |
# See LICENSE for details. |
| 7 |
# --- END COPYRIGHT BLOCK --- |
| 8 |
# |
| 9 |
import ldap |
| 10 |
import logging |
| 11 |
import pytest |
| 12 |
import os |
| 13 |
from lib389.plugins import MemberOfPlugin |
| 14 |
from lib389.idm.user import UserAccounts, nsUserAccounts |
| 15 |
from lib389.idm.group import Groups |
| 16 |
from lib389 import DEFAULT_SUFFIX |
| 17 |
from test389.topologies import topology_st |
| 18 |
|
| 19 |
|
| 20 |
pytestmark = pytest.mark.tier0 |
| 21 |
|
| 22 |
logging.getLogger(__name__).setLevel(logging.DEBUG) |
| 23 |
log = logging.getLogger(__name__) |
| 24 |
|
| 25 |
group_name = 'group' |
| 26 |
member_name = 'member' |
| 27 |
|
| 28 |
|
| 29 |
@pytest.fixture(scope="function") |
| 30 |
def memberof(topology_st, request): |
| 31 |
memberof = MemberOfPlugin(topology_st.standalone) |
| 32 |
memberof.enable() |
| 33 |
topology_st.standalone.restart() |
| 34 |
|
| 35 |
def fin(): |
| 36 |
memberof.disable() |
| 37 |
topology_st.standalone.restart() |
| 38 |
|
| 39 |
request.addfinalizer(fin) |
| 40 |
|
| 41 |
return memberof |
| 42 |
|
| 43 |
@pytest.fixture(scope="function") |
| 44 |
def prepare_entries(topology_st, request): |
| 45 |
groups = Groups(topology_st.standalone, DEFAULT_SUFFIX) |
| 46 |
users = nsUserAccounts(topology_st.standalone, DEFAULT_SUFFIX) |
| 47 |
|
| 48 |
log.info('Create group cn=group,ou=groups,{}'.format(DEFAULT_SUFFIX)) |
| 49 |
if groups.exists(group_name): |
| 50 |
test_group = groups.get(group_name) |
| 51 |
test_group.delete() |
| 52 |
|
| 53 |
properties = { |
| 54 |
'cn': group_name, |
| 55 |
'description': group_name |
| 56 |
} |
| 57 |
test_group = groups.create(properties=properties) |
| 58 |
|
| 59 |
log.info('Create user cn=member,ou=People,{}'.format(DEFAULT_SUFFIX)) |
| 60 |
if users.exists(member_name): |
| 61 |
member = users.get(member_name) |
| 62 |
member.delete() |
| 63 |
|
| 64 |
properties_member = { |
| 65 |
'uid': member_name, |
| 66 |
'cn': member_name, |
| 67 |
'displayName': member_name, |
| 68 |
'uidNumber': '1000', |
| 69 |
'gidNumber': '1000', |
| 70 |
'homeDirectory': '/home/{}'.format(member_name) |
| 71 |
} |
| 72 |
member = users.create(properties=properties_member) |
| 73 |
|
| 74 |
def fin(): |
| 75 |
log.info('Delete test group') |
| 76 |
if test_group.exists(): |
| 77 |
test_group.delete() |
| 78 |
log.info('Delete member user') |
| 79 |
if member.exists(): |
| 80 |
member.delete() |
| 81 |
|
| 82 |
request.addfinalizer(fin) |
| 83 |
|
| 84 |
|
| 85 |
def test_fixup_task_repair_entry_erroneously_set_as_member(topology_st, prepare_entries): |
| 86 |
""" Test memberOf fixup task |
| 87 |
|
| 88 |
:id: 7e5ef63a-36c1-4cb9-9f0a-f92e4d1937ca |
| 89 |
:setup: Standalone instance |
| 90 |
:steps: |
| 91 |
1. Create group entry: cn=group,ou=groups,dc=example,dc=com |
| 92 |
2. Create member user entry: uid=member,ou=people,dc=example,dc=com |
| 93 |
3. Update member user entry to have objectclass nsMemberOf |
| 94 |
4. Update member user entry to contain attribute memberOf of the group entry |
| 95 |
5. Enable MemberOf Plugin |
| 96 |
6. Verify the member user entry still has memberOf attribute set |
| 97 |
7. Verify the group entry does not have member attribute set |
| 98 |
8. Run the fixupmemberof task |
| 99 |
9. Verify the member user no longer contains memberOf attribute |
| 100 |
:expectedresults: |
| 101 |
1. Success |
| 102 |
2. Success |
| 103 |
3. Success |
| 104 |
4. Success |
| 105 |
5. Success |
| 106 |
6. Success |
| 107 |
7. Success |
| 108 |
8. Success |
| 109 |
9. Success |
| 110 |
""" |
| 111 |
|
| 112 |
memberof = MemberOfPlugin(topology_st.standalone) |
| 113 |
|
| 114 |
groups = Groups(topology_st.standalone, DEFAULT_SUFFIX) |
| 115 |
group = groups.get(group_name) |
| 116 |
|
| 117 |
users = nsUserAccounts(topology_st.standalone, DEFAULT_SUFFIX) |
| 118 |
member = users.get(member_name) |
| 119 |
|
| 120 |
log.info('Add nsMemberOf objectclass to member entry') |
| 121 |
member.add('objectclass', 'nsMemberOf') |
| 122 |
|
| 123 |
log.info('Add memberOf attribute to member entry') |
| 124 |
member.add('memberOf', group.dn) |
| 125 |
assert member.present('memberof', group.dn) |
| 126 |
assert not group.present('member', member.dn) |
| 127 |
|
| 128 |
log.info('Enable memberOf plugin and restart') |
| 129 |
memberof.enable() |
| 130 |
topology_st.standalone.restart() |
| 131 |
|
| 132 |
log.info('Verify the memberOf attribute is still present') |
| 133 |
assert member.present('memberof', group.dn) |
| 134 |
assert not group.present('member', member.dn) |
| 135 |
|
| 136 |
log.info('Run the fixup task') |
| 137 |
task = memberof.fixup(basedn=DEFAULT_SUFFIX) |
| 138 |
|
| 139 |
# Wait for task to complete before reading entries |
| 140 |
task.wait() |
| 141 |
|
| 142 |
log.info('Verify the memberOf attribute is no longer present') |
| 143 |
try: |
| 144 |
assert not member.present('memberof', group.dn) |
| 145 |
assert not group.present('member', member.dn) |
| 146 |
finally: |
| 147 |
log.info('Disable memberOf plugin and restart') |
| 148 |
memberof.disable() |
| 149 |
topology_st.standalone.restart() |
| 150 |
|
| 151 |
|
| 152 |
def test_fixup_task_limit(topology_st): |
| 153 |
"""Test only one fixup task is allowed at one time |
| 154 |
|
| 155 |
:id: 2bb49a10-fca9-4d89-9a7a-34c2ba4baadc |
| 156 |
:setup: Standalone Instance |
| 157 |
:steps: |
| 158 |
1. Add some users and groups |
| 159 |
2. Enable memberOf Plugin |
| 160 |
3. Add fixup task |
| 161 |
4. Add second task |
| 162 |
5. Add a third task after first task completes |
| 163 |
:expectedresults: |
| 164 |
1. Success |
| 165 |
2. Success |
| 166 |
3. Success |
| 167 |
4. Second task should fail |
| 168 |
5. Success |
| 169 |
""" |
| 170 |
|
| 171 |
# Create group with members |
| 172 |
groups = Groups(topology_st.standalone, DEFAULT_SUFFIX) |
| 173 |
group = groups.create(properties={'cn': 'test'}) |
| 174 |
|
| 175 |
users = UserAccounts(topology_st.standalone, DEFAULT_SUFFIX) |
| 176 |
# Turn on access log buffering to speed up user creation |
| 177 |
buffering = topology_st.standalone.config.get_attr_val_utf8('nsslapd-accesslog-logbuffering') |
| 178 |
topology_st.standalone.config.set('nsslapd-accesslog-logbuffering', 'on') |
| 179 |
for idx in range(6000): |
| 180 |
user = users.create(properties={ |
| 181 |
'uid': 'testuser%s' % idx, |
| 182 |
'cn' : 'testuser%s' % idx, |
| 183 |
'sn' : 'user%s' % idx, |
| 184 |
'uidNumber' : '%s' % (1000 + idx), |
| 185 |
'gidNumber' : '%s' % (1000 + idx), |
| 186 |
'homeDirectory' : '/home/testuser%s' % idx |
| 187 |
}) |
| 188 |
group.add('member', user.dn) |
| 189 |
|
| 190 |
# Restore access log buffering |
| 191 |
topology_st.standalone.config.set('nsslapd-accesslog-logbuffering', buffering) |
| 192 |
|
| 193 |
# Configure memberOf plugin |
| 194 |
memberof = MemberOfPlugin(topology_st.standalone) |
| 195 |
memberof.enable() |
| 196 |
topology_st.standalone.restart() |
| 197 |
|
| 198 |
# Add first task |
| 199 |
task = memberof.fixup(DEFAULT_SUFFIX) |
| 200 |
|
| 201 |
# Add second task which should fail |
| 202 |
with pytest.raises(ldap.UNWILLING_TO_PERFORM): |
| 203 |
memberof.fixup(DEFAULT_SUFFIX) |
| 204 |
|
| 205 |
# Add second task but on different suffix which should be allowed |
| 206 |
memberof.fixup("ou=people," + DEFAULT_SUFFIX) |
| 207 |
|
| 208 |
# Wait for first task to complete |
| 209 |
task.wait() |
| 210 |
|
| 211 |
# Add new task which should be allowed now |
| 212 |
memberof.fixup(DEFAULT_SUFFIX) |
| 213 |
|
| 214 |
|
| 215 |
def test_fixup_task_invalid_basedn(topology_st, memberof): |
| 216 |
"""Test memberOf fixup task with invalid basedn |
| 217 |
|
| 218 |
:id: dce9b898-119d-42b8-a236-1130e59bfe18 |
| 219 |
:setup: Standalone Instance with memberOf plugin enabled |
| 220 |
:steps: |
| 221 |
1. Clear error logs to ensure clean testing |
| 222 |
2. Run fixup task with invalid/non-existent basedn |
| 223 |
3. Verify task completes but logs appropriate error |
| 224 |
4. Check error log for "Failed to get be backend" message |
| 225 |
:expectedresults: |
| 226 |
1. Error logs should be cleared successfully |
| 227 |
2. Task should be created successfully |
| 228 |
3. Task should complete |
| 229 |
4. Error should be logged about invalid backend |
| 230 |
""" |
| 231 |
|
| 232 |
# Clear error logs to ensure clean testing |
| 233 |
log.info('Clearing error logs before test') |
| 234 |
topology_st.standalone.deleteErrorLogs() |
| 235 |
|
| 236 |
# Try to run fixup task with invalid basedn |
| 237 |
invalid_basedn = 'dc=testdb,dc=com' |
| 238 |
log.info(f'Running fixup task with invalid basedn: {invalid_basedn}') |
| 239 |
|
| 240 |
# The task should be created successfully even with invalid basedn |
| 241 |
task = memberof.fixup(basedn=invalid_basedn) |
| 242 |
|
| 243 |
# Wait for task to complete |
| 244 |
task.wait() |
| 245 |
|
| 246 |
# Check that appropriate error was logged |
| 247 |
log.info('Checking error log for backend error message') |
| 248 |
assert topology_st.standalone.ds_error_log.match('.*Failed to get be backend.*') |
| 249 |
|
| 250 |
|
| 251 |
def test_fixup_task_invalid_filter(topology_st, memberof): |
| 252 |
"""Test memberOf fixup task with invalid search filter |
| 253 |
|
| 254 |
:id: dde9e893-119d-42c8-a236-1190e56bfe98 |
| 255 |
:setup: Standalone Instance with memberOf plugin enabled |
| 256 |
:steps: |
| 257 |
1. Clear error logs to ensure clean testing |
| 258 |
2. Run fixup task with invalid/malformed search filter |
| 259 |
3. Verify task completes but logs appropriate error |
| 260 |
4. Check error log for "Bad search filter" message |
| 261 |
:expectedresults: |
| 262 |
1. Error logs should be cleared successfully |
| 263 |
2. Task should be created successfully |
| 264 |
3. Task should complete |
| 265 |
4. Error should be logged about invalid filter |
| 266 |
""" |
| 267 |
|
| 268 |
# Clear error logs to ensure clean testing |
| 269 |
log.info('Clearing error logs before test') |
| 270 |
topology_st.standalone.deleteErrorLogs() |
| 271 |
|
| 272 |
# Try to run fixup task with invalid filter (missing closing parenthesis) |
| 273 |
invalid_filter = '(objectClass=person' |
| 274 |
log.info(f'Running fixup task with invalid filter: {invalid_filter}') |
| 275 |
|
| 276 |
# The task should be created successfully even with invalid filter |
| 277 |
task = memberof.fixup(basedn=DEFAULT_SUFFIX, _filter=invalid_filter) |
| 278 |
|
| 279 |
# Wait for task to complete |
| 280 |
task.wait() |
| 281 |
|
| 282 |
# Check that appropriate error was logged |
| 283 |
log.info('Checking error log for filter error message') |
| 284 |
assert topology_st.standalone.ds_error_log.match('.*Bad search filter.*') |
| 285 |
|
| 286 |
|
| 287 |
if __name__ == '__main__': |
| 288 |
# Run isolated |
| 289 |
# -s for DEBUG mode |
| 290 |
CURRENT_FILE = os.path.realpath(__file__) |
| 291 |
pytest.main(["-s", CURRENT_FILE]) |
| 292 |
|