/* * Copyright (c) 2016-present, RxJava Contributors. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in * compliance with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software distributed under the License is * distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See * the License for the specific language governing permissions and limitations under the License. */ package io.reactivex.rxjava3.validators; import java.io.*; import java.util.*; import org.junit.Test; import io.reactivex.rxjava3.testsupport.TestHelper; /** * These tests verify the code style that a typical closing curly brace * and the next annotation @ indicator * are not separated by less than or more than one empty line. *

Thus this is detected: *


 * }
 * @Override
 * 
*

* as well as *


 * }
 * 
 * 
 * @Override
 * 
*/ public class NewLinesBeforeAnnotation { @Test public void missingEmptyNewLine() throws Exception { findPattern(0); } @Test public void tooManyEmptyNewLines2() throws Exception { findPattern(2); } @Test public void tooManyEmptyNewLines3() throws Exception { findPattern(3); } @Test public void tooManyEmptyNewLines4() throws Exception { findPattern(4); } @Test public void tooManyEmptyNewLines5() throws Exception { findPattern(5); } static void findPattern(int newLines) throws Exception { File f = TestHelper.findSource("Flowable"); if (f == null) { System.out.println("Unable to find sources of RxJava"); return; } Queue dirs = new ArrayDeque<>(); StringBuilder fail = new StringBuilder(); fail.append("The following code pattern was found: "); fail.append("\\}\\R"); for (int i = 0; i < newLines; i++) { fail.append("\\R"); } fail.append("[ ]+@\n"); File parent = f.getParentFile().getParentFile(); dirs.offer(new File(parent.getAbsolutePath().replace('\\', '/'))); dirs.offer(new File(parent.getAbsolutePath().replace('\\', '/').replace("src/main/java", "src/test/java"))); int total = 0; while (!dirs.isEmpty()) { f = dirs.poll(); File[] list = f.listFiles(); if (list != null && list.length != 0) { for (File u : list) { if (u.isDirectory()) { dirs.offer(u); } else { String fname = u.getName(); if (fname.endsWith(".java")) { List lines = new ArrayList<>(); BufferedReader in = new BufferedReader(new FileReader(u)); try { for (;;) { String line = in.readLine(); if (line == null) { break; } lines.add(line); } } finally { in.close(); } for (int i = 0; i < lines.size() - 1; i++) { String line = lines.get(i); if (line.endsWith("}") && !line.trim().startsWith("*") && !line.trim().startsWith("//")) { int emptyLines = 0; boolean found = false; for (int j = i + 1; j < lines.size(); j++) { String line2 = lines.get(j); if (line2.trim().startsWith("@")) { found = true; break; } if (!line2.trim().isEmpty()) { break; } emptyLines++; } if (emptyLines == newLines && found) { fail .append(fname) .append("#L").append(i + 1) .append(" "); for (int k = 0; k < emptyLines + 2; k++) { fail .append(lines.get(k + i)) .append("\\R"); } fail.append("\n"); total++; } } } } } } } } if (total != 0) { fail.append("Found ") .append(total) .append(" instances"); System.out.println(fail); throw new AssertionError(fail.toString()); } } }