package pkg func gen() []int { return make([]int, 1) } func fn() { var pa *[5]int var s []int var m map[int]int var ch chan int if s == nil || len(s) == 0 { //@ diag(re`should omit nil check.+for nil slices`) } if m == nil || len(m) == 0 { //@ diag(re`should omit nil check.+for nil maps`) } if ch == nil || len(ch) == 0 { //@ diag(re`should omit nil check.+for nil channels`) } if s != nil && len(s) != 0 { //@ diag(`should omit nil check`) } if m != nil && len(m) > 0 { //@ diag(`should omit nil check`) } if s != nil && len(s) > 5 { //@ diag(`should omit nil check`) } if s != nil && len(s) >= 5 { //@ diag(`should omit nil check`) } const five = 5 if s != nil && len(s) == five { //@ diag(`should omit nil check`) } if ch != nil && len(ch) == 5 { //@ diag(`should omit nil check`) } if pa == nil || len(pa) == 0 { // nil check cannot be removed with pointer to an array } if s == nil || len(m) == 0 { // different variables } if s != nil && len(m) == 1 { // different variables } var ch2 chan int if ch == ch2 || len(ch) == 0 { // not comparing with nil } if ch != ch2 && len(ch) != 0 { // not comparing with nil } const zero = 0 if s != nil && len(s) == zero { // nil check is not redundant here } if s != nil && len(s) == 0 { // nil check is not redundant here } if s != nil && len(s) >= 0 { // nil check is not redundant here (though len(s) >= 0 is) } one := 1 if s != nil && len(s) == one { // nil check is not redundant here } if s != nil && len(s) == len(m) { // nil check is not redundant here } if s != nil && len(s) != 1 { // nil check is not redundant here } if s != nil && len(s) < 5 { // nil check is not redundant here } if s != nil && len(s) <= 5 { // nil check is not redundant here } if s != nil && len(s) != len(ch) { // nil check is not redundant here } if gen() != nil && len(gen()) != 0 { // nil check is not redundant, gen() isn't pure } } func fn3() { var x []int if x == nil || len(x) == 0 { //@ diag(`should omit nil check`) } len := func([]int) int { return 10 } if x == nil || len(x) == 0 { } } func issue1527() { var t struct { pa *[5]int s []int m map[uint64]bool ch chan int } if t.s == nil || len(t.s) == 0 { //@ diag(`should omit nil check`) } if t.m == nil || len(t.m) == 0 { //@ diag(`should omit nil check`) } if t.ch == nil || len(t.ch) == 0 { //@ diag(`should omit nil check`) } if t.pa == nil || len(t.pa) == 0 { // nil check cannot be removed with pointer to an array } } func issue1605() { var s []int var m map[int]int var ch chan int if s == nil || len(s) <= 0 { //@ diag(`should omit nil check`) } if m == nil || len(m) <= 0 { //@ diag(`should omit nil check`) } if ch == nil || len(ch) <= 0 { //@ diag(`should omit nil check`) } if s == nil || len(s) < 2 { //@ diag(`should omit nil check`) } if m == nil || len(m) < 2 { //@ diag(`should omit nil check`) } if ch == nil || len(ch) < 2 { //@ diag(`should omit nil check`) } if s == nil || len(s) <= 2 { //@ diag(`should omit nil check`) } if m == nil || len(m) <= 2 { //@ diag(`should omit nil check`) } if ch == nil || len(ch) <= 2 { //@ diag(`should omit nil check`) } if s == nil || len(s) < 0 { // nil check is not redundant here (len(s) < 0 is impossible) } if m == nil || len(m) < 0 { // nil check is not redundant here (len(m) < 0 is impossible) } if ch == nil || len(ch) < 0 { // nil check is not redundant here (len(ch) < 0 is impossible) } if s == nil || len(s) > 2 { // nil check is not redundant here } if m == nil || len(m) > 2 { // nil check is not redundant here } if ch == nil || len(ch) > 2 { // nil check is not redundant here } }