/* SPDX-FileCopyrightText: 2020 Klarälvdalens Datakonsult AB a KDAB Group company info@kdab.com SPDX-FileContributor: Nicolas Fella SPDX-License-Identifier: LGPL-2.0-or-later */ #include "jnisignatures.h" #include "HierarchyUtils.h" #include "StringUtils.h" #include "clazy_stl.h" #include #include #include #include #include #include #include #include #include #include #include using namespace clang; static const std::regex methodSignatureRegex("\\((\\[?([ZBCSIJFD]|L([a-zA-Z]+\\/)*[a-zA-Z]+;))*\\)\\[?([ZBCSIJFD]|L([a-zA-Z]+\\/)*[a-zA-Z]+;|V)"); static const std::regex classNameRegex("([a-zA-Z]+\\/)*[a-zA-Z]+"); static const std::regex methodNameRegex("[a-zA-Z]+"); bool checkSignature(const std::string &signature, const std::regex &expr) { std::smatch match; return std::regex_match(signature, match, expr); } template void JniSignatures::checkArgAt(T *call, unsigned int index, const std::regex &expr, const std::string &errorMessage) { if (call->getNumArgs() < index + 1) { return; } auto *stringLiteral = clazy::getFirstChildOfType2(call->getArg(index)); if (!stringLiteral) { return; } if (stringLiteral->getCharByteWidth() != 1) { return; } const std::string signature = stringLiteral->getString().str(); const bool valid = checkSignature(signature, expr); if (!valid) { emitWarning(call, errorMessage + ": '" + signature + "'"); } } void JniSignatures::checkFunctionCall(Stmt *stm) { auto *callExpr = dyn_cast(stm); if (!callExpr) { return; } auto *funDecl = callExpr->getDirectCallee(); if (!funDecl) { return; } const std::string qualifiedName = funDecl->getQualifiedNameAsString(); if (!clazy::startsWith(qualifiedName, "QAndroidJniObject::")) { return; } const std::string name = clazy::name(funDecl).str(); if (name == "callObjectMethod" || name == "callMethod") { checkArgAt(callExpr, 0, methodNameRegex, "Invalid method name"); checkArgAt(callExpr, 1, methodSignatureRegex, "Invalid method signature"); } else if (name == "callStaticObjectMethod" || name == "callStaticMethod") { checkArgAt(callExpr, 0, classNameRegex, "Invalid class name"); checkArgAt(callExpr, 1, methodNameRegex, "Invalid method name"); checkArgAt(callExpr, 2, methodSignatureRegex, "Invalid method signature"); } } void JniSignatures::checkConstructorCall(Stmt *stm) { auto *constructExpr = dyn_cast(stm); if (!constructExpr) { return; } auto *funDecl = constructExpr->getConstructor(); const std::string qualifiedName = funDecl->getQualifiedNameAsString(); if (qualifiedName != "QAndroidJniObject::QAndroidJniObject") { return; } checkArgAt(constructExpr, 0, classNameRegex, "Invalid class name"); checkArgAt(constructExpr, 1, methodSignatureRegex, "Invalid constructor signature"); } void JniSignatures::VisitStmt(Stmt *stm) { checkConstructorCall(stm); checkFunctionCall(stm); }