/* SPDX-FileCopyrightText: 2015 Klarälvdalens Datakonsult AB a KDAB Group company info@kdab.com SPDX-FileContributor: Sérgio Martins SPDX-FileCopyrightText: 2015 Sergio Martins SPDX-License-Identifier: LGPL-2.0-or-later */ #include "assert-with-side-effects.h" #include "MacroUtils.h" #include "StringUtils.h" #include "clazy_stl.h" #include #include #include #include #include #include #include #include #include #include #include #include using namespace clang; static bool functionIsOk(StringRef name) { static const std::vector whitelist = { "qFuzzyIsNull", "qt_noop", "qt_assert", "qIsFinite", "qIsInf", "qIsNaN", "qIsNumericType", "operator==", "operator<", "operator>", "operator<=", "operator>=", "operator!=", "operator+", "operator-", "q_func", "d_func", "isEmptyHelper", "qCross", "qMin", "qMax", "qBound", "priv", "qobject_cast", "dbusService", }; return clazy::contains(whitelist, name); } static bool methodIsOK(const std::string &name) { static const std::vector whitelist = { "QList::begin", "QList::end", "QVector::begin", "QVector::end", "QHash::begin", "QHash::end", "QByteArray::data", "QBasicMutex::isRecursive", "QLinkedList::begin", "QLinkedList::end", "QDataBuffer::first", "QOpenGLFunctions::glIsRenderbuffer", }; return clazy::contains(whitelist, name); } void AssertWithSideEffects::VisitStmt(Stmt *stm) { const SourceLocation stmStart = stm->getBeginLoc(); if (!clazy::isInMacro(astContext(), stmStart, "Q_ASSERT")) { return; } bool warn = false; const bool checkfunctions = m_aggressiveness & AlsoCheckFunctionCallsAggressiveness; auto *memberCall = dyn_cast(stm); if (memberCall) { if (checkfunctions) { CXXMethodDecl *method = memberCall->getMethodDecl(); if (!method->isConst() && !methodIsOK(clazy::qualifiedMethodName(method)) && !functionIsOk(clazy::name(method))) { // llvm::errs() << "reason1 " << clazy::qualifiedMethodName(method) << "\n"; warn = true; } } } else if (auto *call = dyn_cast(stm)) { // Non member function calls not allowed FunctionDecl *func = call->getDirectCallee(); if (func && checkfunctions) { if (isa(func)) { // This will be visited next, so ignore it now return; } if (functionIsOk(clazy::name(func))) { return; } warn = true; } } else if (auto *op = dyn_cast(stm)) { if (op->isAssignmentOp()) { if (auto *declRef = dyn_cast(op->getLHS())) { ValueDecl *valueDecl = declRef->getDecl(); if (valueDecl && sm().isBeforeInSLocAddrSpace(valueDecl->getBeginLoc(), stmStart)) { // llvm::errs() << "reason3\n"; warn = true; } } } } else if (auto *op = dyn_cast(stm)) { if (auto *declRef = dyn_cast(op->getSubExpr())) { ValueDecl *valueDecl = declRef->getDecl(); auto type = op->getOpcode(); if (type != UnaryOperatorKind::UO_Deref && type != UnaryOperatorKind::UO_AddrOf) { if (valueDecl && sm().isBeforeInSLocAddrSpace(valueDecl->getBeginLoc(), stmStart)) { // llvm::errs() << "reason5 " << op->getOpcodeStr() << "\n"; warn = true; } } } } if (warn) { emitWarning(stmStart, "Code inside Q_ASSERT has side-effects but won't be built in release mode"); } }