/* SPDX-FileCopyrightText: 2016 Sergio Martins SPDX-License-Identifier: LGPL-2.0-or-later */ #include "ctor-missing-parent-argument.h" #include "QtUtils.h" #include "StringUtils.h" #include "TypeUtils.h" #include #include #include #include #include #include using namespace clang; std::string CtorMissingParentArgument::expectedParentTypeFor(CXXRecordDecl *decl) { if (const auto parent = qtNamespaced("QWidget"); clazy::derivesFrom(decl, parent)) { return parent; } if (const auto parent = qtNamespaced("QQuickItem"); clazy::derivesFrom(decl, parent)) { return parent; } else if (clazy::derivesFrom(decl, qtNamespaced("Qt3DCore::QEntity"))) { return qtNamespaced("Qt3DCore::QNode"); } return qtNamespaced("QObject"); } void CtorMissingParentArgument::VisitDecl(Decl *decl) { auto *record = dyn_cast(decl); bool ok = false; if (!record || !clazy::isQObject(record, m_context->qtNamespace())) { return; } if (record->hasInheritedConstructor()) { // When doing using QObject::QObject you inherit the ctors from QObject, so don't warn. // Would be nicer to check if the using directives really refer to QObject::QObject and not to // Some other non-object class, but I can't find a way to get to ConstructorUsingShadowDecl from the CxxRecordDecl // so we might miss some true-positives return; } const bool hasCtors = record->ctor_begin() != record->ctor_end(); if (!hasCtors) { return; } const std::string parentType = expectedParentTypeFor(record); int numCtors = 0; const bool hasQObjectParam = clazy::recordHasCtorWithParam(record, parentType, /*by-ref*/ ok, /*by-ref*/ numCtors); if (!ok) { return; } if (numCtors > 0 && !hasQObjectParam) { clang::CXXRecordDecl *baseClass = clazy::getQObjectBaseClass(record, m_context->qtNamespace()); const bool baseHasQObjectParam = clazy::recordHasCtorWithParam(baseClass, parentType, /*by-ref*/ ok, /*by-ref*/ numCtors); if (ok && !baseHasQObjectParam && sm().isInSystemHeader(baseClass->getBeginLoc())) { // If the base class ctors don't accept QObject, and it's declared in a system header don't warn return; } if (clazy::name(baseClass) == "QCoreApplication") { return; } emitWarning(decl, record->getQualifiedNameAsString() + std::string(" should take ") + parentType + std::string(" parent argument in CTOR")); } }