/* SPDX-FileCopyrightText: 2016 Sergio Martins SPDX-License-Identifier: LGPL-2.0-or-later */ #include "base-class-event.h" #include "HierarchyUtils.h" #include "QtUtils.h" #include "clazy_stl.h" #include #include #include #include #include #include #include #include using namespace clang; void BaseClassEvent::VisitDecl(Decl *decl) { auto *method = dyn_cast(decl); if (!method || !method->hasBody() || !method->isThisDeclarationADefinition()) { return; } const std::string methodName = method->getNameAsString(); const bool isEvent = methodName == "event"; const bool isEventFilter = isEvent ? false : methodName == "eventFilter"; if (!isEvent && !isEventFilter) { return; } CXXRecordDecl *classDecl = method->getParent(); if (!clazy::isQObject(classDecl, m_context->qtNamespace())) { return; } if (clazy::contains(std::array({"QObject", "QWidget"}), trimQtNamespace(classDecl->getQualifiedNameAsString()))) { return; } CXXRecordDecl *baseClass = clazy::getQObjectBaseClass(classDecl, m_context->qtNamespace()); const std::string baseClassName = baseClass ? trimQtNamespace(baseClass->getQualifiedNameAsString()) : std::string("BaseClass"); if (isEventFilter && clazy::contains(std::array({"QObject", "QWidget"}), baseClassName)) { // This is fine, QObject and QWidget eventFilter() don't do anything return; } Stmt *body = method->getBody(); std::vector returns; clazy::getChilds(body, /*by-ref*/ returns); for (ReturnStmt *returnStmt : returns) { Stmt *maybeBoolExpr = clazy::childAt(returnStmt, 0); if (!maybeBoolExpr) { continue; } auto *boolExpr = dyn_cast(maybeBoolExpr); if (!boolExpr || boolExpr->getValue()) { // if getValue() is true that's a return true, which is fine continue; } emitWarning(returnStmt->getBeginLoc(), "Return " + baseClassName + "::" + methodName + "() instead of false"); } }