/* SPDX-FileCopyrightText: 2017 Sergio Martins SPDX-License-Identifier: LGPL-2.0-or-later */ #include "skipped-base-method.h" #include "FunctionUtils.h" #include "HierarchyUtils.h" #include "TypeUtils.h" #include #include #include #include #include #include #include #include using namespace clang; void SkippedBaseMethod::VisitStmt(clang::Stmt *stmt) { auto *memberCall = dyn_cast(stmt); if (!memberCall) { return; } auto *expr = memberCall->getImplicitObjectArgument(); auto *thisExpr = clazy::unpeal(expr, clazy::IgnoreImplicitCasts); if (!thisExpr) { return; } const CXXRecordDecl *thisClass = thisExpr->getType()->getPointeeCXXRecordDecl(); const CXXRecordDecl *baseClass = memberCall->getRecordDecl(); std::vector baseClasses; if (!clazy::derivesFrom(thisClass, baseClass, &baseClasses) || baseClasses.size() < 2) { return; } // We're calling a grand-base method, so check if a more direct base also implements it for (int i = baseClasses.size() - 1; i > 0; --i) { // the higher indexes have the most derived classes CXXRecordDecl *moreDirectBaseClass = baseClasses[i]; if (clazy::classImplementsMethod(moreDirectBaseClass, memberCall->getMethodDecl())) { std::string msg = "Maybe you meant to call " + moreDirectBaseClass->getNameAsString() + "::" + memberCall->getMethodDecl()->getNameAsString() + "() instead"; emitWarning(stmt, msg); } } }