/* SPDX-FileCopyrightText: 2015 Klarälvdalens Datakonsult AB a KDAB Group company info@kdab.com SPDX-FileContributor: Sérgio Martins SPDX-FileCopyrightText: 2015 Sergio Martins SPDX-License-Identifier: LGPL-2.0-or-later */ #include "non-pod-global-static.h" #include "ClazyContext.h" #include "QtUtils.h" #include "clazy_stl.h" #include #include #include #include #include #include #include #include #include #include #include #include using namespace clang; static bool shouldIgnoreType(StringRef name) { static std::vector blacklist = {"Holder", "AFUNC", "QLoggingCategory", "QThreadStorage", "QQmlModuleRegistration"}; return clazy::contains(blacklist, name); } NonPodGlobalStatic::NonPodGlobalStatic(const std::string &name, Options options) : CheckBase(name, options) { m_filesToIgnore = {"main.cpp", "qrc_", "qdbusxml2cpp"}; } void NonPodGlobalStatic::VisitStmt(clang::Stmt *stm) { VarDecl *varDecl = m_context->lastDecl ? dyn_cast(m_context->lastDecl) : nullptr; if (!varDecl || varDecl->isConstexpr() || varDecl->isExternallyVisible() || !varDecl->isFileVarDecl()) { return; } if (shouldIgnoreFile(stm->getBeginLoc())) { return; } StorageDuration sd = varDecl->getStorageDuration(); if (sd != StorageDuration::SD_Static) { return; } const SourceLocation declStart = varDecl->getBeginLoc(); if (declStart.isMacroID()) { SourceLocation immediateMacroLoc = declStart; // Walk up the macro expansion stack while (immediateMacroLoc.isMacroID()) { static const std::vector macrosToIgnore{ "Q_IMPORT_PLUGIN", "Q_CONSTRUCTOR_FUNCTION", "Q_DESTRUCTOR_FUNCTION", "Q_COREAPP_STARTUP_FUNCTION", }; auto macroName = std::string_view(Lexer::getImmediateMacroName(immediateMacroLoc, sm(), lo())); if (clazy::startsWithAny(macroName, macrosToIgnore)) return; immediateMacroLoc = sm().getImmediateMacroCallerLoc(immediateMacroLoc); } } auto *ctorExpr = dyn_cast(stm); if (!ctorExpr) { return; } auto *ctorDecl = ctorExpr->getConstructor(); auto *recordDecl = ctorDecl ? ctorDecl->getParent() : nullptr; if (!recordDecl) { return; } if (recordDecl->hasTrivialDestructor()) { // Has a trivial dtor, but now lets check the ctors. if (ctorDecl->isDefaultConstructor() && recordDecl->hasTrivialDefaultConstructor()) { // both dtor and called ctor are trivial, no warning return; } if (ctorDecl->isConstexpr()) { // Used ctor is constexpr, it's fine return; } } if (m_context->isQtDeveloper() && clazy::isBootstrapping(m_context->m_pp)) { return; } StringRef className = clazy::name(recordDecl); if (!shouldIgnoreType(className)) { const std::string varName = varDecl->getQualifiedNameAsString(); const std::string error = std::string("non-POD static (") + className.data() + " " + varName + std::string(")"); // Do not emit warnings for each entry in collection - this is overkill since we emit it for the declaration // Traversing the ParentMap unfortunately does not work, because it is cut of at the initializer list if (std::ranges::find(m_emittedWarnings, declStart.getRawEncoding()) != m_emittedWarnings.end()) { return; } m_emittedWarnings.push_back(declStart.getRawEncoding()); emitWarning(declStart, error); } }