/* SPDX-FileCopyrightText: 2017 Sergio Martins SPDX-FileCopyrightText: 2024 Alexander Lohnau SPDX-License-Identifier: LGPL-2.0-or-later */ #include "connect-3arg-lambda.h" #include "HierarchyUtils.h" #include "QtUtils.h" #include "TypeUtils.h" #include #include #include #include #include #include #include using namespace clang; using uint = unsigned; void Connect3ArgLambda::VisitStmt(clang::Stmt *stmt) { auto *callExpr = dyn_cast(stmt); if (!callExpr) { return; } FunctionDecl *fdecl = callExpr->getDirectCallee(); if (!fdecl) { return; } const uint numParams = fdecl->getNumParams(); if (numParams != 2 && numParams != 3) { return; } const std::string qualifiedName = trimQtNamespace(fdecl->getQualifiedNameAsString()); if (qualifiedName == "QTimer::singleShot") { processQTimer(fdecl, stmt); return; } if (qualifiedName == "QMenu::addAction") { processQMenu(fdecl, stmt); return; } if (qualifiedName == "QWidget::addAction") { processWidget(fdecl, stmt); return; } if (numParams != 3 || !clazy::isConnect(fdecl, m_context->qtNamespace())) { return; } auto *arg3 = callExpr->getArg(2); auto *lambda = clang::dyn_cast_or_null(arg3); if (!lambda) { lambda = clazy::getFirstChildOfType2(arg3); if (!lambda) { return; } } DeclRefExpr *senderDeclRef = nullptr; Stmt *s = callExpr->getArg(0); while (s) { if ((senderDeclRef = dyn_cast(s))) { break; } if (isa(s)) { break; } s = clazy::getFirstChild(s); } // The sender can be: this const auto *senderThis = clazy::unpeal(callExpr->getArg(0), clazy::IgnoreImplicitCasts); // The variables used inside the lambda auto declrefs = clazy::getStatements(lambda->getBody()); const ValueDecl *senderDecl = senderDeclRef ? senderDeclRef->getDecl() : nullptr; // We'll only warn if the lambda is dereferencing another QObject (besides the sender) bool found = false; for (auto *declref : declrefs) { ValueDecl *decl = declref->getDecl(); if (decl == senderDecl) { continue; // It's the sender, continue. } if (clazy::isQObject((clazy::pointeeQualType(decl->getType()))->getAsCXXRecordDecl(), m_context->qtNamespace())) { found = true; break; } } if (!found) { auto thisexprs = clazy::getStatements(lambda->getBody()); if (!thisexprs.empty() && !senderThis) { found = true; } } if (found) { emitWarning(stmt, "Pass a context object as 3rd connect parameter"); } } void Connect3ArgLambda::processQTimer(FunctionDecl *func, Stmt *stmt) { // Signatures to catch: // QTimer::singleShot(int msec, Functor functor) // QTimer::singleShot(int msec, Qt::TimerType timerType, Functor functor) const uint numParams = func->getNumParams(); if (numParams == 2) { if (func->getParamDecl(0)->getNameAsString() == "interval" && func->getParamDecl(1)->getNameAsString() == "slot") { emitWarning(stmt, "Pass a context object as 2nd singleShot parameter"); } } else if (numParams == 3) { if (func->getParamDecl(0)->getNameAsString() == "interval" && func->getParamDecl(1)->getNameAsString() == "timerType" && func->getParamDecl(2)->getNameAsString() == "slot") { emitWarning(stmt, "Pass a context object as 3rd singleShot parameter"); } } } void Connect3ArgLambda::processQMenu(FunctionDecl *func, Stmt *stmt) { // Signatures to catch: // QMenu::addAction(const QString &text, Func1 slot, const QKeySequence &shortcut = 0) const uint numParams = func->getNumParams(); if (numParams == 3) { if (func->getParamDecl(0)->getNameAsString() == "text" && func->getParamDecl(1)->getNameAsString() == "slot" && func->getParamDecl(2)->getNameAsString() == "shortcut") { emitWarning(stmt, "Pass a context object as 2nd addAction parameter"); } } } void Connect3ArgLambda::processWidget(clang::FunctionDecl *func, clang::Stmt *stmt) { if (const uint numParams = func->getNumParams(); numParams > 1) { auto *possiblyFwdArgToConnect = func->getParamDecl(numParams - 2); auto *fwdArgToConnect = func->getParamDecl(numParams - 1); if (possiblyFwdArgToConnect->getNameAsString() != "args" && fwdArgToConnect->getNameAsString() == "args") { emitWarning(stmt, "Pass a context object as 2nd addAction parameter"); } } }