/* SPDX-FileCopyrightText: 2020 Sergio Martins SPDX-License-Identifier: LGPL-2.0-or-later */ #include "qstring-comparison-to-implicit-char.h" #include "HierarchyUtils.h" #include "QtUtils.h" #include "TypeUtils.h" #include "Utils.h" #include using namespace clang; void QStringComparisonToImplicitChar::VisitStmt(clang::Stmt *stmt) { auto *callExpr = dyn_cast(stmt); if (!callExpr || !callExpr->getCalleeDecl() || callExpr->getNumArgs() != 2) { return; } Expr *arg1 = callExpr->getArg(1); const auto *il = clazy::getFirstChildOfType2(arg1); if (!il) { return; } auto *functionDecl = dyn_cast(callExpr->getCalleeDecl()); // We only care about the non-member functions if (!functionDecl || functionDecl->getOverloadedOperator() != clang::OO_EqualEqual || isa(functionDecl) || functionDecl->getNumParams() != 2) { return; } ParmVarDecl *parm1 = functionDecl->getParamDecl(0); if (parm1->getType().getAsString(lo()) != "const QString &") { return; } ParmVarDecl *parm2 = functionDecl->getParamDecl(1); if (parm2->getType().getAsString(lo()) != "QChar") { return; } emitWarning(stmt, "QString being compared to implicit QChar"); }